[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Use standard close icon

2017-09-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/376869 )

Change subject: Use standard close icon
..


Use standard close icon

Using standard close icon and slightly increase button size.
Also removing redundant, default CSS values and reducing SVG file
size with SVGO optimized SVG.

Bug: T50067
Change-Id: I532db809215a2896855c73c885c1394952ab426c
---
M resources/css/ext.translate.editor.css
M resources/images/close.png
M resources/images/close.svg
3 files changed, 11 insertions(+), 47 deletions(-)

Approvals:
  jenkins-bot: Verified
  Nikerabbit: Looks good to me, approved



diff --git a/resources/css/ext.translate.editor.css 
b/resources/css/ext.translate.editor.css
index 8d5b261..0294693 100644
--- a/resources/css/ext.translate.editor.css
+++ b/resources/css/ext.translate.editor.css
@@ -6,33 +6,32 @@
box-shadow: 0 2px 6px rgba( 0, 0, 0, 0.3 );
 }
 
-/* Temporary fix for T111685 */
 .grid .tux-message-editor .close {
-   background: url( ../images/close.png ) no-repeat scroll center center 
transparent;
+   background: url( ../images/close.png ) no-repeat center center;
background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/close.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/close.svg );
-   padding: 15px;
+   padding: 16px;
cursor: pointer;
float: right;
+   opacity: 0.87;
 }
 
-/* Temporary fix for T111685 */
 .grid .tux-message-editor .editor-info-toggle {
-   padding: 15px;
+   padding: 16px;
cursor: pointer;
float: right;
 }
 
 .tux-message-editor .editor-contract {
-   background: url( ../images/contract-ltr.png ) no-repeat scroll center 
center transparent;
+   background: url( ../images/contract-ltr.png ) no-repeat center center;
background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/contract-ltr.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/contract-ltr.svg );
 }
 
 .tux-message-editor .editor-expand {
-   background: url( ../images/expand-ltr.png ) no-repeat scroll center 
center transparent;
+   background: url( ../images/expand-ltr.png ) no-repeat center center;
background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/expand-ltr.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/expand-ltr.svg );
@@ -230,7 +229,7 @@
 }
 
 .message-desc-edit {
-   background: transparent url( ../images/action-edit.png ) left center 
no-repeat;
+   background: url( ../images/action-edit.png ) left center no-repeat;
background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/action-edit.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/action-edit.svg );
diff --git a/resources/images/close.png b/resources/images/close.png
index 84631c3..80dde95 100644
--- a/resources/images/close.png
+++ b/resources/images/close.png
Binary files differ
diff --git a/resources/images/close.svg b/resources/images/close.svg
index 375b4f5..7f75511 100644
--- a/resources/images/close.svg
+++ b/resources/images/close.svg
@@ -1,40 +1,5 @@
-
-
-
-http://purl.org/dc/elements/1.1/";
-   xmlns:cc="http://creativecommons.org/ns#";
-   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#";
-   xmlns:svg="http://www.w3.org/2000/svg";
-   xmlns="http://www.w3.org/2000/svg";
-   version="1.1"
-   width="12"
-   height="12"
-   id="svg2">
-  
-  
-
-  
-image/svg+xml
-http://purl.org/dc/dcmitype/StillImage"; />
-
-  
-
-  
-  
-
-
-  
+
+http://www.w3.org/2000/svg"; width="20" height="20" viewBox="0 0 20 
20">
+   
+   
 

-- 
To view, visit https://gerrit.wikimedia.org/r/376869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I532db809215a2896855c73c885c1394952ab426c
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Nikerabbit 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: Use standard close icon

2017-09-08 Thread VolkerE (Code Review) 
VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/376869 )

Change subject: Use standard close icon
..

Use standard close icon

Using standard close icon and slightly increase size.
Also removing redundant, default CSS values.

Bug: T50067
Change-Id: I532db809215a2896855c73c885c1394952ab426c
---
M resources/css/ext.translate.editor.css
M resources/images/close.png
M resources/images/close.svg
3 files changed, 10 insertions(+), 45 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/69/376869/1

diff --git a/resources/css/ext.translate.editor.css 
b/resources/css/ext.translate.editor.css
index 8d5b261..f9ab4bb 100644
--- a/resources/css/ext.translate.editor.css
+++ b/resources/css/ext.translate.editor.css
@@ -8,31 +8,31 @@
 
 /* Temporary fix for T111685 */
 .grid .tux-message-editor .close {
-   background: url( ../images/close.png ) no-repeat scroll center center 
transparent;
+   background: url( ../images/close.png ) no-repeat center center;
background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/close.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/close.svg );
-   padding: 15px;
+   padding: 16px;
cursor: pointer;
float: right;
 }
 
 /* Temporary fix for T111685 */
 .grid .tux-message-editor .editor-info-toggle {
-   padding: 15px;
+   padding: 16px;
cursor: pointer;
float: right;
 }
 
 .tux-message-editor .editor-contract {
-   background: url( ../images/contract-ltr.png ) no-repeat scroll center 
center transparent;
+   background: url( ../images/contract-ltr.png ) no-repeat center center;
background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/contract-ltr.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/contract-ltr.svg );
 }
 
 .tux-message-editor .editor-expand {
-   background: url( ../images/expand-ltr.png ) no-repeat scroll center 
center transparent;
+   background: url( ../images/expand-ltr.png ) no-repeat center center;
background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/expand-ltr.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/expand-ltr.svg );
@@ -230,7 +230,7 @@
 }
 
 .message-desc-edit {
-   background: transparent url( ../images/action-edit.png ) left center 
no-repeat;
+   background: url( ../images/action-edit.png ) left center no-repeat;
background-image: -webkit-linear-gradient( transparent, transparent ), 
url( ../images/action-edit.svg );
/* @embed */
background-image: linear-gradient( transparent, transparent ), url( 
../images/action-edit.svg );
diff --git a/resources/images/close.png b/resources/images/close.png
index 84631c3..80dde95 100644
--- a/resources/images/close.png
+++ b/resources/images/close.png
Binary files differ
diff --git a/resources/images/close.svg b/resources/images/close.svg
index 375b4f5..7f75511 100644
--- a/resources/images/close.svg
+++ b/resources/images/close.svg
@@ -1,40 +1,5 @@
-
-
-
-http://purl.org/dc/elements/1.1/";
-   xmlns:cc="http://creativecommons.org/ns#";
-   xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#";
-   xmlns:svg="http://www.w3.org/2000/svg";
-   xmlns="http://www.w3.org/2000/svg";
-   version="1.1"
-   width="12"
-   height="12"
-   id="svg2">
-  
-  
-
-  
-image/svg+xml
-http://purl.org/dc/dcmitype/StillImage"; />
-
-  
-
-  
-  
-
-
-  
+
+http://www.w3.org/2000/svg"; width="20" height="20" viewBox="0 0 20 
20">
+   
+   
 

-- 
To view, visit https://gerrit.wikimedia.org/r/376869
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I532db809215a2896855c73c885c1394952ab426c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits