[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Tabs (Read / View Source / Search) collapsed under more in r...

2017-09-21 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/368803 )

Change subject: Tabs (Read / View Source / Search) collapsed under more in 
resolution < 700px
..


Tabs (Read / View Source / Search) collapsed under more in resolution < 700px

tabs such as read/view source are collapsed into more in screens
whose resolution is less than 700 px so that they don't wrap to
the next line and cover the content of the page

Bug: T56919
Change-Id: I30e0642d3cb93c4d9a8b2bdfb7f04912d8ca8649
---
M VectorTemplate.php
M components/watchstar.less
2 files changed, 6 insertions(+), 3 deletions(-)

Approvals:
  20after4: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/VectorTemplate.php b/VectorTemplate.php
index 50c4439..c4c6aa5 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -538,9 +538,7 @@
 
// Add CSS class 'collapsible' to links which are not marked as 
"primary"
if (
-   isset( $options['vector-collapsible'] ) && 
$options['vector-collapsible']
-   && !( isset( $item['primary'] ) && $item['primary'] )
-   ) {
+   isset( $options['vector-collapsible'] ) && 
$options['vector-collapsible'] ) {
$item['class'] = rtrim( 'collapsible ' . 
$item['class'], ' ' );
}
 
diff --git a/components/watchstar.less b/components/watchstar.less
index 17bcbd7..cdea9bc 100644
--- a/components/watchstar.less
+++ b/components/watchstar.less
@@ -17,21 +17,26 @@
background-position: 5px 60%;
 }
 #ca-unwatch.icon a {
+   background-repeat: no-repeat;
.background-image-svg( 'images/unwatch-icon.svg', 
'images/unwatch-icon.png' );
 }
 #ca-watch.icon a {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon.svg', 'images/watch-icon.png' 
);
 }
 #ca-unwatch.icon a:hover,
 #ca-unwatch.icon a:focus {
+   background-repeat: no-repeat;
.background-image-svg( 'images/unwatch-icon-hl.svg', 
'images/unwatch-icon-hl.png' );
 }
 #ca-watch.icon a:hover,
 #ca-watch.icon a:focus {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon-hl.svg', 
'images/watch-icon-hl.png' );
 }
 #ca-unwatch.icon a.loading,
 #ca-watch.icon a.loading {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon-loading.svg', 
'images/watch-icon-loading.png' );
.rotation( 700ms );
/* Suppress the hilarious rotating focus outline on Firefox */

-- 
To view, visit https://gerrit.wikimedia.org/r/368803
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I30e0642d3cb93c4d9a8b2bdfb7f04912d8ca8649
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 
Gerrit-Reviewer: 20after4 
Gerrit-Reviewer: Aklapper 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jdlrobson 
Gerrit-Reviewer: Niedzielski 
Gerrit-Reviewer: VolkerE 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Tabs (Read / View Source / Search) collapsed under more in r...

2017-07-31 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368803 )

Change subject: Tabs (Read / View Source / Search) collapsed under more in 
resolution < 700px
..

Tabs (Read / View Source / Search) collapsed under more in resolution < 700px

tabs such as read/view source are collapsed into more in screens
whose resolution is less than 700 px so that they don't wrap to
the next line and cover the content of the page

Bug: T56919
Change-Id: I30e0642d3cb93c4d9a8b2bdfb7f04912d8ca8649
---
M VectorTemplate.php
M components/watchstar.less
2 files changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/03/368803/1

diff --git a/VectorTemplate.php b/VectorTemplate.php
index 50c4439..71b1e10 100644
--- a/VectorTemplate.php
+++ b/VectorTemplate.php
@@ -538,9 +538,7 @@
 
// Add CSS class 'collapsible' to links which are not marked as 
"primary"
if (
-   isset( $options['vector-collapsible'] ) && 
$options['vector-collapsible']
-   && !( isset( $item['primary'] ) && $item['primary'] )
-   ) {
+   isset( $options['vector-collapsible'] ) && 
$options['vector-collapsible']) {
$item['class'] = rtrim( 'collapsible ' . 
$item['class'], ' ' );
}
 
diff --git a/components/watchstar.less b/components/watchstar.less
index 17bcbd7..cdea9bc 100644
--- a/components/watchstar.less
+++ b/components/watchstar.less
@@ -17,21 +17,26 @@
background-position: 5px 60%;
 }
 #ca-unwatch.icon a {
+   background-repeat: no-repeat;
.background-image-svg( 'images/unwatch-icon.svg', 
'images/unwatch-icon.png' );
 }
 #ca-watch.icon a {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon.svg', 'images/watch-icon.png' 
);
 }
 #ca-unwatch.icon a:hover,
 #ca-unwatch.icon a:focus {
+   background-repeat: no-repeat;
.background-image-svg( 'images/unwatch-icon-hl.svg', 
'images/unwatch-icon-hl.png' );
 }
 #ca-watch.icon a:hover,
 #ca-watch.icon a:focus {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon-hl.svg', 
'images/watch-icon-hl.png' );
 }
 #ca-unwatch.icon a.loading,
 #ca-watch.icon a.loading {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon-loading.svg', 
'images/watch-icon-loading.png' );
.rotation( 700ms );
/* Suppress the hilarious rotating focus outline on Firefox */

-- 
To view, visit https://gerrit.wikimedia.org/r/368803
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I30e0642d3cb93c4d9a8b2bdfb7f04912d8ca8649
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Tabs (Read / View Source / Search) collapsed under more in r...

2017-07-31 Thread Rammanojpotla (Code Review) 
Rammanojpotla has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368799 )

Change subject: Tabs (Read / View Source / Search) collapsed under more in 
resolution < 700px
..

Tabs (Read / View Source / Search) collapsed under more in resolution < 700px

tabs such as read/view source are collapsed into more in screens
whose resolution is less than 700 px so that they don't wrap to
the next line and cover the content of the page

Bug: T56919
Change-Id: I0bec642cf382aabbc088ce99aa233b9020fc22c1
---
M components/watchstar.less
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/Vector 
refs/changes/99/368799/1

diff --git a/components/watchstar.less b/components/watchstar.less
index 17bcbd7..cdea9bc 100644
--- a/components/watchstar.less
+++ b/components/watchstar.less
@@ -17,21 +17,26 @@
background-position: 5px 60%;
 }
 #ca-unwatch.icon a {
+   background-repeat: no-repeat;
.background-image-svg( 'images/unwatch-icon.svg', 
'images/unwatch-icon.png' );
 }
 #ca-watch.icon a {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon.svg', 'images/watch-icon.png' 
);
 }
 #ca-unwatch.icon a:hover,
 #ca-unwatch.icon a:focus {
+   background-repeat: no-repeat;
.background-image-svg( 'images/unwatch-icon-hl.svg', 
'images/unwatch-icon-hl.png' );
 }
 #ca-watch.icon a:hover,
 #ca-watch.icon a:focus {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon-hl.svg', 
'images/watch-icon-hl.png' );
 }
 #ca-unwatch.icon a.loading,
 #ca-watch.icon a.loading {
+   background-repeat: no-repeat;
.background-image-svg( 'images/watch-icon-loading.svg', 
'images/watch-icon-loading.png' );
.rotation( 700ms );
/* Suppress the hilarious rotating focus outline on Firefox */

-- 
To view, visit https://gerrit.wikimedia.org/r/368799
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bec642cf382aabbc088ce99aa233b9020fc22c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/Vector
Gerrit-Branch: master
Gerrit-Owner: Rammanojpotla 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits