[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Missing i18n in gallery dialog

2016-11-23 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: Missing i18n in gallery dialog
..


Missing i18n in gallery dialog

Change-Id: I369d5b9d42a5fd6b4d1afc12508632a282591320
---
M extension.json
M modules/ve-mw/i18n/en.json
M modules/ve-mw/i18n/qqq.json
M modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
4 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Jforrester: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index ec17413..c773073 100644
--- a/extension.json
+++ b/extension.json
@@ -1808,6 +1808,7 @@

"visualeditor-mwgallerydialog-empty-gallery-message",

"visualeditor-mwgallerydialog-heights-field-label",

"visualeditor-mwgallerydialog-heights-input-placeholder",
+   
"visualeditor-mwgallerydialog-image-caption-placeholder",

"visualeditor-mwgallerydialog-mode-dropdown-label-nolines",

"visualeditor-mwgallerydialog-mode-dropdown-label-packed",

"visualeditor-mwgallerydialog-mode-dropdown-label-packed-hover",
diff --git a/modules/ve-mw/i18n/en.json b/modules/ve-mw/i18n/en.json
index 7f370f7..bbf3769 100644
--- a/modules/ve-mw/i18n/en.json
+++ b/modules/ve-mw/i18n/en.json
@@ -283,6 +283,7 @@
"visualeditor-mwgallerydialog-empty-gallery-message": "The gallery is 
empty.",
"visualeditor-mwgallerydialog-heights-field-label": "Image height",
"visualeditor-mwgallerydialog-heights-input-placeholder": "Default 
height: $1 px",
+   "visualeditor-mwgallerydialog-image-caption-placeholder": "Image 
caption",
"visualeditor-mwgallerydialog-mode-dropdown-label-nolines": 
"Traditional with no outlines",
"visualeditor-mwgallerydialog-mode-dropdown-label-packed": "Packed",
"visualeditor-mwgallerydialog-mode-dropdown-label-packed-hover": 
"Packed with captions on hover",
diff --git a/modules/ve-mw/i18n/qqq.json b/modules/ve-mw/i18n/qqq.json
index ae49231..241bf7c 100644
--- a/modules/ve-mw/i18n/qqq.json
+++ b/modules/ve-mw/i18n/qqq.json
@@ -296,6 +296,7 @@
"visualeditor-mwgallerydialog-empty-gallery-message": "Empty gallery 
message for the gallery dialog",
"visualeditor-mwgallerydialog-heights-field-label": "Label for the 
heights field of the gallery dialog",
"visualeditor-mwgallerydialog-heights-input-placeholder": "Placeholder 
for the heights input",
+   "visualeditor-mwgallerydialog-image-caption-placeholder": "Placeholder 
for an image caption",
"visualeditor-mwgallerydialog-mode-dropdown-label-nolines": "Label for 
the nolines option in the mode dropdown of the gallery dialog",
"visualeditor-mwgallerydialog-mode-dropdown-label-packed": "Label for 
the packed option in the mode dropdown of the gallery dialog",
"visualeditor-mwgallerydialog-mode-dropdown-label-packed-hover": "Label 
for the packed-hover option in the mode dropdown of the gallery dialog",
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
index e65c32e..e3feef0 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
@@ -111,7 +111,7 @@
.addClass( 've-ui-mwGalleryDialog-highlighted-image' );
// TODO: make into a ve.ui.MWTargetWidget once Parsoid handles galleries
this.highlightedCaptionInput = new OO.ui.TextInputWidget( {
-   placeholder: 'Image caption',
+   placeholder: ve.msg( 
'visualeditor-mwgallerydialog-image-caption-placeholder' ),
multiline: true,
autosize: true
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/323341
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I369d5b9d42a5fd6b4d1afc12508632a282591320
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Missing i18n in gallery dialog

2016-11-23 Thread Esanders (Code Review) 
Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/323341

Change subject: Missing i18n in gallery dialog
..

Missing i18n in gallery dialog

Change-Id: I369d5b9d42a5fd6b4d1afc12508632a282591320
---
M extension.json
M modules/ve-mw/i18n/en.json
M modules/ve-mw/i18n/qqq.json
M modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
4 files changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/41/323341/1

diff --git a/extension.json b/extension.json
index ec17413..c773073 100644
--- a/extension.json
+++ b/extension.json
@@ -1808,6 +1808,7 @@

"visualeditor-mwgallerydialog-empty-gallery-message",

"visualeditor-mwgallerydialog-heights-field-label",

"visualeditor-mwgallerydialog-heights-input-placeholder",
+   
"visualeditor-mwgallerydialog-image-caption-placeholder",

"visualeditor-mwgallerydialog-mode-dropdown-label-nolines",

"visualeditor-mwgallerydialog-mode-dropdown-label-packed",

"visualeditor-mwgallerydialog-mode-dropdown-label-packed-hover",
diff --git a/modules/ve-mw/i18n/en.json b/modules/ve-mw/i18n/en.json
index 7f370f7..bbf3769 100644
--- a/modules/ve-mw/i18n/en.json
+++ b/modules/ve-mw/i18n/en.json
@@ -283,6 +283,7 @@
"visualeditor-mwgallerydialog-empty-gallery-message": "The gallery is 
empty.",
"visualeditor-mwgallerydialog-heights-field-label": "Image height",
"visualeditor-mwgallerydialog-heights-input-placeholder": "Default 
height: $1 px",
+   "visualeditor-mwgallerydialog-image-caption-placeholder": "Image 
caption",
"visualeditor-mwgallerydialog-mode-dropdown-label-nolines": 
"Traditional with no outlines",
"visualeditor-mwgallerydialog-mode-dropdown-label-packed": "Packed",
"visualeditor-mwgallerydialog-mode-dropdown-label-packed-hover": 
"Packed with captions on hover",
diff --git a/modules/ve-mw/i18n/qqq.json b/modules/ve-mw/i18n/qqq.json
index ae49231..241bf7c 100644
--- a/modules/ve-mw/i18n/qqq.json
+++ b/modules/ve-mw/i18n/qqq.json
@@ -296,6 +296,7 @@
"visualeditor-mwgallerydialog-empty-gallery-message": "Empty gallery 
message for the gallery dialog",
"visualeditor-mwgallerydialog-heights-field-label": "Label for the 
heights field of the gallery dialog",
"visualeditor-mwgallerydialog-heights-input-placeholder": "Placeholder 
for the heights input",
+   "visualeditor-mwgallerydialog-image-caption-placeholder": "Placeholder 
for an image caption",
"visualeditor-mwgallerydialog-mode-dropdown-label-nolines": "Label for 
the nolines option in the mode dropdown of the gallery dialog",
"visualeditor-mwgallerydialog-mode-dropdown-label-packed": "Label for 
the packed option in the mode dropdown of the gallery dialog",
"visualeditor-mwgallerydialog-mode-dropdown-label-packed-hover": "Label 
for the packed-hover option in the mode dropdown of the gallery dialog",
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js 
b/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
index e65c32e..e3feef0 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWGalleryDialog.js
@@ -111,7 +111,7 @@
.addClass( 've-ui-mwGalleryDialog-highlighted-image' );
// TODO: make into a ve.ui.MWTargetWidget once Parsoid handles galleries
this.highlightedCaptionInput = new OO.ui.TextInputWidget( {
-   placeholder: 'Image caption',
+   placeholder: ve.msg( 
'visualeditor-mwgallerydialog-image-caption-placeholder' ),
multiline: true,
autosize: true
} );

-- 
To view, visit https://gerrit.wikimedia.org/r/323341
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I369d5b9d42a5fd6b4d1afc12508632a282591320
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits