[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Un-blacklist the lintid parameter

2017-05-04 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/350313 )

Change subject: Un-blacklist the lintid parameter
..


Un-blacklist the lintid parameter

Bug: T160102
Depends-On: I59a7e0a3e8be32e4689cbf41c4904970902c4dff
Change-Id: Ie0e8d82db2dc3589c58a90a600ac0feb06159ed3
---
M VisualEditor.hooks.php
1 file changed, 1 insertion(+), 2 deletions(-)

Approvals:
  Esanders: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 8b766a0..20e1e09 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -14,9 +14,8 @@
 
// Known parameters that VE does not handle
// TODO: Other params too?
-   // Known-good parameters: edit, veaction, section
+   // Known-good parameters: edit, veaction, section, oldid, lintid
private static $unsupportedEditParams = [
-   'lintid',
'preload',
'preloadparams',
'preloadtitle',

-- 
To view, visit https://gerrit.wikimedia.org/r/350313
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0e8d82db2dc3589c58a90a600ac0feb06159ed3
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 
Gerrit-Reviewer: Esanders 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Un-blacklist the lintid parameter

2017-04-25 Thread Jforrester (Code Review)
Jforrester has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/350313 )

Change subject: Un-blacklist the lintid parameter
..

Un-blacklist the lintid parameter

Depends-On: I59a7e0a3e8be32e4689cbf41c4904970902c4dff
Change-Id: Ie0e8d82db2dc3589c58a90a600ac0feb06159ed3
---
M VisualEditor.hooks.php
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
2 files changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/13/350313/1

diff --git a/VisualEditor.hooks.php b/VisualEditor.hooks.php
index 6cf9256..18abf67 100644
--- a/VisualEditor.hooks.php
+++ b/VisualEditor.hooks.php
@@ -158,7 +158,6 @@
isset( $params['preload'] ) ||
isset( $params['preloadtitle'] ) ||
isset( $params['preloadparams'] ) ||
-   isset( $params['lintid'] ) ||
isset( $params['veswitched'] );
// Known-good parameters: edit, veaction, section
 
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js 
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
index 9a2ae1e..716564f 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.init.js
@@ -873,7 +873,6 @@
uri.query.preload === undefined &&
uri.query.preloadtitle === undefined &&
uri.query.preloadparams === undefined &&
-   uri.query.lintid === undefined &&
uri.query.veswitched === undefined
// Known-good parameters: edit, veaction, 
section
// TODO: other params too? See identical list 
in VisualEditor.hooks.php)

-- 
To view, visit https://gerrit.wikimedia.org/r/350313
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0e8d82db2dc3589c58a90a600ac0feb06159ed3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits