[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ve.ui.MWAdvancedSettingsPage: Actually display help for sett...

2017-02-15 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/338039 )

Change subject: ve.ui.MWAdvancedSettingsPage: Actually display help for 
settings about language variants
..


ve.ui.MWAdvancedSettingsPage: Actually display help for settings about language 
variants

Follow-up to 712ea472d34371176bb08b79c723374fa6800dd6.

Change-Id: I2f3617fb4e9a80272e559b35c947052c0d8e534b
---
M modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
index e1c4922..0e13cd4 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
@@ -118,7 +118,8 @@
new OO.ui.CheckboxInputWidget(),
{
align: 'inline',
-   label: this.label
+   label: this.label,
+   help: this.help
}
);
advancedSettingsPage.advancedSettingsFieldset.addItems( [ 
this.fieldLayout ] );

-- 
To view, visit https://gerrit.wikimedia.org/r/338039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2f3617fb4e9a80272e559b35c947052c0d8e534b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: ve.ui.MWAdvancedSettingsPage: Actually display help for sett...

2017-02-15 Thread Code Review 
Bartosz Dziewoński has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/338039 )

Change subject: ve.ui.MWAdvancedSettingsPage: Actually display help for 
settings about language variants
..

ve.ui.MWAdvancedSettingsPage: Actually display help for settings about language 
variants

Follow-up to 712ea472d34371176bb08b79c723374fa6800dd6.

Change-Id: I2f3617fb4e9a80272e559b35c947052c0d8e534b
---
M modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/39/338039/1

diff --git a/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js 
b/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
index e1c4922..0e13cd4 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWAdvancedSettingsPage.js
@@ -118,7 +118,8 @@
new OO.ui.CheckboxInputWidget(),
{
align: 'inline',
-   label: this.label
+   label: this.label,
+   help: this.help
}
);
advancedSettingsPage.advancedSettingsFieldset.addItems( [ 
this.fieldLayout ] );

-- 
To view, visit https://gerrit.wikimedia.org/r/338039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2f3617fb4e9a80272e559b35c947052c0d8e534b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits