[MediaWiki-commits] [Gerrit] mediawiki...WebChat[master]: Allow any protocol to use Mibbit chat

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/374565 )

Change subject: Allow any protocol to use Mibbit chat
..


Allow any protocol to use Mibbit chat

Currently it forces HTTP, but many wikis are now running HTTPS if not
HTTPS-only so it should be allowed to be loaded from any protocol.

Change-Id: I76b14534e7bbaa65e8694d94fb218f970aee9a9c
---
M WebChat.php
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Hashar: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/WebChat.php b/WebChat.php
index 0604601..e1a80b2 100644
--- a/WebChat.php
+++ b/WebChat.php
@@ -45,7 +45,7 @@
 $wgWebChatClient  = '';
 $wgWebChatClients = [
'Mibbit' => [
-   'url' => 'http://embed.mibbit.com/index.html',
+   'url' => '//embed.mibbit.com/index.html',
'parameters' => [
'noServerMotd' => 'true',
'server'  => '$$$server$$$',
@@ -64,6 +64,6 @@
 
 // Default permissions.
 $wgAvailableRights[] = 'webchat';
-$wgGroupPermissions['*']['webchat'] = false;
+$wgGroupPermissions['*']['webchat'] = false;
 $wgGroupPermissions['user' ]['webchat'] = true;
 $wgGroupPermissions['sysop']['webchat'] = true;

-- 
To view, visit https://gerrit.wikimedia.org/r/374565
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I76b14534e7bbaa65e8694d94fb218f970aee9a9c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WebChat
Gerrit-Branch: master
Gerrit-Owner: Reception123 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Legoktm 
Gerrit-Reviewer: Siebrand 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...WebChat[master]: Allow any protocol to use Mibbit chat

[Reception123 (Code Review)]

Reception123 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/374565 )

Change subject: Allow any protocol to use Mibbit chat
..

Allow any protocol to use Mibbit chat

Currently it forces HTTP, but many wikis are now running HTTPS if not
HTTPS-only so it should be allowed to be loaded from any protocol.

Change-Id: I76b14534e7bbaa65e8694d94fb218f970aee9a9c
---
M WebChat.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WebChat 
refs/changes/65/374565/1

diff --git a/WebChat.php b/WebChat.php
index 0604601..e1a80b2 100644
--- a/WebChat.php
+++ b/WebChat.php
@@ -45,7 +45,7 @@
 $wgWebChatClient  = '';
 $wgWebChatClients = [
'Mibbit' => [
-   'url' => 'http://embed.mibbit.com/index.html',
+   'url' => '//embed.mibbit.com/index.html',
'parameters' => [
'noServerMotd' => 'true',
'server'  => '$$$server$$$',
@@ -64,6 +64,6 @@
 
 // Default permissions.
 $wgAvailableRights[] = 'webchat';
-$wgGroupPermissions['*']['webchat'] = false;
+$wgGroupPermissions['*']['webchat'] = false;
 $wgGroupPermissions['user' ]['webchat'] = true;
 $wgGroupPermissions['sysop']['webchat'] = true;

-- 
To view, visit https://gerrit.wikimedia.org/r/374565
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I76b14534e7bbaa65e8694d94fb218f970aee9a9c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WebChat
Gerrit-Branch: master
Gerrit-Owner: Reception123 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits