[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Avoid deprecated LBFactory::singleton() in tests
jenkins-bot has submitted this change and it was merged. Change subject: Avoid deprecated LBFactory::singleton() in tests .. Avoid deprecated LBFactory::singleton() in tests Change-Id: Ic6dadd663826cfe95593c9b85ee06e22ac5ffbfb --- M client/includes/Hooks/ChangesListSpecialPageHookHandlers.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Aude: Looks good to me, approved Legoktm: Looks good to me, approved jenkins-bot: Verified diff --git a/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php b/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php index ab0a78d..776b1fc 100644 --- a/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php +++ b/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php @@ -6,7 +6,7 @@ use FormOptions; use IContextSource; use LoadBalancer; -use LBFactory; +use MediaWiki\MediaWikiServices; use RequestContext; use User; use WebRequest; @@ -90,7 +90,7 @@ return new self( $context->getRequest(), $context->getUser(), - LBFactory::singleton()->getMainLB(), + MediaWikiServices::getInstance()->getDBLoadBalancer(), $specialPageName, $settings->getSetting( 'showExternalRecentChanges' ) ); -- To view, visit https://gerrit.wikimedia.org/r/310726 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6dadd663826cfe95593c9b85ee06e22ac5ffbfb Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aaron Schulz Gerrit-Reviewer: Addshore Gerrit-Reviewer: Aude Gerrit-Reviewer: Hoo man Gerrit-Reviewer: Legoktm Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Avoid deprecated LBFactory::singleton() in tests
Aaron Schulz has uploaded a new change for review. https://gerrit.wikimedia.org/r/310726 Change subject: Avoid deprecated LBFactory::singleton() in tests .. Avoid deprecated LBFactory::singleton() in tests Change-Id: Ic6dadd663826cfe95593c9b85ee06e22ac5ffbfb --- M client/includes/Hooks/ChangesListSpecialPageHookHandlers.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/26/310726/1 diff --git a/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php b/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php index ab0a78d..97f7df6 100644 --- a/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php +++ b/client/includes/Hooks/ChangesListSpecialPageHookHandlers.php @@ -13,6 +13,7 @@ use Wikibase\Client\RecentChanges\RecentChangeFactory; use Wikibase\Client\WikibaseClient; use Wikimedia\Assert\Assert; +use \MediaWiki\MediaWikiServices; /** * @since 0.5 @@ -90,7 +91,7 @@ return new self( $context->getRequest(), $context->getUser(), - LBFactory::singleton()->getMainLB(), + MediaWikiServices::getInstance()->getDBLoadBalancer(); $specialPageName, $settings->getSetting( 'showExternalRecentChanges' ) ); -- To view, visit https://gerrit.wikimedia.org/r/310726 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic6dadd663826cfe95593c9b85ee06e22ac5ffbfb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aaron Schulz ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
