[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix: focus is not in value field after selecting a property

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/383362 )

Change subject: Fix: focus is not in value field after selecting a property
..


Fix: focus is not in value field after selecting a property

This fixes the issue for me, but it looks very hacky.
Maybe someone figures out the root cause and can provide better fix.

Bug: T177485
Change-Id: I3afa7857373894e88ddd99871a0d64ed08c6d143
---
M view/resources/jquery/wikibase/snakview/snakview.js
1 file changed, 2 insertions(+), 6 deletions(-)

Approvals:
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, approved



diff --git a/view/resources/jquery/wikibase/snakview/snakview.js 
b/view/resources/jquery/wikibase/snakview/snakview.js
index 961d666..a324e00 100644
--- a/view/resources/jquery/wikibase/snakview/snakview.js
+++ b/view/resources/jquery/wikibase/snakview/snakview.js
@@ -268,12 +268,8 @@
// the property might not be valid anymore aborting the 
rendering of the value
// view.
if ( this._variation ) {
-   $( this._variation ).one( 'afterdraw', function 
() {
-   // If the variant wasn't actually 
updated 'afterdraw' will run synchronously,
-   // but we need to break out of the 
stack here.
-   setTimeout( function () {
-   self._variation.focus();
-   }, 0 );
+   $( this._variation ).one( 'afterstartediting', 
function () {
+   self._variation.focus();
} );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/383362
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3afa7857373894e88ddd99871a0d64ed08c6d143
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix: focus is not in value field after selecting a property

[Jonas Kress (WMDE) (Code Review)]

Jonas Kress (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/383362 )

Change subject: Fix: focus is not in value field after selecting a property
..

Fix: focus is not in value field after selecting a property

This fixes the issue for me, but it looks very hacky.
Maybe someone figures out the root cause and can provide better fix.

Bug: T177485
Change-Id: I3afa7857373894e88ddd99871a0d64ed08c6d143
---
M view/resources/jquery/wikibase/snakview/snakview.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/62/383362/1

diff --git a/view/resources/jquery/wikibase/snakview/snakview.js 
b/view/resources/jquery/wikibase/snakview/snakview.js
index 961d666..248c574 100644
--- a/view/resources/jquery/wikibase/snakview/snakview.js
+++ b/view/resources/jquery/wikibase/snakview/snakview.js
@@ -273,7 +273,7 @@
// but we need to break out of the 
stack here.
setTimeout( function () {
self._variation.focus();
-   }, 0 );
+   }, 10 );
} );
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/383362
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3afa7857373894e88ddd99871a0d64ed08c6d143
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits