[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Reduce visible jumping when enabling edit mode

2017-01-09 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/330146 )

Change subject: Reduce visible jumping when enabling edit mode
..


Reduce visible jumping when enabling edit mode

This will possibly waste a tiny little bit of space (I believe less
than 1 pixel per statement), but greatly reduces jumping. Try with
a complex statement that has qualifiers!

Change-Id: Ifd55bf5d740bbfdf22ecd43787e056c0dce8ef5c
---
M view/resources/wikibase/wikibase.css
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jonas Kress (WMDE): Looks good to me, approved
  Aleksey Bekh-Ivanov (WMDE): Checked; Looks good to me, but someone else must 
approve
  jenkins-bot: Verified



diff --git a/view/resources/wikibase/wikibase.css 
b/view/resources/wikibase/wikibase.css
index 4cf26f5..e681e81 100644
--- a/view/resources/wikibase/wikibase.css
+++ b/view/resources/wikibase/wikibase.css
@@ -231,7 +231,7 @@
 
 div.wikibase-snakview .wikibase-snakview-value-container {
margin-left: 16px;
-   min-height: .8em; /* reduces jumping when clicking edit */
+   min-height: 1.6em; /* reduces jumping when clicking edit */
 }
 
 div .wikibase-snakview-value span.error.wb-format-error {

-- 
To view, visit https://gerrit.wikimedia.org/r/330146
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ifd55bf5d740bbfdf22ecd43787e056c0dce8ef5c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) 
Gerrit-Reviewer: Aude 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: WMDE-leszek 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Reduce visible jumping when enabling edit mode

2017-01-02 Thread WMDE 
Thiemo Mättig (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/330146 )

Change subject: Reduce visible jumping when enabling edit mode
..

Reduce visible jumping when enabling edit mode

This will possibly waste a tiny little bit of space (I believe less
than 1 pixel per statement), but greatly reduces jumping. Try with
a complex statement that has qualifiers!

Change-Id: Ifd55bf5d740bbfdf22ecd43787e056c0dce8ef5c
---
M view/resources/wikibase/wikibase.css
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/46/330146/1

diff --git a/view/resources/wikibase/wikibase.css 
b/view/resources/wikibase/wikibase.css
index 4cf26f5..e681e81 100644
--- a/view/resources/wikibase/wikibase.css
+++ b/view/resources/wikibase/wikibase.css
@@ -231,7 +231,7 @@
 
 div.wikibase-snakview .wikibase-snakview-value-container {
margin-left: 16px;
-   min-height: .8em; /* reduces jumping when clicking edit */
+   min-height: 1.6em; /* reduces jumping when clicking edit */
 }
 
 div .wikibase-snakview-value span.error.wb-format-error {

-- 
To view, visit https://gerrit.wikimedia.org/r/330146
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifd55bf5d740bbfdf22ecd43787e056c0dce8ef5c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits