[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Removed TODO

2017-01-19 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/331101 )

Change subject: Removed TODO
..


Removed TODO

Change-Id: I42488d6470ac4aa7e350c294c20101eec122215f
---
M repo/includes/Disposable.php
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Daniel Kinzler: Looks good to me, approved
  Aleksey Bekh-Ivanov (WMDE): Looks good to me, but someone else must approve
  Addshore: Looks good to me, approved
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, but someone else must approve



diff --git a/repo/includes/Disposable.php b/repo/includes/Disposable.php
index 4639f45..68ba26f 100644
--- a/repo/includes/Disposable.php
+++ b/repo/includes/Disposable.php
@@ -7,8 +7,6 @@
  *
  * @license GPL-2.0+
  * @author Daniel Kinzler
- *
- * @todo make this reusable outside Wikibase
  */
 interface Disposable {
 

-- 
To view, visit https://gerrit.wikimedia.org/r/331101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42488d6470ac4aa7e350c294c20101eec122215f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) 
Gerrit-Reviewer: Daniel Kinzler 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Removed TODO

2017-01-06 Thread Jeroen De Dauw (Code Review) 
Jeroen De Dauw has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/331101 )

Change subject: Removed TODO
..

Removed TODO

Change-Id: I42488d6470ac4aa7e350c294c20101eec122215f
---
M repo/includes/Disposable.php
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/01/331101/1

diff --git a/repo/includes/Disposable.php b/repo/includes/Disposable.php
index 4639f45..68ba26f 100644
--- a/repo/includes/Disposable.php
+++ b/repo/includes/Disposable.php
@@ -7,8 +7,6 @@
  *
  * @license GPL-2.0+
  * @author Daniel Kinzler
- *
- * @todo make this reusable outside Wikibase
  */
 interface Disposable {
 

-- 
To view, visit https://gerrit.wikimedia.org/r/331101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I42488d6470ac4aa7e350c294c20101eec122215f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits