[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Tests for serialize and unserialize of compact diff in Entit...

2017-12-04 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/394764 )

Change subject: Tests for serialize and unserialize of compact diff in 
EntityChange
..


Tests for serialize and unserialize of compact diff in EntityChange

These are regression tests of Idac3c907944eee1b748e9d6c72de9111acccb6d2 fix

Bug: T181760
Change-Id: I3d837f2e09ea2c8f4a8d61d95075000c409cc0a0
---
M lib/tests/phpunit/Changes/EntityChangeTest.php
1 file changed, 29 insertions(+), 0 deletions(-)

Approvals:
  Ladsgroup: Looks good to me, approved
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, approved



diff --git a/lib/tests/phpunit/Changes/EntityChangeTest.php 
b/lib/tests/phpunit/Changes/EntityChangeTest.php
index 7b98075..027a149 100644
--- a/lib/tests/phpunit/Changes/EntityChangeTest.php
+++ b/lib/tests/phpunit/Changes/EntityChangeTest.php
@@ -8,6 +8,7 @@
 use Revision;
 use RuntimeException;
 use stdClass;
+use Wikibase\Lib\Changes\EntityDiffChangedAspects;
 use Wikimedia\TestingAccessWrapper;
 use User;
 use Wikibase\DataModel\Entity\EntityId;
@@ -352,6 +353,34 @@
$this->assertEquals( $info, $change->getInfo() );
}
 
+   public function testSerializeAndUnserializeInfoCompactDiff() {
+   $aspects = new EntityDiffChangedAspects(
+   [ 'fa' ],
+   [],
+   [],
+   [],
+   false
+   );
+   $info = [ 'compactDiff' => $aspects->serialize() ];
+   $change = new EntityChange( [ 'info' => $info ] );
+   $change->setField( 'info', $change->getSerializedInfo() );
+   $this->assertEquals( [ 'compactDiff' => $aspects ], 
$change->getInfo() );
+   }
+
+   public function 
testSerializeAndUnserializeInfoCompactDiffBadSerialization() {
+   $aspects = new EntityDiffChangedAspects(
+   [ 'de' ],
+   [],
+   [],
+   [],
+   false
+   );
+   $info = [ 'compactDiff' => $aspects->toArray() ];
+   $change = new EntityChange( [ 'info' => $info ] );
+   $change->setField( 'info', $change->getSerializedInfo() );
+   $this->assertEquals( $info, $change->getInfo() );
+   }
+
public function testGivenStatement_serializeInfoSerializesStatement() {
$statement = new Statement( new PropertyNoValueSnak( 1 ) );
$info = [ 'diff' => new DiffOpAdd( $statement ) ];

-- 
To view, visit https://gerrit.wikimedia.org/r/394764
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3d837f2e09ea2c8f4a8d61d95075000c409cc0a0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 
Gerrit-Reviewer: Addshore 
Gerrit-Reviewer: Ladsgroup 
Gerrit-Reviewer: Thiemo Mättig (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Tests for serialize and unserialize of compact diff in Entit...

2017-12-02 Thread Ladsgroup (Code Review) 
Ladsgroup has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394764 )

Change subject: Tests for serialize and unserialize of compact diff in 
EntityChange
..

Tests for serialize and unserialize of compact diff in EntityChange

These are regression tests of Idac3c907944eee1b748e9d6c72de9111acccb6d2 fix

Bug: T181760
Change-Id: I3d837f2e09ea2c8f4a8d61d95075000c409cc0a0
---
M lib/tests/phpunit/Changes/EntityChangeTest.php
1 file changed, 29 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/64/394764/1

diff --git a/lib/tests/phpunit/Changes/EntityChangeTest.php 
b/lib/tests/phpunit/Changes/EntityChangeTest.php
index 7b98075..07ba3fa 100644
--- a/lib/tests/phpunit/Changes/EntityChangeTest.php
+++ b/lib/tests/phpunit/Changes/EntityChangeTest.php
@@ -8,6 +8,7 @@
 use Revision;
 use RuntimeException;
 use stdClass;
+use Wikibase\Lib\Changes\EntityDiffChangedAspects;
 use Wikimedia\TestingAccessWrapper;
 use User;
 use Wikibase\DataModel\Entity\EntityId;
@@ -352,6 +353,34 @@
$this->assertEquals( $info, $change->getInfo() );
}
 
+   public function testSerializeAndUnserializeInfoCompactDiff() {
+   $aspects = new EntityDiffChangedAspects(
+   [ 'fa' ],
+   [],
+   [],
+   [],
+   false
+   );
+   $info = [ 'compactDiff' => $aspects->serialize() ];
+   $change = new EntityChange( [ 'info' => $info ] );
+   $change->setField( 'info', $change->getSerializedInfo() );
+   $this->assertEquals( $info, $change->getInfo() );
+   }
+
+   public function 
testSerializeAndUnserializeInfoCompactDiffBadSerialization() {
+   $aspects = new EntityDiffChangedAspects(
+   [ 'de' ],
+   [],
+   [],
+   [],
+   false
+   );
+   $info = [ 'compactDiff' => $aspects->toArray() ];
+   $change = new EntityChange( [ 'info' => $info ] );
+   $change->setField( 'info', $change->getSerializedInfo() );
+   $this->assertEquals( [], $change->getInfo() );
+   }
+
public function testGivenStatement_serializeInfoSerializesStatement() {
$statement = new Statement( new PropertyNoValueSnak( 1 ) );
$info = [ 'diff' => new DiffOpAdd( $statement ) ];

-- 
To view, visit https://gerrit.wikimedia.org/r/394764
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d837f2e09ea2c8f4a8d61d95075000c409cc0a0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits