[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add labels to fields of the form representation widget
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/369410 )
Change subject: Add labels to fields of the form representation widget
..
Add labels to fields of the form representation widget
Bug: T172190
Change-Id: If15e532ba1dca5d8aa23956e017351eafc166ec5
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M resources/form-representation-widget.less
M src/View/FormsView.php
5 files changed, 20 insertions(+), 3 deletions(-)
Approvals:
Aleksey Bekh-Ivanov (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 84253d2..8d7e642 100644
--- a/extension.json
+++ b/extension.json
@@ -158,7 +158,9 @@
],
"messages":[
"wikibase-add",
- "wikibase-remove"
+ "wikibase-remove",
+ "wikibase-form-field-representation-label",
+ "wikibase-form-field-language-label"
]
},
"wikibase.lexeme.widgets.GlossWidget": {
diff --git a/i18n/en.json b/i18n/en.json
index 20afaa1..34ff1c6 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -18,6 +18,8 @@
"wikibase-lexeme-statementsection-statements-about-sense": "Statements
about $1",
"wikibase-lexeme-view-senses": "Senses",
"wikibase-lexeme-gloss-empty": "No gloss defined",
+ "wikibase-form-field-representation-label": "Representation",
+ "wikibase-form-field-language-label": "Language",
"wikibase-gloss-field-language-label": "Language",
"wikibase-gloss-field-gloss-label": "Gloss",
"wikibase-lexeme-summary-wbeditentity-update": "Changed a lexeme",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index e203a55..79cb77e 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -23,6 +23,8 @@
"wikibase-lexeme-statementsection-statements-about-sense": "Heading for
the list of statements giving specific information about the currently viewed
Sense of a Lexeme.\n\nParameters:\n* $1 - Sense ID.\n{{Identical|Statements}}",
"wikibase-lexeme-view-senses": "Subheading for the senses section on a
lexeme page.\n{{Identical|Sense}}",
"wikibase-lexeme-gloss-empty": "Placeholder message displayed instead
of the gloss of the sense in case the gloss in the display language has not
been specified yet.",
+ "wikibase-form-field-representation-label": "Label of the field to
input the representation of the form",
+ "wikibase-form-field-language-label": "Label of the field to input the
language code of the variant of the form representation",
"wikibase-gloss-field-language-label": "Label of the field to input the
language code of the language the gloss of the sense is defined in",
"wikibase-gloss-field-gloss-label": "Label of the field to input the
gloss of the sense",
"wikibase-lexeme-summary-wbeditentity-update": "Auto-generated edit
summary when editing a lexeme",
diff --git a/resources/form-representation-widget.less
b/resources/form-representation-widget.less
index e8e8d8f..1fb476b 100644
--- a/resources/form-representation-widget.less
+++ b/resources/form-representation-widget.less
@@ -60,9 +60,11 @@
justify-content: space-around;
border-left: 6px solid #dae8fc;
padding: 0 18px 0 9px;
- margin: calc(0.785em - 0.143em) 0;
+ margin: .5em 0;
+ }
- height: 3.150em;
+ &_representation-value-label {
+ font-size: .9em;
}
&_representation-value-input {
@@ -77,6 +79,9 @@
width: auto;
}
+ &_representation-language-label {
+ font-size: .9em;
+ }
&_representation-language-input {
resize: horizontal;
min-width: 7.5em;
diff --git a/src/View/FormsView.php b/src/View/FormsView.php
index 34af976..cc6073e 100644
--- a/src/View/FormsView.php
+++ b/src/View/FormsView.php
@@ -171,8 +171,14 @@
+
+
{{'wikibase-form-field-representation-label'|message}}
+
+
+
{{'wikibase-form-field-language-label'|message}}
+
https://gerrit.wikimedia.org/r/369410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If15e532ba1dca5d8aa23956e017351eafc166ec5
Gerrit-PatchSet: 4
Gerrit-Project:
[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add labels to fields of the form representation widget
WMDE-leszek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369410 )
Change subject: Add labels to fields of the form representation widget
..
Add labels to fields of the form representation widget
Bug: T172190
Change-Id: If15e532ba1dca5d8aa23956e017351eafc166ec5
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M resources/form-representation-widget.less
M src/View/FormsView.php
5 files changed, 17 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseLexeme
refs/changes/10/369410/1
diff --git a/extension.json b/extension.json
index 84253d2..8d7e642 100644
--- a/extension.json
+++ b/extension.json
@@ -158,7 +158,9 @@
],
"messages":[
"wikibase-add",
- "wikibase-remove"
+ "wikibase-remove",
+ "wikibase-form-field-representation-label",
+ "wikibase-form-field-language-label"
]
},
"wikibase.lexeme.widgets.GlossWidget": {
diff --git a/i18n/en.json b/i18n/en.json
index 20afaa1..34ff1c6 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -18,6 +18,8 @@
"wikibase-lexeme-statementsection-statements-about-sense": "Statements
about $1",
"wikibase-lexeme-view-senses": "Senses",
"wikibase-lexeme-gloss-empty": "No gloss defined",
+ "wikibase-form-field-representation-label": "Representation",
+ "wikibase-form-field-language-label": "Language",
"wikibase-gloss-field-language-label": "Language",
"wikibase-gloss-field-gloss-label": "Gloss",
"wikibase-lexeme-summary-wbeditentity-update": "Changed a lexeme",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index e203a55..79cb77e 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -23,6 +23,8 @@
"wikibase-lexeme-statementsection-statements-about-sense": "Heading for
the list of statements giving specific information about the currently viewed
Sense of a Lexeme.\n\nParameters:\n* $1 - Sense ID.\n{{Identical|Statements}}",
"wikibase-lexeme-view-senses": "Subheading for the senses section on a
lexeme page.\n{{Identical|Sense}}",
"wikibase-lexeme-gloss-empty": "Placeholder message displayed instead
of the gloss of the sense in case the gloss in the display language has not
been specified yet.",
+ "wikibase-form-field-representation-label": "Label of the field to
input the representation of the form",
+ "wikibase-form-field-language-label": "Label of the field to input the
language code of the variant of the form representation",
"wikibase-gloss-field-language-label": "Label of the field to input the
language code of the language the gloss of the sense is defined in",
"wikibase-gloss-field-gloss-label": "Label of the field to input the
gloss of the sense",
"wikibase-lexeme-summary-wbeditentity-update": "Auto-generated edit
summary when editing a lexeme",
diff --git a/resources/form-representation-widget.less
b/resources/form-representation-widget.less
index e8e8d8f..0ca2dbd 100644
--- a/resources/form-representation-widget.less
+++ b/resources/form-representation-widget.less
@@ -60,9 +60,13 @@
justify-content: space-around;
border-left: 6px solid #dae8fc;
padding: 0 18px 0 9px;
- margin: calc(0.785em - 0.143em) 0;
+ margin: 1.5em 0;
height: 3.150em;
+ }
+
+ &_representation-value-label {
+ font-size: .9em;
}
&_representation-value-input {
@@ -77,6 +81,9 @@
width: auto;
}
+ &_representation-language-label {
+ font-size: .9em;
+ }
&_representation-language-input {
resize: horizontal;
min-width: 7.5em;
diff --git a/src/View/FormsView.php b/src/View/FormsView.php
index 34af976..75872fb 100644
--- a/src/View/FormsView.php
+++ b/src/View/FormsView.php
@@ -171,8 +171,10 @@
+ {{'wikibase-form-field-representation-label'|message}}
+ {{'wikibase-form-field-language-label'|message}}
https://gerrit.wikimedia.org/r/369410
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If15e532ba1dca5d8aa23956e017351eafc166ec5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek
___
MediaWiki-commits mailing list
