[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Change Form's statements header text
jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/364768 )
Change subject: Change Form's statements header text
..
Change Form's statements header text
Bug: T170388
Depends-On: Ic522ad291c299a4c60993c304f340a10f625fb9b
Change-Id: I76f6152c2544af75cf716d9342c9e5f44d2639a4
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M resources/jquery.wikibase.lexemeformview.js
M src/View/LexemeFormsView.php
M src/View/LexemeViewFactory.php
M tests/phpunit/mediawiki/View/LexemeFormsViewTest.php
7 files changed, 48 insertions(+), 17 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 3b6b2ab..ac879ba 100644
--- a/extension.json
+++ b/extension.json
@@ -84,7 +84,7 @@
"messages": [
"wikibase-lexeme-empty-form-representation",
"wikibase-lexeme-enter-form-representation",
- "wikibase-statementsection-statements"
+
"wikibase-lexeme-statementsection-statements-about-form"
]
},
"jquery.wikibase.grammaticalfeatureview": {
diff --git a/i18n/en.json b/i18n/en.json
index 7e9fce5..3d49f8a 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -11,6 +11,7 @@
"wikibase-newlexeme-lexicalcategory": "Lexical category",
"wikibase-newlexeme-language": "Language of lexeme",
"wikibase-lexeme-view-language-lexical-category": "$1 in $2",
+ "wikibase-lexeme-statementsection-statements-about-form": "Statements
about $1",
"wikibase-lexeme-view-forms": "Forms",
"wikibase-lexeme-enter-form-representation": "Enter new form
representation",
"wikibase-lexeme-empty-form-representation": "No form representation
defined",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 22b35bc..ed23ba0 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -16,6 +16,7 @@
"wikibase-newlexeme-lexicalcategory": "Name for \"lexical category\"",
"wikibase-newlexeme-language": "Label for field in the lexeme creation
form.",
"wikibase-lexeme-view-language-lexical-category": "Description when
both lexical category and language are present\n{{Identical|In}}",
+ "wikibase-lexeme-statementsection-statements-about-form": "Heading for
the list of statements giving specific information about the currently viewed
Form of a Lexeme.\n\nParameters:\n* $1 - Form ID.\n{{Identical|Statements}}",
"wikibase-lexeme-view-forms": "Subheading for the forms section on a
lexeme page.\n{{Identical|Form}}",
"wikibase-lexeme-enter-form-representation": "Placeholder for the
lexeme form representation input field.",
"wikibase-lexeme-empty-form-representation": "Placeholder message
displayed instead of the lexeme form representation in case no representation
has been specified yet.",
diff --git a/resources/jquery.wikibase.lexemeformview.js
b/resources/jquery.wikibase.lexemeformview.js
index b057626..c8ad5b7 100644
--- a/resources/jquery.wikibase.lexemeformview.js
+++ b/resources/jquery.wikibase.lexemeformview.js
@@ -51,10 +51,11 @@
function () {
var $container = $( '' );
this.deferredFormWithId.promise().then(
function ( form ) {
+ var messageKey =
'wikibase-lexeme-statementsection-statements-about-form';
var $header = $( ''
).applyTemplate(
'wb-section-heading',
[
- mw.message(
'wikibase-statementsection-statements' ).escaped(),
+ mw.message(
messageKey, form.getId() ).escaped(),
'',
'wikibase-statements'
]
diff --git a/src/View/LexemeFormsView.php b/src/View/LexemeFormsView.php
index 20d119b..1431eac 100644
--- a/src/View/LexemeFormsView.php
+++ b/src/View/LexemeFormsView.php
@@ -8,7 +8,7 @@
use Wikibase\Lexeme\View\Template\LexemeTemplateFactory;
use Wikibase\Lib\EntityIdHtmlLinkFormatter;
use Wikibase\View\LocalizedTextProvider;
-use Wikibase\View\StatementSectionsView;
+use Wikibase\View\StatementGroupListView;
use WMDE\VueJsTemplating\Templating;
/**
@@ -33,9 +33,9 @@
private $entityIdHtmlFormatter;
/**
-* @var StatementSectionsView
+* @var StatementGroupListView
*/
- private $statementSectionView;
+
[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Change Form's statements header text
Aleksey Bekh-Ivanov (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364768 )
Change subject: Change Form's statements header text
..
Change Form's statements header text
Bug: T170388
Change-Id: I76f6152c2544af75cf716d9342c9e5f44d2639a4
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M resources/jquery.wikibase.lexemeformview.js
M src/View/LexemeFormsView.php
M src/View/LexemeViewFactory.php
6 files changed, 43 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseLexeme
refs/changes/68/364768/1
diff --git a/extension.json b/extension.json
index 3b6b2ab..cc22539 100644
--- a/extension.json
+++ b/extension.json
@@ -84,7 +84,7 @@
"messages": [
"wikibase-lexeme-empty-form-representation",
"wikibase-lexeme-enter-form-representation",
- "wikibase-statementsection-statements"
+
"wikibase-lexeme-statementsection-statements-for"
]
},
"jquery.wikibase.grammaticalfeatureview": {
diff --git a/i18n/en.json b/i18n/en.json
index 6480be1..4abf84c 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -11,6 +11,7 @@
"wikibase-newlexeme-lexicalcategory": "Lexical category",
"wikibase-newlexeme-language": "Language of lexeme",
"wikibase-lexeme-view-language-lexical-category": "$1 in $2",
+ "wikibase-lexeme-statementsection-statements-for": "Statements for $1",
"wikibase-lexeme-view-forms": "Morphology",
"wikibase-lexeme-enter-form-representation": "Enter new form
representation",
"wikibase-lexeme-empty-form-representation": "No form representation
defined",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 0d013fe..dfdb6c9 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -16,6 +16,7 @@
"wikibase-newlexeme-lexicalcategory": "Name for \"lexical category\"",
"wikibase-newlexeme-language": "Label for field in the lexeme creation
form.",
"wikibase-lexeme-view-language-lexical-category": "Description when
both lexical category and language are present\n{{Identical|In}}",
+ "wikibase-lexeme-statementsection-statements-for": "Heading for the
list of statements giving specific information about the currently viewed Form
or Sense of a Lexeme.\n{{Identical|Statements}}",
"wikibase-lexeme-view-forms": "Subheading for the morphology (forms)
section on a lexeme page.\n{{Identical|Form}}",
"wikibase-lexeme-enter-form-representation": "Placeholder for the
lexeme form representation input field.",
"wikibase-lexeme-empty-form-representation": "Placeholder message
displayed instead of the lexeme form representation in case no representation
has been specified yet.",
diff --git a/resources/jquery.wikibase.lexemeformview.js
b/resources/jquery.wikibase.lexemeformview.js
index b057626..6040a4f 100644
--- a/resources/jquery.wikibase.lexemeformview.js
+++ b/resources/jquery.wikibase.lexemeformview.js
@@ -51,10 +51,11 @@
function () {
var $container = $( '' );
this.deferredFormWithId.promise().then(
function ( form ) {
+ var messageKey =
'wikibase-lexeme-statementsection-statements-for';
var $header = $( ''
).applyTemplate(
'wb-section-heading',
[
- mw.message(
'wikibase-statementsection-statements' ).escaped(),
+ mw.message(
messageKey, form.getId() ).escaped(),
'',
'wikibase-statements'
]
diff --git a/src/View/LexemeFormsView.php b/src/View/LexemeFormsView.php
index 20d119b..8794b8f 100644
--- a/src/View/LexemeFormsView.php
+++ b/src/View/LexemeFormsView.php
@@ -8,7 +8,7 @@
use Wikibase\Lexeme\View\Template\LexemeTemplateFactory;
use Wikibase\Lib\EntityIdHtmlLinkFormatter;
use Wikibase\View\LocalizedTextProvider;
-use Wikibase\View\StatementSectionsView;
+use Wikibase\View\StatementGroupListView;
use WMDE\VueJsTemplating\Templating;
/**
@@ -33,9 +33,9 @@
private $entityIdHtmlFormatter;
/**
-* @var StatementSectionsView
+* @var StatementGroupListView
*/
- private $statementSectionView;
+ private $statementGroupListView;
/**
* @var string
@@ -46,12 +46,12 @@
