[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Config: Only update restbase if the revision content changed.

[Mobrovac (Code Review)]

Mobrovac has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/362453 )

Change subject: Config: Only update restbase if the revision content changed.
..


Config: Only update restbase if the revision content changed.

Change-Id: I8eab744a386200b12b1952f6d7df3faf92aad870
PR: https://github.com/wikimedia/change-propagation/pull/195
Depends-On: Ibd32ceb99bc650e3927c1bde28c05d0145fc205b
---
M scap/templates/config.yaml.j2
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Mobrovac: Verified; Looks good to me, approved



diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index aad95ab..01216e9 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -192,6 +192,8 @@
   status:
 - '5xx'
 - 404 # Sometimes occasional 404s happen because of the 
mysql replication lag, so retry
+match:
+  rev_content_changed: true
 match_not:
   - meta:
   domain: /\.wikidata\.org$/
@@ -593,6 +595,7 @@
   page_namespace: 0
   # It's impossible to modify a comment in wikidata while 
editing the entity.
   comment: '/wbeditentity|wbsetdescription|undo/'
+  rev_content_changed: true
 exec:
   method: post
   uri: '/sys/links/wikidata_descriptions'

-- 
To view, visit https://gerrit.wikimedia.org/r/362453
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8eab744a386200b12b1952f6d7df3faf92aad870
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/services/change-propagation/deploy
Gerrit-Branch: master
Gerrit-Owner: Ppchelko 
Gerrit-Reviewer: GWicke 
Gerrit-Reviewer: Mobrovac 
Gerrit-Reviewer: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Config: Only update restbase if the revision content changed.

[Ppchelko (Code Review)]

Ppchelko has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/362453 )

Change subject: Config: Only update restbase if the revision content changed.
..

Config: Only update restbase if the revision content changed.

DO NOT MERGE! WAITING FOR THE TRAIN TO DEPLOY!

Change-Id: I8eab744a386200b12b1952f6d7df3faf92aad870
PR: https://github.com/wikimedia/change-propagation/pull/195
Depends-On: Ibd32ceb99bc650e3927c1bde28c05d0145fc205b
---
M scap/templates/config.yaml.j2
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/services/change-propagation/deploy 
refs/changes/53/362453/1

diff --git a/scap/templates/config.yaml.j2 b/scap/templates/config.yaml.j2
index 7ffa612..910e83b 100644
--- a/scap/templates/config.yaml.j2
+++ b/scap/templates/config.yaml.j2
@@ -184,6 +184,8 @@
   status:
 - '5xx'
 - 404 # Sometimes occasional 404s happen because of the 
mysql replication lag, so retry
+match:
+  rev_content_changed: true
 match_not:
   - meta:
   domain: /\.wikidata\.org$/
@@ -579,6 +581,7 @@
   page_namespace: 0
   # It's impossible to modify a comment in wikidata while 
editing the entity.
   comment: '/wbeditentity|wbsetdescription|undo/'
+  rev_content_changed: true
 exec:
   method: post
   uri: '/sys/links/wikidata_descriptions'

-- 
To view, visit https://gerrit.wikimedia.org/r/362453
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8eab744a386200b12b1952f6d7df3faf92aad870
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/change-propagation/deploy
Gerrit-Branch: master
Gerrit-Owner: Ppchelko 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits