[MediaWiki-commits] [Gerrit] mediawiki...eventstreams[master]: Fix lint complaints, update to version 0.0.2, change default...

2017-02-16 Thread Ottomata (Code Review) 
Ottomata has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/338283 )

Change subject: Fix lint complaints, update to version 0.0.2, change default 
port to 8092
..


Fix lint complaints, update to version 0.0.2, change default port to 8092

Change-Id: I66e0ba0c6afe1e61d1aa59dd60c4d993e0714a66
---
M config.dev.yaml
M config.prod.yaml
M lib/eventstreams-util.js
M routes/v2.js
4 files changed, 4 insertions(+), 6 deletions(-)

Approvals:
  Ottomata: Verified; Looks good to me, approved



diff --git a/config.dev.yaml b/config.dev.yaml
index 24253e9..9c3c1e0 100644
--- a/config.dev.yaml
+++ b/config.dev.yaml
@@ -32,7 +32,7 @@
 # version: ^0.4.0
 # per-service config
 conf:
-  port: 8000
+  port: 8092
   # interface: localhost # uncomment to only listen on localhost
   # more per-service config settings
   # the location of the spec, defaults to spec.yaml if not specified
diff --git a/config.prod.yaml b/config.prod.yaml
index d5fcdbb..3d24fdb 100644
--- a/config.prod.yaml
+++ b/config.prod.yaml
@@ -30,7 +30,7 @@
 # version: ^0.4.0
 # per-service config
 conf:
-  port: 6947
+  port: 8092
   # interface: localhost # uncomment to only listen on localhost
   # more per-service config settings
   # the location of the spec, defaults to spec.yaml if not specified
diff --git a/lib/eventstreams-util.js b/lib/eventstreams-util.js
index 8cb8849..71e3535 100644
--- a/lib/eventstreams-util.js
+++ b/lib/eventstreams-util.js
@@ -164,8 +164,7 @@
 
 if (key in this.counters) {
 this.counters[key] += delta;
-}
-else {
+} else {
 this.counters[key] = delta;
 }
 }
diff --git a/routes/v2.js b/routes/v2.js
index 1a18709..2e410c7 100644
--- a/routes/v2.js
+++ b/routes/v2.js
@@ -54,7 +54,7 @@
 
 module.exports = function(appObj) {
 
-app = appObj
+app = appObj;
 
 // Per-worker metrics will be prefixed with hostname.worker_id
 const workerMetricPrefix = `${os.hostname()}.${app.conf.worker_id}`;
@@ -89,4 +89,3 @@
 router
 };
 };
-

-- 
To view, visit https://gerrit.wikimedia.org/r/338283
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I66e0ba0c6afe1e61d1aa59dd60c4d993e0714a66
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/eventstreams
Gerrit-Branch: master
Gerrit-Owner: Ottomata 
Gerrit-Reviewer: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...eventstreams[master]: Fix lint complaints, update to version 0.0.2, change default...

2017-02-16 Thread Ottomata (Code Review) 
Ottomata has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/338283 )

Change subject: Fix lint complaints, update to version 0.0.2, change default 
port to 8092
..

Fix lint complaints, update to version 0.0.2, change default port to 8092

Change-Id: I66e0ba0c6afe1e61d1aa59dd60c4d993e0714a66
---
M config.dev.yaml
M config.prod.yaml
M lib/eventstreams-util.js
M routes/v2.js
4 files changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/eventstreams 
refs/changes/83/338283/1

diff --git a/config.dev.yaml b/config.dev.yaml
index 24253e9..9c3c1e0 100644
--- a/config.dev.yaml
+++ b/config.dev.yaml
@@ -32,7 +32,7 @@
 # version: ^0.4.0
 # per-service config
 conf:
-  port: 8000
+  port: 8092
   # interface: localhost # uncomment to only listen on localhost
   # more per-service config settings
   # the location of the spec, defaults to spec.yaml if not specified
diff --git a/config.prod.yaml b/config.prod.yaml
index d5fcdbb..3d24fdb 100644
--- a/config.prod.yaml
+++ b/config.prod.yaml
@@ -30,7 +30,7 @@
 # version: ^0.4.0
 # per-service config
 conf:
-  port: 6947
+  port: 8092
   # interface: localhost # uncomment to only listen on localhost
   # more per-service config settings
   # the location of the spec, defaults to spec.yaml if not specified
diff --git a/lib/eventstreams-util.js b/lib/eventstreams-util.js
index 8cb8849..71e3535 100644
--- a/lib/eventstreams-util.js
+++ b/lib/eventstreams-util.js
@@ -164,8 +164,7 @@
 
 if (key in this.counters) {
 this.counters[key] += delta;
-}
-else {
+} else {
 this.counters[key] = delta;
 }
 }
diff --git a/routes/v2.js b/routes/v2.js
index 1a18709..2e410c7 100644
--- a/routes/v2.js
+++ b/routes/v2.js
@@ -54,7 +54,7 @@
 
 module.exports = function(appObj) {
 
-app = appObj
+app = appObj;
 
 // Per-worker metrics will be prefixed with hostname.worker_id
 const workerMetricPrefix = `${os.hostname()}.${app.conf.worker_id}`;
@@ -89,4 +89,3 @@
 router
 };
 };
-

-- 
To view, visit https://gerrit.wikimedia.org/r/338283
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I66e0ba0c6afe1e61d1aa59dd60c4d993e0714a66
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/eventstreams
Gerrit-Branch: master
Gerrit-Owner: Ottomata 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits