[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Remove locutus dependency

2017-04-26 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/350356 )

Change subject: Remove locutus dependency
..


Remove locutus dependency

encodeURIComponent should be sufficient to encode a title inside an
HTTP path.

Change-Id: I4a78ead30749432c37a76fd4f96cbc996a1eae91
---
M lib/pageviews.js
M package.json
2 files changed, 1 insertion(+), 3 deletions(-)

Approvals:
  Krinkle: Looks good to me, but someone else must approve
  Gergő Tisza: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Mholloway: Looks good to me, approved



diff --git a/lib/pageviews.js b/lib/pageviews.js
index 01e87c5..f3d36b2 100644
--- a/lib/pageviews.js
+++ b/lib/pageviews.js
@@ -2,7 +2,6 @@
 
 const api = require('./api-util');
 const dateUtil = require('./dateUtil');
-const urlencode = require('locutus/php/url/urlencode');
 
 /**
  * @readonly
@@ -62,7 +61,7 @@
  * @return {!Promise} Daily pageviews on domain from platform for title 
from [start, end]
 */
 reqPage(domain, platform, agent, title, granularity, start, end) {
-const titleEncoded = urlencode(title);
+const titleEncoded = encodeURIComponent(title);
 const startStr = dateUtil.formatMMDD(start);
 const endStr = dateUtil.formatMMDD(end);
 // eslint-disable-next-line max-len
diff --git a/package.json b/package.json
index e03e1b2..ac6d4e9 100644
--- a/package.json
+++ b/package.json
@@ -49,7 +49,6 @@
 "escape-string-regexp": "^1.0.5",
 "express": "^4.14.0",
 "js-yaml": "^3.7.0",
-"locutus": "^2.0.5",
 "mediawiki-title": "^0.5.6",
 "preq": "^0.5.1",
 "service-runner": "^2.2.5",

-- 
To view, visit https://gerrit.wikimedia.org/r/350356
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4a78ead30749432c37a76fd4f96cbc996a1eae91
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 
Gerrit-Reviewer: Gergő Tisza 
Gerrit-Reviewer: Krinkle 
Gerrit-Reviewer: Mholloway 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Remove locutus dependency

2017-04-25 Thread BearND (Code Review) 
BearND has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/350356 )

Change subject: Remove locutus dependency
..

Remove locutus dependency

encodeURIComponent should be sufficient to encode a title inside an
HTTP path.

Change-Id: I4a78ead30749432c37a76fd4f96cbc996a1eae91
---
M lib/pageviews.js
M package.json
2 files changed, 1 insertion(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps 
refs/changes/56/350356/1

diff --git a/lib/pageviews.js b/lib/pageviews.js
index 01e87c5..f3d36b2 100644
--- a/lib/pageviews.js
+++ b/lib/pageviews.js
@@ -2,7 +2,6 @@
 
 const api = require('./api-util');
 const dateUtil = require('./dateUtil');
-const urlencode = require('locutus/php/url/urlencode');
 
 /**
  * @readonly
@@ -62,7 +61,7 @@
  * @return {!Promise} Daily pageviews on domain from platform for title 
from [start, end]
 */
 reqPage(domain, platform, agent, title, granularity, start, end) {
-const titleEncoded = urlencode(title);
+const titleEncoded = encodeURIComponent(title);
 const startStr = dateUtil.formatMMDD(start);
 const endStr = dateUtil.formatMMDD(end);
 // eslint-disable-next-line max-len
diff --git a/package.json b/package.json
index e03e1b2..ac6d4e9 100644
--- a/package.json
+++ b/package.json
@@ -49,7 +49,6 @@
 "escape-string-regexp": "^1.0.5",
 "express": "^4.14.0",
 "js-yaml": "^3.7.0",
-"locutus": "^2.0.5",
 "mediawiki-title": "^0.5.6",
 "preq": "^0.5.1",
 "service-runner": "^2.2.5",

-- 
To view, visit https://gerrit.wikimedia.org/r/350356
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a78ead30749432c37a76fd4f96cbc996a1eae91
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: BearND 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits