[MediaWiki-commits] [Gerrit] mw.ApiUploadFormDataHandler: Also handle rejected promises - change (mediawiki...UploadWizard)

2016-06-14 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: mw.ApiUploadFormDataHandler: Also handle rejected promises
..


mw.ApiUploadFormDataHandler: Also handle rejected promises

mw.FormDataTransport may reject the promise upon network failures or
in some situations involving chunked uploads.

Change-Id: I2d287165a7201b1e91beb0c5a30003bd3c7a7ab8
---
M resources/handlers/mw.ApiUploadFormDataHandler.js
1 file changed, 5 insertions(+), 0 deletions(-)

Approvals:
  MarkTraceur: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/handlers/mw.ApiUploadFormDataHandler.js 
b/resources/handlers/mw.ApiUploadFormDataHandler.js
index e2bde28..9f75a56 100644
--- a/resources/handlers/mw.ApiUploadFormDataHandler.js
+++ b/resources/handlers/mw.ApiUploadFormDataHandler.js
@@ -71,6 +71,11 @@

uw.eventFlowLogger.logApiError( 'file', result );
}
handler.upload.setTransported( 
result );
+   }, function ( result ) {
+   if ( !result || result.error || 
( result.upload && result.upload.warnings ) ) {
+   
uw.eventFlowLogger.logApiError( 'file', result );
+   }
+   handler.upload.setTransported( 
result );
} );
}, function ( code, info, result ) {
uw.eventFlowLogger.logApiError( 'file', result 
);

-- 
To view, visit https://gerrit.wikimedia.org/r/292791
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2d287165a7201b1e91beb0c5a30003bd3c7a7ab8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 
Gerrit-Reviewer: MarkTraceur 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] mw.ApiUploadFormDataHandler: Also handle rejected promises - change (mediawiki...UploadWizard)

2016-06-04 Thread Code Review 
Bartosz Dziewoński has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/292791

Change subject: mw.ApiUploadFormDataHandler: Also handle rejected promises
..

mw.ApiUploadFormDataHandler: Also handle rejected promises

mw.FormDataTransport may reject the promise upon network failures or
in some situations involving chunked uploads.

Change-Id: I2d287165a7201b1e91beb0c5a30003bd3c7a7ab8
---
M resources/handlers/mw.ApiUploadFormDataHandler.js
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard 
refs/changes/91/292791/1

diff --git a/resources/handlers/mw.ApiUploadFormDataHandler.js 
b/resources/handlers/mw.ApiUploadFormDataHandler.js
index e2bde28..9f75a56 100644
--- a/resources/handlers/mw.ApiUploadFormDataHandler.js
+++ b/resources/handlers/mw.ApiUploadFormDataHandler.js
@@ -71,6 +71,11 @@

uw.eventFlowLogger.logApiError( 'file', result );
}
handler.upload.setTransported( 
result );
+   }, function ( result ) {
+   if ( !result || result.error || 
( result.upload && result.upload.warnings ) ) {
+   
uw.eventFlowLogger.logApiError( 'file', result );
+   }
+   handler.upload.setTransported( 
result );
} );
}, function ( code, info, result ) {
uw.eventFlowLogger.logApiError( 'file', result 
);

-- 
To view, visit https://gerrit.wikimedia.org/r/292791
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2d287165a7201b1e91beb0c5a30003bd3c7a7ab8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits