[MediaWiki-commits] [Gerrit] oojs/ui[master]: [DEPRECATING CHANGE] icons: Flag unused 'bellOn' icon as to ...

2017-12-11 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/395684 )

Change subject: [DEPRECATING CHANGE] icons: Flag unused 'bellOn' icon as to be 
removed
..


[DEPRECATING CHANGE] icons: Flag unused 'bellOn' icon as to be removed

Bug: T145163
Change-Id: Id73c673704ba9528a8b2a98f4a896905468beec3
---
M demos/pages/icons.js
M src/themes/apex/icons-alerts.json
M src/themes/wikimediaui/icons-alerts.json
3 files changed, 6 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/demos/pages/icons.js b/demos/pages/icons.js
index 8ae0e63..824b65b 100644
--- a/demos/pages/icons.js
+++ b/demos/pages/icons.js
@@ -37,7 +37,6 @@
alerts: [
'alert',
'bell',
-   'bellOn',
'comment',
'message',
'notice',
diff --git a/src/themes/apex/icons-alerts.json 
b/src/themes/apex/icons-alerts.json
index 880f765..9bef0a1 100644
--- a/src/themes/apex/icons-alerts.json
+++ b/src/themes/apex/icons-alerts.json
@@ -7,7 +7,9 @@
"bellOn": { "file": {
"ltr": "images/icons/bellOn-ltr.svg",
"rtl": "images/icons/bellOn-rtl.svg"
-   } },
+   },
+   "deprecated": "This will be removed in v0.26.0."
+   },
"comment": { "file": "images/icons/comment.svg" },
"message": { "file": {
"ltr": "images/icons/message-ltr.svg",
diff --git a/src/themes/wikimediaui/icons-alerts.json 
b/src/themes/wikimediaui/icons-alerts.json
index 0d45a51..ee79a2e 100644
--- a/src/themes/wikimediaui/icons-alerts.json
+++ b/src/themes/wikimediaui/icons-alerts.json
@@ -27,7 +27,9 @@
"bellOn": { "file": {
"ltr": "images/icons/bellOn-ltr.svg",
"rtl": "images/icons/bellOn-rtl.svg"
-   } },
+   },
+   "deprecated": "This will be removed in v0.26.0."
+   },
"comment": { "file": "images/icons/comment.svg" },
"message": { "file": {
"ltr": "images/icons/message-ltr.svg",

-- 
To view, visit https://gerrit.wikimedia.org/r/395684
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id73c673704ba9528a8b2a98f4a896905468beec3
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Prtksxna 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: [DEPRECATING CHANGE] icons: Flag unused 'bellOn' icon as to ...

2017-12-05 Thread VolkerE (Code Review) 
VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395684 )

Change subject: [DEPRECATING CHANGE] icons: Flag unused 'bellOn' icon as to be 
removed
..

[DEPRECATING CHANGE] icons: Flag unused 'bellOn' icon as to be removed

Bug: T145163
Change-Id: Id73c673704ba9528a8b2a98f4a896905468beec3
---
M demos/pages/icons.js
M src/themes/apex/icons-alerts.json
M src/themes/wikimediaui/icons-alerts.json
3 files changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/84/395684/1

diff --git a/demos/pages/icons.js b/demos/pages/icons.js
index 8ae0e63..824b65b 100644
--- a/demos/pages/icons.js
+++ b/demos/pages/icons.js
@@ -37,7 +37,6 @@
alerts: [
'alert',
'bell',
-   'bellOn',
'comment',
'message',
'notice',
diff --git a/src/themes/apex/icons-alerts.json 
b/src/themes/apex/icons-alerts.json
index 880f765..9bef0a1 100644
--- a/src/themes/apex/icons-alerts.json
+++ b/src/themes/apex/icons-alerts.json
@@ -7,7 +7,9 @@
"bellOn": { "file": {
"ltr": "images/icons/bellOn-ltr.svg",
"rtl": "images/icons/bellOn-rtl.svg"
-   } },
+   },
+   "deprecated": "This will be removed in v0.26.0."
+   },
"comment": { "file": "images/icons/comment.svg" },
"message": { "file": {
"ltr": "images/icons/message-ltr.svg",
diff --git a/src/themes/wikimediaui/icons-alerts.json 
b/src/themes/wikimediaui/icons-alerts.json
index 0d45a51..ee79a2e 100644
--- a/src/themes/wikimediaui/icons-alerts.json
+++ b/src/themes/wikimediaui/icons-alerts.json
@@ -27,7 +27,9 @@
"bellOn": { "file": {
"ltr": "images/icons/bellOn-ltr.svg",
"rtl": "images/icons/bellOn-rtl.svg"
-   } },
+   },
+   "deprecated": "This will be removed in v0.26.0."
+   },
"comment": { "file": "images/icons/comment.svg" },
"message": { "file": {
"ltr": "images/icons/message-ltr.svg",

-- 
To view, visit https://gerrit.wikimedia.org/r/395684
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id73c673704ba9528a8b2a98f4a896905468beec3
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits