[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: Add W3C Standards Notation for placeholder ...

2016-10-10 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: MediaWiki theme: Add W3C Standards Notation for placeholder 
pseudo class
..


MediaWiki theme: Add W3C Standards Notation for placeholder pseudo class

Adding W3C's `:placeholder-shown` pseudo-class from 
https://drafts.csswg.org/selectors-4/#placeholder
which is already supported in Chrome 47+, Safari 9+ & Firefox 51+.
Also being more explicit about what stylelint rule to disable.

Change-Id: I42fb531e283822ac183aa2995445b3b14ab1212f
---
M src/themes/mediawiki/widgets.less
1 file changed, 8 insertions(+), 4 deletions(-)

Approvals:
  Bartosz Dziewoński: Looks good to me, approved
  Prtksxna: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index fcf846d..1ac7c08 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -753,21 +753,25 @@
 
// Normalize placeholder styling, see T139034
// Firefox 4-18
-   :-moz-placeholder { // stylelint-disable-line
+   :-moz-placeholder { // stylelint-disable-line 
selector-no-vendor-prefix
color: @color-placeholder;
opacity: 1;
}
// Firefox 19-
-   ::-moz-placeholder { // stylelint-disable-line
+   ::-moz-placeholder { // stylelint-disable-line 
selector-no-vendor-prefix
color: @color-placeholder;
opacity: 1;
}
// Internet Explorer 10-11
-   :-ms-input-placeholder { // stylelint-disable-line
+   :-ms-input-placeholder { // stylelint-disable-line 
selector-no-vendor-prefix
color: @color-placeholder;
}
// WebKit, Blink, Edge
-   ::-webkit-input-placeholder { // stylelint-disable-line
+   ::-webkit-input-placeholder { // stylelint-disable-line 
selector-no-vendor-prefix
+   color: @color-placeholder;
+   }
+   // W3C Standard Selectors Level 4
+   :placeholder-shown {
color: @color-placeholder;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/315039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I42fb531e283822ac183aa2995445b3b14ab1212f
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Bartosz Dziewoński 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: Prtksxna 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: Add W3C Standards Notation for placeholder ...

2016-10-09 Thread VolkerE (Code Review) 
VolkerE has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315039

Change subject: MediaWiki theme: Add W3C Standards Notation for placeholder 
pseudo class
..

MediaWiki theme: Add W3C Standards Notation for placeholder pseudo class

Adding W3C's `:placeholder-shown` pseudo-class from 
https://drafts.csswg.org/selectors-4/#placeholder
which is already supported in Chrome 47+, Safari 9+ & Firefox 51+.
Also being more explicit about what stylelint rule to disable.

Change-Id: I42fb531e283822ac183aa2995445b3b14ab1212f
---
M src/themes/mediawiki/widgets.less
1 file changed, 8 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/39/315039/1

diff --git a/src/themes/mediawiki/widgets.less 
b/src/themes/mediawiki/widgets.less
index fcf846d..1ac7c08 100644
--- a/src/themes/mediawiki/widgets.less
+++ b/src/themes/mediawiki/widgets.less
@@ -753,21 +753,25 @@
 
// Normalize placeholder styling, see T139034
// Firefox 4-18
-   :-moz-placeholder { // stylelint-disable-line
+   :-moz-placeholder { // stylelint-disable-line 
selector-no-vendor-prefix
color: @color-placeholder;
opacity: 1;
}
// Firefox 19-
-   ::-moz-placeholder { // stylelint-disable-line
+   ::-moz-placeholder { // stylelint-disable-line 
selector-no-vendor-prefix
color: @color-placeholder;
opacity: 1;
}
// Internet Explorer 10-11
-   :-ms-input-placeholder { // stylelint-disable-line
+   :-ms-input-placeholder { // stylelint-disable-line 
selector-no-vendor-prefix
color: @color-placeholder;
}
// WebKit, Blink, Edge
-   ::-webkit-input-placeholder { // stylelint-disable-line
+   ::-webkit-input-placeholder { // stylelint-disable-line 
selector-no-vendor-prefix
+   color: @color-placeholder;
+   }
+   // W3C Standard Selectors Level 4
+   :placeholder-shown {
color: @color-placeholder;
}
 

-- 
To view, visit https://gerrit.wikimedia.org/r/315039
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I42fb531e283822ac183aa2995445b3b14ab1212f
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits