[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: Fix ButtonInputWidget appearance in Saf/iOS

2017-05-03 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/351702 )

Change subject: MediaWiki theme: Fix ButtonInputWidget appearance in Saf/iOS
..


MediaWiki theme: Fix ButtonInputWidget appearance in Saf/iOS

ButtonInputWidget's input needs to receive `-webkit-appearance: none`
on Safari. In contrast to Apex theme, we're not using a CSS gradient,
which automatically triggers Safari into not applying the default
styling.

Bug: T164411
Change-Id: Icc5db5c29217ab7436bbace145eaed8ade72
---
M src/themes/mediawiki/elements.less
1 file changed, 6 insertions(+), 3 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jforrester: Looks good to me, approved



diff --git a/src/themes/mediawiki/elements.less 
b/src/themes/mediawiki/elements.less
index 7284255..d6bf497 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -21,13 +21,16 @@
height: 100%;
}
 
-   &.oo-ui-labelElement > .oo-ui-buttonElement-button,
-   // Support `` from ButtonInputWidget
+   // ButtonInputWidget's ``
> input.oo-ui-buttonElement-button {
-   line-height: @line-height-reset;
+   -webkit-appearance: none; // Support: iOS Safari
}
 
&.oo-ui-labelElement {
+   > .oo-ui-buttonElement-button {
+   line-height: @line-height-reset;
+   }
+
.oo-ui-labelElement-label {
line-height: @line-height-widget-singleline;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/351702
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icc5db5c29217ab7436bbace145eaed8ade72
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 
Gerrit-Reviewer: Jforrester 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] oojs/ui[master]: MediaWiki theme: Fix ButtonInputWidget appearance in Saf/iOS

2017-05-03 Thread VolkerE (Code Review) 
VolkerE has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/351702 )

Change subject: MediaWiki theme: Fix ButtonInputWidget appearance in Saf/iOS
..

MediaWiki theme: Fix ButtonInputWidget appearance in Saf/iOS

ButtonInputWidget's input needs to receive `-webkit-appearance: none`
on Safari. In contrast to Apex theme, we're not using a CSS gradient,
which automatically triggers Safari into not applying the default
styling.

Bug: T164411
Change-Id: Icc5db5c29217ab7436bbace145eaed8ade72
---
M src/themes/mediawiki/elements.less
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/02/351702/1

diff --git a/src/themes/mediawiki/elements.less 
b/src/themes/mediawiki/elements.less
index 7284255..d6bf497 100644
--- a/src/themes/mediawiki/elements.less
+++ b/src/themes/mediawiki/elements.less
@@ -21,13 +21,16 @@
height: 100%;
}
 
-   &.oo-ui-labelElement > .oo-ui-buttonElement-button,
-   // Support `` from ButtonInputWidget
+   // ButtonInputWidget's ``
> input.oo-ui-buttonElement-button {
-   line-height: @line-height-reset;
+   -webkit-appearance: none; // Support: iOS Safari
}
 
&.oo-ui-labelElement {
+   > .oo-ui-buttonElement-button {
+   line-height: @line-height-reset;
+   }
+
.oo-ui-labelElement-label {
line-height: @line-height-widget-singleline;
}

-- 
To view, visit https://gerrit.wikimedia.org/r/351702
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc5db5c29217ab7436bbace145eaed8ade72
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: VolkerE 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits