[MediaWiki-commits] [Gerrit] oojs/ui[master]: TagMultiselectWidget: Fix #addTag return value to match docs
jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/352625 ) Change subject: TagMultiselectWidget: Fix #addTag return value to match docs .. TagMultiselectWidget: Fix #addTag return value to match docs Change-Id: I48212e6049e7e9c636bdc0ee63d2cf92f063e999 --- M src/widgets/TagMultiselectWidget.js 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: jenkins-bot: Verified Jforrester: Looks good to me, approved diff --git a/src/widgets/TagMultiselectWidget.js b/src/widgets/TagMultiselectWidget.js index 5fc9815..f69361e 100644 --- a/src/widgets/TagMultiselectWidget.js +++ b/src/widgets/TagMultiselectWidget.js @@ -604,7 +604,9 @@ newItemWidget = this.createTagItemWidget( data, label ); newItemWidget.toggleValid( isValid ); this.addItems( [ newItemWidget ] ); + return true; } + return false; }; /** -- To view, visit https://gerrit.wikimedia.org/r/352625 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I48212e6049e7e9c636bdc0ee63d2cf92f063e999 Gerrit-PatchSet: 1 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński Gerrit-Reviewer: Jforrester Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] oojs/ui[master]: TagMultiselectWidget: Fix #addTag return value to match docs
Bartosz Dziewoński has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352625 ) Change subject: TagMultiselectWidget: Fix #addTag return value to match docs .. TagMultiselectWidget: Fix #addTag return value to match docs Change-Id: I48212e6049e7e9c636bdc0ee63d2cf92f063e999 --- M src/widgets/TagMultiselectWidget.js 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/25/352625/1 diff --git a/src/widgets/TagMultiselectWidget.js b/src/widgets/TagMultiselectWidget.js index 5fc9815..f69361e 100644 --- a/src/widgets/TagMultiselectWidget.js +++ b/src/widgets/TagMultiselectWidget.js @@ -604,7 +604,9 @@ newItemWidget = this.createTagItemWidget( data, label ); newItemWidget.toggleValid( isValid ); this.addItems( [ newItemWidget ] ); + return true; } + return false; }; /** -- To view, visit https://gerrit.wikimedia.org/r/352625 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I48212e6049e7e9c636bdc0ee63d2cf92f063e999 Gerrit-PatchSet: 1 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits