[MediaWiki-commits] [Gerrit] openzim[master]: Delete all articles, even the last one.
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/303776 ) Change subject: Delete all articles, even the last one. .. Delete all articles, even the last one. No so important, only one article *could* be impacted. (If it is the last article and it is invalid) Change-Id: Ibd3e7587148eccbdb2c588d4a915a94e343fc003 --- M zimwriterfs/articlesource.cpp 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Kelson: Verified; Looks good to me, approved diff --git a/zimwriterfs/articlesource.cpp b/zimwriterfs/articlesource.cpp index 0eea3e1..5ce0cc1 100644 --- a/zimwriterfs/articlesource.cpp +++ b/zimwriterfs/articlesource.cpp @@ -75,6 +75,7 @@ article = new FileArticle(path); }; if (article->isInvalid()) { + delete article; article = NULL; } } -- To view, visit https://gerrit.wikimedia.org/r/303776 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd3e7587148eccbdb2c588d4a915a94e343fc003 Gerrit-PatchSet: 1 Gerrit-Project: openzim Gerrit-Branch: master Gerrit-Owner: Mgautierfr Gerrit-Reviewer: Kelson ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] openzim[master]: Delete all articles, even the last one.
Kelson has submitted this change and it was merged. Change subject: Delete all articles, even the last one. .. Delete all articles, even the last one. No so important, only one article *could* be impacted. (If it is the last article and it is invalid) Change-Id: Ibd3e7587148eccbdb2c588d4a915a94e343fc003 --- M zimwriterfs/articlesource.cpp 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Kelson: Verified; Looks good to me, approved diff --git a/zimwriterfs/articlesource.cpp b/zimwriterfs/articlesource.cpp index 0eea3e1..5ce0cc1 100644 --- a/zimwriterfs/articlesource.cpp +++ b/zimwriterfs/articlesource.cpp @@ -75,6 +75,7 @@ article = new FileArticle(path); }; if (article->isInvalid()) { + delete article; article = NULL; } } -- To view, visit https://gerrit.wikimedia.org/r/303776 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd3e7587148eccbdb2c588d4a915a94e343fc003 Gerrit-PatchSet: 1 Gerrit-Project: openzim Gerrit-Branch: master Gerrit-Owner: Mgautierfr Gerrit-Reviewer: Kelson ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] openzim[master]: Delete all articles, even the last one.
Mgautierfr has uploaded a new change for review. https://gerrit.wikimedia.org/r/303776 Change subject: Delete all articles, even the last one. .. Delete all articles, even the last one. No so important, only one article *could* be impacted. (If it is the last article and it is invalid) Change-Id: Ibd3e7587148eccbdb2c588d4a915a94e343fc003 --- M zimwriterfs/articlesource.cpp 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/openzim refs/changes/76/303776/1 diff --git a/zimwriterfs/articlesource.cpp b/zimwriterfs/articlesource.cpp index 0eea3e1..5ce0cc1 100644 --- a/zimwriterfs/articlesource.cpp +++ b/zimwriterfs/articlesource.cpp @@ -75,6 +75,7 @@ article = new FileArticle(path); }; if (article->isInvalid()) { + delete article; article = NULL; } } -- To view, visit https://gerrit.wikimedia.org/r/303776 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd3e7587148eccbdb2c588d4a915a94e343fc003 Gerrit-PatchSet: 1 Gerrit-Project: openzim Gerrit-Branch: master Gerrit-Owner: Mgautierfr ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits