Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295633 )
Change subject: Readd call to stripTitleInvalidChars. ...................................................................... Readd call to stripTitleInvalidChars. Commit 1c969dd remove the call to stripTitleInvalidChars in Article. This was a error while rebasing changes. Fix this. Change-Id: I001bcdce81db27a359703221c929620e543b0a32 --- M zimwriterfs/article.cpp M zimwriterfs/tools.h 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: Kelson: Verified; Looks good to me, approved diff --git a/zimwriterfs/article.cpp b/zimwriterfs/article.cpp index f743cde..4aeb083 100644 --- a/zimwriterfs/article.cpp +++ b/zimwriterfs/article.cpp @@ -69,6 +69,7 @@ GumboNode* title_text = (GumboNode*)(child->v.element.children.data[0]); if (title_text->type == GUMBO_NODE_TEXT) { title = title_text->v.text.text; + stripTitleInvalidChars(title); } } } diff --git a/zimwriterfs/tools.h b/zimwriterfs/tools.h index ec6b454..8b43da4 100644 --- a/zimwriterfs/tools.h +++ b/zimwriterfs/tools.h @@ -40,6 +40,7 @@ void replaceStringInPlaceOnce(std::string& subject, const std::string& search, const std::string& replace); void replaceStringInPlace(std::string& subject, const std::string& search, const std::string& replace); +void stripTitleInvalidChars(std::string & str); std::string extractRedirectUrlFromHtml(const GumboVector* head_children); void getLinks(GumboNode* node, std::map<std::string, bool> &links); -- To view, visit https://gerrit.wikimedia.org/r/295633 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I001bcdce81db27a359703221c929620e543b0a32 Gerrit-PatchSet: 1 Gerrit-Project: openzim Gerrit-Branch: master Gerrit-Owner: Mgautierfr <mgaut...@kymeria.fr> Gerrit-Reviewer: Kelson <kel...@kiwix.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits