[MediaWiki-commits] [Gerrit] operations/puppet[production]: ganglia: Fix optional parameter listed before required param...

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged.

Change subject: ganglia: Fix optional parameter listed before required parameter
..


ganglia: Fix optional parameter listed before required parameter

Bug: T93645
Change-Id: Icf06eaba5964e34921b03aa90741770b30249656
---
M modules/ganglia/manifests/gmetad.pp
M modules/ganglia/manifests/gmetad/rrdcached.pp
M modules/ganglia/manifests/web.pp
3 files changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Hashar: Looks good to me, but someone else must approve
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/ganglia/manifests/gmetad.pp 
b/modules/ganglia/manifests/gmetad.pp
index 9b85e46..fd9c373 100644
--- a/modules/ganglia/manifests/gmetad.pp
+++ b/modules/ganglia/manifests/gmetad.pp
@@ -1,5 +1,4 @@
 class ganglia::gmetad(
-$ensure='present',
 $grid,
 $rrd_rootdir,
 $gmetad_root,
@@ -8,6 +7,7 @@
 $trusted_hosts,
 $data_sources,
 $rra_sizes,
+$ensure='present',
 ) {
 
 package { 'gmetad':
diff --git a/modules/ganglia/manifests/gmetad/rrdcached.pp 
b/modules/ganglia/manifests/gmetad/rrdcached.pp
index f35eea0..f808a36 100644
--- a/modules/ganglia/manifests/gmetad/rrdcached.pp
+++ b/modules/ganglia/manifests/gmetad/rrdcached.pp
@@ -1,9 +1,9 @@
 # Only support trusty
 class ganglia::gmetad::rrdcached(
-$ensure='present',
 $rrdpath,
 $gmetad_socket,
 $gweb_socket,
+$ensure='present',
 $journal_dir='/var/lib/rrdcached/journal',
 ) {
 package { 'rrdcached':
diff --git a/modules/ganglia/manifests/web.pp b/modules/ganglia/manifests/web.pp
index 389e442..31312af 100644
--- a/modules/ganglia/manifests/web.pp
+++ b/modules/ganglia/manifests/web.pp
@@ -1,8 +1,8 @@
 # Class for the ganglia frontend machine
 class ganglia::web(
-$ensure='present',
 $rrdcached_socket,
 $gmetad_root,
+$ensure='present',
 ) {
 include ::apache
 include ::apache::mod::php5

-- 
To view, visit https://gerrit.wikimedia.org/r/308339
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icf06eaba5964e34921b03aa90741770b30249656
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ganglia: Fix optional parameter listed before required param...

[Paladox (Code Review)]

Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/308339

Change subject: ganglia: Fix optional parameter listed before required parameter
..

ganglia: Fix optional parameter listed before required parameter

Bug: T93645
Change-Id: Icf06eaba5964e34921b03aa90741770b30249656
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/39/308339/1


-- 
To view, visit https://gerrit.wikimedia.org/r/308339
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icf06eaba5964e34921b03aa90741770b30249656
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits