[MediaWiki-commits] [Gerrit] operations/puppet[production]: install_server module: Linting changes

2017-01-17 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/332102 )

Change subject: install_server module: Linting changes
..


install_server module: Linting changes

Add trailing commas to abide by the Coding Style guidelines

Use full names for class names, as relative names are not allowed in
future Puppet versions

Change-Id: I0009a7ad444784b937b07fc595dd1960b103a107
---
M modules/install_server/manifests/dhcp_server.pp
M modules/install_server/manifests/preseed_server.pp
M modules/install_server/manifests/tftp_server.pp
M modules/install_server/tests/dhcp_server.pp
M modules/install_server/tests/preseed_server.pp
M modules/install_server/tests/tftp_server.pp
M modules/install_server/tests/web_server.pp
7 files changed, 8 insertions(+), 8 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/install_server/manifests/dhcp_server.pp 
b/modules/install_server/manifests/dhcp_server.pp
index 5d4a52c..529ab26 100644
--- a/modules/install_server/manifests/dhcp_server.pp
+++ b/modules/install_server/manifests/dhcp_server.pp
@@ -14,7 +14,7 @@
 
 class install_server::dhcp_server {
 
-include standard
+include ::standard
 
 file { '/etc/dhcp':
 ensure  => directory,
diff --git a/modules/install_server/manifests/preseed_server.pp 
b/modules/install_server/manifests/preseed_server.pp
index a04dd04..565b3cc 100644
--- a/modules/install_server/manifests/preseed_server.pp
+++ b/modules/install_server/manifests/preseed_server.pp
@@ -20,6 +20,6 @@
 group   => 'root',
 source  => 'puppet:///modules/install_server/autoinstall',
 recurse => true,
-links   => manage
+links   => manage,
 }
 }
diff --git a/modules/install_server/manifests/tftp_server.pp 
b/modules/install_server/manifests/tftp_server.pp
index 5cfc14c..018c86a 100644
--- a/modules/install_server/manifests/tftp_server.pp
+++ b/modules/install_server/manifests/tftp_server.pp
@@ -14,7 +14,7 @@
 
 class install_server::tftp_server {
 
-include standard
+include ::standard
 
 file { '/srv/tftpboot':
 # config files in the puppet repository,
@@ -22,7 +22,7 @@
 source   => [
 'puppet:///modules/install_server/tftpboot',
 # lint:ignore:puppet_url_without_modules
-'puppet:///volatile/tftpboot'
+'puppet:///volatile/tftpboot',
 # lint:endignore
 ],
 sourceselect => all,
diff --git a/modules/install_server/tests/dhcp_server.pp 
b/modules/install_server/tests/dhcp_server.pp
index fd8d98a..f5d20d3 100644
--- a/modules/install_server/tests/dhcp_server.pp
+++ b/modules/install_server/tests/dhcp_server.pp
@@ -1,2 +1,2 @@
 #
-include install_server::dhcp_server
+include ::install_server::dhcp_server
diff --git a/modules/install_server/tests/preseed_server.pp 
b/modules/install_server/tests/preseed_server.pp
index 4634097..16383e7 100644
--- a/modules/install_server/tests/preseed_server.pp
+++ b/modules/install_server/tests/preseed_server.pp
@@ -1,2 +1,2 @@
 #
-include install_server::preseed_server
+include ::install_server::preseed_server
diff --git a/modules/install_server/tests/tftp_server.pp 
b/modules/install_server/tests/tftp_server.pp
index 713ed88..fdb294a 100644
--- a/modules/install_server/tests/tftp_server.pp
+++ b/modules/install_server/tests/tftp_server.pp
@@ -1,2 +1,2 @@
 #
-include install_server::tftp_server
+include ::install_server::tftp_server
diff --git a/modules/install_server/tests/web_server.pp 
b/modules/install_server/tests/web_server.pp
index 49f62e3..216be9e 100644
--- a/modules/install_server/tests/web_server.pp
+++ b/modules/install_server/tests/web_server.pp
@@ -1,2 +1,2 @@
 #
-include install_server::web_server
+include ::install_server::web_server

-- 
To view, visit https://gerrit.wikimedia.org/r/332102
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0009a7ad444784b937b07fc595dd1960b103a107
Gerrit-PatchSet: 5
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Juniorsys 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Filippo Giunchedi 
Gerrit-Reviewer: Jcrespo 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: install_server module: Linting changes

2017-01-14 Thread Juniorsys (Code Review) 
Juniorsys has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/332102 )

Change subject: install_server module: Linting changes
..

install_server module: Linting changes

Add trailing commas to abide by the Coding Style guidelines

Use full names for class names, as relative names are not allowed in
future Puppet versions

Change-Id: I0009a7ad444784b937b07fc595dd1960b103a107
---
M modules/install_server/manifests/dhcp_server.pp
M modules/install_server/manifests/preseed_server.pp
M modules/install_server/manifests/tftp_server.pp
M modules/install_server/tests/dhcp_server.pp
M modules/install_server/tests/preseed_server.pp
M modules/install_server/tests/tftp_server.pp
M modules/install_server/tests/web_server.pp
7 files changed, 8 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/02/332102/1

diff --git a/modules/install_server/manifests/dhcp_server.pp 
b/modules/install_server/manifests/dhcp_server.pp
index 5d4a52c..529ab26 100644
--- a/modules/install_server/manifests/dhcp_server.pp
+++ b/modules/install_server/manifests/dhcp_server.pp
@@ -14,7 +14,7 @@
 
 class install_server::dhcp_server {
 
-include standard
+include ::standard
 
 file { '/etc/dhcp':
 ensure  => directory,
diff --git a/modules/install_server/manifests/preseed_server.pp 
b/modules/install_server/manifests/preseed_server.pp
index a04dd04..565b3cc 100644
--- a/modules/install_server/manifests/preseed_server.pp
+++ b/modules/install_server/manifests/preseed_server.pp
@@ -20,6 +20,6 @@
 group   => 'root',
 source  => 'puppet:///modules/install_server/autoinstall',
 recurse => true,
-links   => manage
+links   => manage,
 }
 }
diff --git a/modules/install_server/manifests/tftp_server.pp 
b/modules/install_server/manifests/tftp_server.pp
index 5cfc14c..018c86a 100644
--- a/modules/install_server/manifests/tftp_server.pp
+++ b/modules/install_server/manifests/tftp_server.pp
@@ -14,7 +14,7 @@
 
 class install_server::tftp_server {
 
-include standard
+include ::standard
 
 file { '/srv/tftpboot':
 # config files in the puppet repository,
@@ -22,7 +22,7 @@
 source   => [
 'puppet:///modules/install_server/tftpboot',
 # lint:ignore:puppet_url_without_modules
-'puppet:///volatile/tftpboot'
+'puppet:///volatile/tftpboot',
 # lint:endignore
 ],
 sourceselect => all,
diff --git a/modules/install_server/tests/dhcp_server.pp 
b/modules/install_server/tests/dhcp_server.pp
index fd8d98a..f5d20d3 100644
--- a/modules/install_server/tests/dhcp_server.pp
+++ b/modules/install_server/tests/dhcp_server.pp
@@ -1,2 +1,2 @@
 #
-include install_server::dhcp_server
+include ::install_server::dhcp_server
diff --git a/modules/install_server/tests/preseed_server.pp 
b/modules/install_server/tests/preseed_server.pp
index 4634097..16383e7 100644
--- a/modules/install_server/tests/preseed_server.pp
+++ b/modules/install_server/tests/preseed_server.pp
@@ -1,2 +1,2 @@
 #
-include install_server::preseed_server
+include ::install_server::preseed_server
diff --git a/modules/install_server/tests/tftp_server.pp 
b/modules/install_server/tests/tftp_server.pp
index 713ed88..fdb294a 100644
--- a/modules/install_server/tests/tftp_server.pp
+++ b/modules/install_server/tests/tftp_server.pp
@@ -1,2 +1,2 @@
 #
-include install_server::tftp_server
+include ::install_server::tftp_server
diff --git a/modules/install_server/tests/web_server.pp 
b/modules/install_server/tests/web_server.pp
index 49f62e3..216be9e 100644
--- a/modules/install_server/tests/web_server.pp
+++ b/modules/install_server/tests/web_server.pp
@@ -1,2 +1,2 @@
 #
-include install_server::web_server
+include ::install_server::web_server

-- 
To view, visit https://gerrit.wikimedia.org/r/332102
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0009a7ad444784b937b07fc595dd1960b103a107
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Juniorsys 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits