[MediaWiki-commits] [Gerrit] operations/puppet[production]: lists/icinga: remove I/O monitoring on lists server

2017-07-26 Thread Dzahn (Code Review)
Dzahn has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/368110 )

Change subject: lists/icinga: remove I/O monitoring on lists server
..


lists/icinga: remove I/O monitoring on lists server

This check hasn't been as useful as we hoped it would be.

It has once been added as a reaction to an outage but it has
almost exclusively reported false positives which were natural spikes.

We have added a new check for size of exim queues on MX servers today
and as also suggested by Filippo, we should remove this old check while
at it in exchange for that.

Bug: T133110
Change-Id: I1b8006d323b8ba390d6a96aa69a4ec853ee2a28f
---
M modules/profile/manifests/lists.pp
1 file changed, 0 insertions(+), 26 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/modules/profile/manifests/lists.pp 
b/modules/profile/manifests/lists.pp
index 573e7dc..1675939 100644
--- a/modules/profile/manifests/lists.pp
+++ b/modules/profile/manifests/lists.pp
@@ -105,32 +105,6 @@
 nrpe_command => '/usr/bin/sudo -u list 
/usr/local/lib/nagios/plugins/check_mailman_queue 25 25 25',
 }
 
-# on list servers we monitor I/O with iostat
-# the icinga plugin needs bc to compare floating point numbers
-package { 'bc':
-ensure => present,
-}
-
-file { '/usr/local/lib/nagios/plugins/check_iostat':
-ensure => present,
-owner  => 'root',
-group  => 'root',
-mode   => '0755',
-source => 'puppet:///modules/icinga/check_iostat.sh',
-}
-
-$iostat_device = $facts['is_virtual'] ? {
-true=> 'vda',
-false   => 'sda',
-}
-
-nrpe::monitor_service { 'mailman_iostat':
-description  => 'mailman I/O stats',
-nrpe_command => "/usr/local/lib/nagios/plugins/check_iostat \
--i -w 250,350,300,14000,7500 -c 
500,400,600,28000,11000 -d ${iostat_device}",
-timeout  => '30',
-}
-
 ferm::service { 'mailman-smtp':
 proto => 'tcp',
 port  => '25',

-- 
To view, visit https://gerrit.wikimedia.org/r/368110
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1b8006d323b8ba390d6a96aa69a4ec853ee2a28f
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Alexandros Kosiaris 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Filippo Giunchedi 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] operations/puppet[production]: lists/icinga: remove I/O monitoring on lists server

2017-07-26 Thread Dzahn (Code Review)
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/368110 )

Change subject: lists/icinga: remove I/O monitoring on lists server
..

lists/icinga: remove I/O monitoring on lists server

This check hasn't been as useful as we hoped it would be.

It has once been added as a reaction to an outage but it has
almost exclusively reported false positives which were natural spikes.

We have added a new check for size of exim queues on MX servers today
and as also suggested by Filippo, we should remove this old check while
at it in exchange for that.

Bug: T133110
Change-Id: I1b8006d323b8ba390d6a96aa69a4ec853ee2a28f
---
M modules/profile/manifests/lists.pp
1 file changed, 0 insertions(+), 26 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/10/368110/1

diff --git a/modules/profile/manifests/lists.pp 
b/modules/profile/manifests/lists.pp
index 573e7dc..1675939 100644
--- a/modules/profile/manifests/lists.pp
+++ b/modules/profile/manifests/lists.pp
@@ -105,32 +105,6 @@
 nrpe_command => '/usr/bin/sudo -u list 
/usr/local/lib/nagios/plugins/check_mailman_queue 25 25 25',
 }
 
-# on list servers we monitor I/O with iostat
-# the icinga plugin needs bc to compare floating point numbers
-package { 'bc':
-ensure => present,
-}
-
-file { '/usr/local/lib/nagios/plugins/check_iostat':
-ensure => present,
-owner  => 'root',
-group  => 'root',
-mode   => '0755',
-source => 'puppet:///modules/icinga/check_iostat.sh',
-}
-
-$iostat_device = $facts['is_virtual'] ? {
-true=> 'vda',
-false   => 'sda',
-}
-
-nrpe::monitor_service { 'mailman_iostat':
-description  => 'mailman I/O stats',
-nrpe_command => "/usr/local/lib/nagios/plugins/check_iostat \
--i -w 250,350,300,14000,7500 -c 
500,400,600,28000,11000 -d ${iostat_device}",
-timeout  => '30',
-}
-
 ferm::service { 'mailman-smtp':
 proto => 'tcp',
 port  => '25',

-- 
To view, visit https://gerrit.wikimedia.org/r/368110
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b8006d323b8ba390d6a96aa69a4ec853ee2a28f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits