[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb: Use the common gtid_domain_id

2017-02-05 Thread Marostegui (Code Review) 
Marostegui has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/335817 )

Change subject: mariadb: Use the common gtid_domain_id
..


mariadb: Use the common gtid_domain_id

The labsdb hosts were still using the old way of generating
gtid_domain_id flag, which we changed. So for consistency just updating
the file to use the new one. This will not change the current value of
gtid_domain_id.
This is related to: https://gerrit.wikimedia.org/r/#/c/326086/

Bug: T149418
Change-Id: I721f29f0a10bd075423ea26094955b9f617b6d17
---
M templates/mariadb/labsdb-replica.my.cnf.erb
1 file changed, 7 insertions(+), 2 deletions(-)

Approvals:
  Marostegui: Looks good to me, approved
  jenkins-bot: Verified
  Jcrespo: Looks good to me, but someone else must approve



diff --git a/templates/mariadb/labsdb-replica.my.cnf.erb 
b/templates/mariadb/labsdb-replica.my.cnf.erb
index 21a44b3..63c744e 100644
--- a/templates/mariadb/labsdb-replica.my.cnf.erb
+++ b/templates/mariadb/labsdb-replica.my.cnf.erb
@@ -25,11 +25,16 @@
 port   = 3306
 datadir= <%= @datadir %>
 tmpdir = <%= @tmpdir %>
-# needed for multisource replication + GTID.
-gtid_domain_id = <%= @server_id %>
 server_id  = <%= @server_id %>
 read_only  = 0
 
+# gtid_domain_id flag is needed for multisource replication and GTID.
+# Strictly it is only needed on masters or servers that can potentially be
+# masters but for consistency it should be set in all of them.
+# https://mariadb.com/kb/en/mariadb/gtid/
+
+gtid_domain_id  = <%= @gtid_domain_id %>
+
 # enable socket authentication
 plugin-load = unix_socket=auth_socket.so
 

-- 
To view, visit https://gerrit.wikimedia.org/r/335817
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I721f29f0a10bd075423ea26094955b9f617b6d17
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Marostegui 
Gerrit-Reviewer: Jcrespo 
Gerrit-Reviewer: Marostegui 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mariadb: Use the common gtid_domain_id

2017-02-03 Thread Marostegui (Code Review) 
Marostegui has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/335817 )

Change subject: mariadb: Use the common gtid_domain_id
..

mariadb: Use the common gtid_domain_id

The labsdb hosts were still using the old way of generating
gtid_domain_id flag, which we changed. So for consistency just updating
the file to use the new one. This will not change the current value of
gtid_domain_id.
This is related to: https://gerrit.wikimedia.org/r/#/c/326086/

Bug: T149418
Change-Id: I721f29f0a10bd075423ea26094955b9f617b6d17
---
M templates/mariadb/labsdb-replica.my.cnf.erb
1 file changed, 7 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/17/335817/1

diff --git a/templates/mariadb/labsdb-replica.my.cnf.erb 
b/templates/mariadb/labsdb-replica.my.cnf.erb
index 21a44b3..63c744e 100644
--- a/templates/mariadb/labsdb-replica.my.cnf.erb
+++ b/templates/mariadb/labsdb-replica.my.cnf.erb
@@ -25,11 +25,16 @@
 port   = 3306
 datadir= <%= @datadir %>
 tmpdir = <%= @tmpdir %>
-# needed for multisource replication + GTID.
-gtid_domain_id = <%= @server_id %>
 server_id  = <%= @server_id %>
 read_only  = 0
 
+# gtid_domain_id flag is needed for multisource replication and GTID.
+# Strictly it is only needed on masters or servers that can potentially be
+# masters but for consistency it should be set in all of them.
+# https://mariadb.com/kb/en/mariadb/gtid/
+
+gtid_domain_id  = <%= @gtid_domain_id %>
+
 # enable socket authentication
 plugin-load = unix_socket=auth_socket.so
 

-- 
To view, visit https://gerrit.wikimedia.org/r/335817
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I721f29f0a10bd075423ea26094955b9f617b6d17
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Marostegui 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits