[MediaWiki-commits] [Gerrit] operations/puppet[production]: nagios_common: Fix optional parameter listed before required...

[Dzahn (Code Review)]

Dzahn has submitted this change and it was merged.

Change subject: nagios_common: Fix optional parameter listed before required 
parameter
..


nagios_common: Fix optional parameter listed before required parameter

Bug: T93645
Change-Id: I2b02c493f303ff2000e609635be660ce1e5257bf
---
M modules/nagios_common/manifests/contactgroups.pp
1 file changed, 5 insertions(+), 4 deletions(-)

Approvals:
  Hashar: Looks good to me, but someone else must approve
  Dzahn: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/nagios_common/manifests/contactgroups.pp 
b/modules/nagios_common/manifests/contactgroups.pp
index accaf3c..e0bd9db 100644
--- a/modules/nagios_common/manifests/contactgroups.pp
+++ b/modules/nagios_common/manifests/contactgroups.pp
@@ -2,6 +2,10 @@
 #
 # Sets up appropriate contacts for notifications
 #
+# [*source*]
+#   Allows to input a prewritten file as a source.  Overrides "content" if
+#   defined, but "content" is used if this is undefined.
+#
 # [*ensure*]
 #   present or absent, to make the definition
 #   present or absent. Defaults to present
@@ -21,16 +25,13 @@
 # [*contacts*]
 #   The list of contacts to include in the configuration.
 #
-# [*source*]
-#   Allows to input a prewritten file as a source.  Overrides "content" if
-#   defined, but "content" is used if this is undefined.
 # [*content*]
 #   Allows to input the data as a content string.  The default is
 #   template('nagios_common/contacts.cfg.erb')
 #
 class nagios_common::contactgroups(
-$ensure = present,
 $source,
+$ensure = present,
 $config_dir = '/etc/icinga',
 $owner = 'icinga',
 $group = 'icinga',

-- 
To view, visit https://gerrit.wikimedia.org/r/308344
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2b02c493f303ff2000e609635be660ce1e5257bf
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Paladox 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: nagios_common: Fix optional parameter listed before required...

[Paladox (Code Review)]

Paladox has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/308344

Change subject: nagios_common: Fix optional parameter listed before required 
parameter
..

nagios_common: Fix optional parameter listed before required parameter

Bug: T93645
Change-Id: I2b02c493f303ff2000e609635be660ce1e5257bf
---
0 files changed, 0 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/44/308344/1


-- 
To view, visit https://gerrit.wikimedia.org/r/308344
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2b02c493f303ff2000e609635be660ce1e5257bf
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Paladox 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits