[MediaWiki-commits] [Gerrit] operations/puppet[production]: pentest::tools: add missing system::role
Dzahn has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/397731 ) Change subject: pentest::tools: add missing system::role .. pentest::tools: add missing system::role Not having system::role in a role class is a style violation noticed by jenkins-bot. Change-Id: I4a2c325787ae723c6a36c25265bf3a6347ca1c4e --- M modules/role/manifests/pentest/tools.pp 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: jenkins-bot: Verified Dzahn: Looks good to me, approved diff --git a/modules/role/manifests/pentest/tools.pp b/modules/role/manifests/pentest/tools.pp index 319abe6..249484d 100644 --- a/modules/role/manifests/pentest/tools.pp +++ b/modules/role/manifests/pentest/tools.pp @@ -1,6 +1,10 @@ # T118763 class role::pentest::tools { +system::role { 'pentest::tools': +description => 'VM for use in penetration testing', +} + require_package('nmap') } -- To view, visit https://gerrit.wikimedia.org/r/397731 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a2c325787ae723c6a36c25265bf3a6347ca1c4e Gerrit-PatchSet: 4 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: DzahnGerrit-Reviewer: Dzahn Gerrit-Reviewer: Giuseppe Lavagetto Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] operations/puppet[production]: pentest::tools: add missing system::role
Dzahn has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397731 ) Change subject: pentest::tools: add missing system::role .. pentest::tools: add missing system::role Change-Id: I4a2c325787ae723c6a36c25265bf3a6347ca1c4e --- M modules/role/manifests/pentest/tools.pp 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/31/397731/1 diff --git a/modules/role/manifests/pentest/tools.pp b/modules/role/manifests/pentest/tools.pp index 319abe6..fe5fb1b 100644 --- a/modules/role/manifests/pentest/tools.pp +++ b/modules/role/manifests/pentest/tools.pp @@ -1,5 +1,9 @@ # T118763 class role::pentest::tools { + +system::role { 'pentest::tools': +description => 'VM for use in penetration testing', +} require_package('nmap') -- To view, visit https://gerrit.wikimedia.org/r/397731 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4a2c325787ae723c6a36c25265bf3a6347ca1c4e Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Dzahn___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits