[MediaWiki-commits] [Gerrit] operations/puppet[production]: redis::instance: use specific aof/rdb file names by default
Giuseppe Lavagetto has submitted this change and it was merged. Change subject: redis::instance: use specific aof/rdb file names by default .. redis::instance: use specific aof/rdb file names by default There is no point, and would be harmful, not to have a default per-instance aof/rdb file, as the common files are declaring a common value for it. Bug: T134400 Change-Id: I5f2e00bed5a0d38f05302d4f64812642e782deae --- M modules/redis/manifests/instance.pp 1 file changed, 8 insertions(+), 5 deletions(-) Approvals: Giuseppe Lavagetto: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/redis/manifests/instance.pp b/modules/redis/manifests/instance.pp index 71f2e28..1f6a4f4 100644 --- a/modules/redis/manifests/instance.pp +++ b/modules/redis/manifests/instance.pp @@ -63,12 +63,15 @@ fail('redis::instance title must be a TCP port or absolute path to UNIX socket.') } +$dbname = "${::hostname}-${title}" $defaults = { -pidfile=> "/var/lib/redis/${instance_name}.pid", -logfile=> "/var/log/redis/${instance_name}.log", -port => $port, -unixsocket => $unixsocket, -daemonize => true, +pidfile=> "/var/lib/redis/${instance_name}.pid", +logfile=> "/var/log/redis/${instance_name}.log", +port => $port, +unixsocket => $unixsocket, +daemonize => true, +appendfilename => "${dbname}.aof", +dbfilename => "${dbname}.rdb", } -- To view, visit https://gerrit.wikimedia.org/r/301789 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f2e00bed5a0d38f05302d4f64812642e782deae Gerrit-PatchSet: 3 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Giuseppe Lavagetto Gerrit-Reviewer: Giuseppe Lavagetto Gerrit-Reviewer: Ori.livneh Gerrit-Reviewer: jenkins-bot <> ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] operations/puppet[production]: redis::instance: use specific aof/rdb file names by default
Giuseppe Lavagetto has uploaded a new change for review. https://gerrit.wikimedia.org/r/301789 Change subject: redis::instance: use specific aof/rdb file names by default .. redis::instance: use specific aof/rdb file names by default There is no point, and would be harmful, not to have a default per-instance aof/rdb file, as the common files are declaring a common value for it. Bug: T134400 Change-Id: I5f2e00bed5a0d38f05302d4f64812642e782deae --- M modules/redis/manifests/instance.pp 1 file changed, 7 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/89/301789/1 diff --git a/modules/redis/manifests/instance.pp b/modules/redis/manifests/instance.pp index 71f2e28..11bd978 100644 --- a/modules/redis/manifests/instance.pp +++ b/modules/redis/manifests/instance.pp @@ -64,11 +64,13 @@ } $defaults = { -pidfile=> "/var/lib/redis/${instance_name}.pid", -logfile=> "/var/log/redis/${instance_name}.log", -port => $port, -unixsocket => $unixsocket, -daemonize => true, +pidfile=> "/var/lib/redis/${instance_name}.pid", +logfile=> "/var/log/redis/${instance_name}.log", +port => $port, +unixsocket => $unixsocket, +daemonize => true, +appendfilename => "${instance_name}.aof", +dbfilename => "${instance_name}.rdb", } -- To view, visit https://gerrit.wikimedia.org/r/301789 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5f2e00bed5a0d38f05302d4f64812642e782deae Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Giuseppe Lavagetto ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits