[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove beta::deployaccess

2016-11-23 Thread Dzahn (Code Review) 
Dzahn has submitted this change and it was merged.

Change subject: Remove beta::deployaccess
..


Remove beta::deployaccess

Seems unused, appears to have been a duplicate of role::beta::mediawiki, just
with a lower priority and deploy-service as well as mwdeploy.

Bug: T86644
Change-Id: Ida19797ed9893bdf785b2707b8179a1a67e7677a
---
D modules/beta/manifests/deployaccess.pp
1 file changed, 0 insertions(+), 9 deletions(-)

Approvals:
  Thcipriani: Looks good to me, but someone else must approve
  Hashar: Looks good to me, but someone else must approve
  Dzahn: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/beta/manifests/deployaccess.pp 
b/modules/beta/manifests/deployaccess.pp
deleted file mode 100644
index 3c7da66..000
--- a/modules/beta/manifests/deployaccess.pp
+++ /dev/null
@@ -1,9 +0,0 @@
-# TODO: remove this if https://phabricator.wikimedia.org/T121721
-# is fixed.
-class beta::deployaccess {
-$ips = 
join($network::constants::special_hosts[$::realm]['deployment_hosts'], ' ')
-security::access::config { 'beta-allow-mwdeploy':
-content  => "+ : deploy-service mwdeploy : ${ips}\n",
-priority => 50,
-}
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/322407
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ida19797ed9893bdf785b2707b8179a1a67e7677a
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alex Monk 
Gerrit-Reviewer: 20after4 
Gerrit-Reviewer: Alex Monk 
Gerrit-Reviewer: Dzahn 
Gerrit-Reviewer: Filippo Giunchedi 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: Thcipriani 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove beta::deployaccess as it's no longer needed.

2016-10-03 Thread Andrew Bogott (Code Review) 
Andrew Bogott has submitted this change and it was merged.

Change subject: Remove beta::deployaccess as it's no longer needed.
..


Remove beta::deployaccess as it's no longer needed.

Bug: T121721
Bug: T147233
Change-Id: I82a9d1bb44122df37ad403da20d3bcd260ebca0f
---
D modules/beta/manifests/deployaccess.pp
1 file changed, 0 insertions(+), 12 deletions(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  20after4: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/modules/beta/manifests/deployaccess.pp 
b/modules/beta/manifests/deployaccess.pp
deleted file mode 100644
index 754412b..000
--- a/modules/beta/manifests/deployaccess.pp
+++ /dev/null
@@ -1,12 +0,0 @@
-# TODO: remove this if https://phabricator.wikimedia.org/T121721
-# is fixed.
-class beta::deployaccess(
-$bastion_ip = '10.68.20.135', # ip of deployment-mira
-) {
-
-security::access::config { 'beta-allow-mwdeploy':
-content  => "+ : deploy-service mwdeploy : ${bastion_ip}\n",
-priority => 50,
-}
-
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/313903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I82a9d1bb44122df37ad403da20d3bcd260ebca0f
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 
Gerrit-Reviewer: 20after4 
Gerrit-Reviewer: Andrew Bogott 
Gerrit-Reviewer: Hashar 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove beta::deployaccess as it's no longer needed.

2016-10-03 Thread Andrew Bogott (Code Review) 
Andrew Bogott has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/313903

Change subject: Remove beta::deployaccess as it's no longer needed.
..

Remove beta::deployaccess as it's no longer needed.

Bug: T121721
Bug: T147233
Change-Id: I82a9d1bb44122df37ad403da20d3bcd260ebca0f
---
D modules/beta/manifests/deployaccess.pp
1 file changed, 0 insertions(+), 12 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/03/313903/1

diff --git a/modules/beta/manifests/deployaccess.pp 
b/modules/beta/manifests/deployaccess.pp
deleted file mode 100644
index 754412b..000
--- a/modules/beta/manifests/deployaccess.pp
+++ /dev/null
@@ -1,12 +0,0 @@
-# TODO: remove this if https://phabricator.wikimedia.org/T121721
-# is fixed.
-class beta::deployaccess(
-$bastion_ip = '10.68.20.135', # ip of deployment-mira
-) {
-
-security::access::config { 'beta-allow-mwdeploy':
-content  => "+ : deploy-service mwdeploy : ${bastion_ip}\n",
-priority => 50,
-}
-
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/313903
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I82a9d1bb44122df37ad403da20d3bcd260ebca0f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits