[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove old wikistats cron script causing cron-spam

2016-10-11 Thread Elukey (Code Review)
Elukey has submitted this change and it was merged.

Change subject: Remove old wikistats cron script causing cron-spam
..


Remove old wikistats cron script causing cron-spam

After a chat with Erik Zachte it was decided to deprecate this cron
script since not useful anymore. It is also causing regular cronspam
to root@ for various failures.

Bug: T145606
Change-Id: Ib73a14a2f1d8bd376208c4ca0e7f646b1f9056fd
---
M manifests/role/statistics.pp
D modules/statistics/manifests/wikistats.pp
2 files changed, 0 insertions(+), 36 deletions(-)

Approvals:
  Elukey: Looks good to me, approved
  Ottomata: Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/manifests/role/statistics.pp b/manifests/role/statistics.pp
index 39bfbf9..dfb7611 100644
--- a/manifests/role/statistics.pp
+++ b/manifests/role/statistics.pp
@@ -120,10 +120,6 @@
 # include stuff common to statistics compute nodes
 include ::statistics::compute
 
-# wikistats code is run here to
-# generate stats.wikimedia.org data
-include ::statistics::wikistats
-
 # rsync webrequest logs from logging hosts
 include ::statistics::rsync::webrequest
 
diff --git a/modules/statistics/manifests/wikistats.pp 
b/modules/statistics/manifests/wikistats.pp
deleted file mode 100644
index 5146e7d..000
--- a/modules/statistics/manifests/wikistats.pp
+++ /dev/null
@@ -1,32 +0,0 @@
-# == Class statistics::wikistats
-# wikistats configuration for generating
-# stats.wikimedia.org data.
-#
-# TODO: puppetize clone of wikistats?
-class statistics::wikistats {
-Class['::statistics'] -> Class['::statistics::wikistats']
-
-# Perl packages needed for wikistats
-package { [
-'libjson-xs-perl',
-'libtemplate-perl',
-'libnet-patricia-perl',
-'libregexp-assemble-perl',
-]:
-ensure => 'installed',
-}
-# this cron uses pigz to unzip squid archive files in parallel
-package { 'pigz':
-ensure => 'installed',
-}
-
-# generates the new mobile pageviews report
-# and syncs the file PageViewsPerMonthAll.csv to stat1002
-cron { 'new mobile pageviews report':
-command  => "/bin/bash 
${::statistics::working_path}/wikistats_git/pageviews_reports/bin/stat1-cron-script.sh",
-user => 'stats',
-monthday => 1,
-hour => 7,
-minute   => 20,
-}
-}

-- 
To view, visit https://gerrit.wikimedia.org/r/315101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib73a14a2f1d8bd376208c4ca0e7f646b1f9056fd
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Elukey 
Gerrit-Reviewer: Elukey 
Gerrit-Reviewer: Muehlenhoff 
Gerrit-Reviewer: Ottomata 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits


[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove old wikistats cron script causing cron-spam

2016-10-10 Thread Elukey (Code Review)
Elukey has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/315101

Change subject: Remove old wikistats cron script causing cron-spam
..

Remove old wikistats cron script causing cron-spam

After a chat with Erik Zachte it was decided to deprecate this cron
script since not useful anymore. It is also causing regular cronspam
to root@ for various failures.

Bug: T145606
Change-Id: Ib73a14a2f1d8bd376208c4ca0e7f646b1f9056fd
---
M modules/statistics/manifests/wikistats.pp
1 file changed, 0 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/01/315101/1

diff --git a/modules/statistics/manifests/wikistats.pp 
b/modules/statistics/manifests/wikistats.pp
index 5146e7d..b026068 100644
--- a/modules/statistics/manifests/wikistats.pp
+++ b/modules/statistics/manifests/wikistats.pp
@@ -19,14 +19,4 @@
 package { 'pigz':
 ensure => 'installed',
 }
-
-# generates the new mobile pageviews report
-# and syncs the file PageViewsPerMonthAll.csv to stat1002
-cron { 'new mobile pageviews report':
-command  => "/bin/bash 
${::statistics::working_path}/wikistats_git/pageviews_reports/bin/stat1-cron-script.sh",
-user => 'stats',
-monthday => 1,
-hour => 7,
-minute   => 20,
-}
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/315101
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib73a14a2f1d8bd376208c4ca0e7f646b1f9056fd
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Elukey 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits