[MediaWiki-commits] [Gerrit] operations/puppet[production]: Scap: canaries should include INFO-level messages
Filippo Giunchedi has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/348475 )
Change subject: Scap: canaries should include INFO-level messages
..
Scap: canaries should include INFO-level messages
One of the more common problems when deploying patches to
mediawiki-config is various config-file variables. It's easy for a
deployer to misjudge the order in which to apply patches and cause
problems. This patch will ensure that deployments that cause
error-spikes due to missing variables will be caught before being rolled
out to all of production.
Bug: T162974
Change-Id: I450025538c8cbb0d543c082a5c480820661b2103
---
M modules/service/files/logstash_checker.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Krinkle: Looks good to me, but someone else must approve
jenkins-bot: Verified
Filippo Giunchedi: Looks good to me, approved
diff --git a/modules/service/files/logstash_checker.py
b/modules/service/files/logstash_checker.py
index 3876e1b..e3eea54 100755
--- a/modules/service/files/logstash_checker.py
+++ b/modules/service/files/logstash_checker.py
@@ -116,7 +116,8 @@
"""Return a query that tracks MediaWiki deploy problems."""
query = ('host:("%(host)s") '
'AND ((type:mediawiki '
- 'AND channel:exception) '
+ 'AND (channel:exception '
+ 'OR channel:error)) '
'OR type:hhvm)') % vars(self)
return {"aggs": {
@@ -144,8 +145,7 @@
{"terms": {
"level": [
"INFO",
-"NOTICE",
-"WARNING"
+"DEBUG"
]
}}, {
"query": {
--
To view, visit https://gerrit.wikimedia.org/r/348475
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I450025538c8cbb0d543c082a5c480820661b2103
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Thcipriani
Gerrit-Reviewer: Catrope
Gerrit-Reviewer: Chad
Gerrit-Reviewer: Filippo Giunchedi
Gerrit-Reviewer: Giuseppe Lavagetto
Gerrit-Reviewer: Krinkle
Gerrit-Reviewer: Mobrovac
Gerrit-Reviewer: Volans
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] operations/puppet[production]: Scap: canaries should include INFO-level messages
Thcipriani has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/348475 )
Change subject: Scap: canaries should include INFO-level messages
..
Scap: canaries should include INFO-level messages
One of the more common problems when deploying patches to
mediawiki-config is various config-file variables. It's easy for a
deployer to misjudge the order in which to apply patches and cause
problems. This patch will ensure that deployments that cause
error-spikes due to missing variables will be caught before being rolled
out to all of production.
Bug: T162974
Change-Id: I450025538c8cbb0d543c082a5c480820661b2103
---
M modules/service/files/logstash_checker.py
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/75/348475/1
diff --git a/modules/service/files/logstash_checker.py
b/modules/service/files/logstash_checker.py
index 3876e1b..e3eea54 100755
--- a/modules/service/files/logstash_checker.py
+++ b/modules/service/files/logstash_checker.py
@@ -116,7 +116,8 @@
"""Return a query that tracks MediaWiki deploy problems."""
query = ('host:("%(host)s") '
'AND ((type:mediawiki '
- 'AND channel:exception) '
+ 'AND (channel:exception '
+ 'OR channel:error)) '
'OR type:hhvm)') % vars(self)
return {"aggs": {
@@ -144,8 +145,7 @@
{"terms": {
"level": [
"INFO",
-"NOTICE",
-"WARNING"
+"DEBUG"
]
}}, {
"query": {
--
To view, visit https://gerrit.wikimedia.org/r/348475
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I450025538c8cbb0d543c082a5c480820661b2103
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Thcipriani
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
