[MediaWiki-commits] [Gerrit] operations/puppet[production]: etcd: use logrotate::conf for logrotate

2017-05-10 Thread Alexandros Kosiaris (Code Review) 
Alexandros Kosiaris has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/352994 )

Change subject: etcd: use logrotate::conf for logrotate
..


etcd: use logrotate::conf for logrotate

Change-Id: I6765e7e970347b211fae5bc20bbc3af7c293f724
---
M modules/etcd/manifests/logging.pp
1 file changed, 2 insertions(+), 5 deletions(-)

Approvals:
  Alexandros Kosiaris: Verified; Looks good to me, approved



diff --git a/modules/etcd/manifests/logging.pp 
b/modules/etcd/manifests/logging.pp
index afe7c0a..d77f29b 100644
--- a/modules/etcd/manifests/logging.pp
+++ b/modules/etcd/manifests/logging.pp
@@ -3,13 +3,10 @@
 # Manages all the logging logic for etcd.
 class etcd::logging {
 
-file { '/etc/logrotate.d/etcd':
+logrotate::conf { 'etcd':
+ensure => present,
 source => 'puppet:///modules/etcd/logrotate.conf',
-owner  => 'root',
-group  => 'root',
-mode   => '0444',
 }
-
 
 rsyslog::conf { 'etcd':
 source   => 'puppet:///modules/etcd/rsyslog.conf',

-- 
To view, visit https://gerrit.wikimedia.org/r/352994
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6765e7e970347b211fae5bc20bbc3af7c293f724
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Alexandros Kosiaris 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: etcd: use logrotate::conf for logrotate

2017-05-09 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/352994 )

Change subject: etcd: use logrotate::conf for logrotate
..

etcd: use logrotate::conf for logrotate

Change-Id: I6765e7e970347b211fae5bc20bbc3af7c293f724
---
M modules/etcd/manifests/logging.pp
1 file changed, 2 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/94/352994/1

diff --git a/modules/etcd/manifests/logging.pp 
b/modules/etcd/manifests/logging.pp
index afe7c0a..5528797 100644
--- a/modules/etcd/manifests/logging.pp
+++ b/modules/etcd/manifests/logging.pp
@@ -3,13 +3,10 @@
 # Manages all the logging logic for etcd.
 class etcd::logging {
 
-file { '/etc/logrotate.d/etcd':
+logrotate::conf { '/etc/logrotate.d/etcd':
+ensure => present,
 source => 'puppet:///modules/etcd/logrotate.conf',
-owner  => 'root',
-group  => 'root',
-mode   => '0444',
 }
-
 
 rsyslog::conf { 'etcd':
 source   => 'puppet:///modules/etcd/rsyslog.conf',

-- 
To view, visit https://gerrit.wikimedia.org/r/352994
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6765e7e970347b211fae5bc20bbc3af7c293f724
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: etcd: use logrotate::conf for logrotate

2017-05-09 Thread Alexandros Kosiaris (Code Review) 
Alexandros Kosiaris has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/352637 )

Change subject: etcd: use logrotate::conf for logrotate
..


etcd: use logrotate::conf for logrotate

Change-Id: Ic2a85a3bbda48a5767bf1aaa2793f458352489ba
---
M modules/etcd/manifests/logging.pp
1 file changed, 2 insertions(+), 5 deletions(-)

Approvals:
  Alexandros Kosiaris: Verified; Looks good to me, approved



diff --git a/modules/etcd/manifests/logging.pp 
b/modules/etcd/manifests/logging.pp
index afe7c0a..9827d43 100644
--- a/modules/etcd/manifests/logging.pp
+++ b/modules/etcd/manifests/logging.pp
@@ -3,13 +3,10 @@
 # Manages all the logging logic for etcd.
 class etcd::logging {
 
-file { '/etc/logrotate.d/etcd':
+logrotate::conf { '/etcd':
+ensure => present,
 source => 'puppet:///modules/etcd/logrotate.conf',
-owner  => 'root',
-group  => 'root',
-mode   => '0444',
 }
-
 
 rsyslog::conf { 'etcd':
 source   => 'puppet:///modules/etcd/rsyslog.conf',

-- 
To view, visit https://gerrit.wikimedia.org/r/352637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2a85a3bbda48a5767bf1aaa2793f458352489ba
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 
Gerrit-Reviewer: Alexandros Kosiaris 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations/puppet[production]: etcd: use logrotate::conf for logrotate

2017-05-08 Thread Dzahn (Code Review) 
Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/352637 )

Change subject: etcd: use logrotate::conf for logrotate
..

etcd: use logrotate::conf for logrotate

Change-Id: Ic2a85a3bbda48a5767bf1aaa2793f458352489ba
---
M modules/etcd/manifests/logging.pp
1 file changed, 2 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/37/352637/1

diff --git a/modules/etcd/manifests/logging.pp 
b/modules/etcd/manifests/logging.pp
index afe7c0a..9827d43 100644
--- a/modules/etcd/manifests/logging.pp
+++ b/modules/etcd/manifests/logging.pp
@@ -3,13 +3,10 @@
 # Manages all the logging logic for etcd.
 class etcd::logging {
 
-file { '/etc/logrotate.d/etcd':
+logrotate::conf { '/etcd':
+ensure => present,
 source => 'puppet:///modules/etcd/logrotate.conf',
-owner  => 'root',
-group  => 'root',
-mode   => '0444',
 }
-
 
 rsyslog::conf { 'etcd':
 source   => 'puppet:///modules/etcd/rsyslog.conf',

-- 
To view, visit https://gerrit.wikimedia.org/r/352637
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2a85a3bbda48a5767bf1aaa2793f458352489ba
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits