[MediaWiki-commits] [Gerrit] operations...docker-pkg[master]: Restrict setup.py to python 3.4 or later

2017-12-13 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/397748 )

Change subject: Restrict setup.py to python 3.4 or later
..


Restrict setup.py to python 3.4 or later

The software is python3 only, though when installing with pip (python2)
there is nothing preventing the installation.  Installed that way,
docker-pkg fails to run.

Bails out early by checking the python version in setup.py

Change-Id: I4e29b1af7fbaa9cd96ede519401bc79c51a6fdb0
---
M setup.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Thcipriani: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/setup.py b/setup.py
index 6fd0d51..62e5f76 100755
--- a/setup.py
+++ b/setup.py
@@ -1,8 +1,11 @@
 #!/usr/bin/env python
 """Package configuration."""
 
+import sys
 from setuptools import find_packages, setup
 
+if sys.version_info < (3, 4):
+sys.exit('docker-pkg requires Python 3.4 or later')
 
 long_description = """
 docker-pkg-images builds docker images from templates.

-- 
To view, visit https://gerrit.wikimedia.org/r/397748
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4e29b1af7fbaa9cd96ede519401bc79c51a6fdb0
Gerrit-PatchSet: 4
Gerrit-Project: operations/docker-images/docker-pkg
Gerrit-Branch: master
Gerrit-Owner: Hashar 
Gerrit-Reviewer: Giuseppe Lavagetto 
Gerrit-Reviewer: Thcipriani 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] operations...docker-pkg[master]: Restrict setup.py to python 3.4 or later

2017-12-12 Thread Hashar (Code Review) 
Hashar has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/397748 )

Change subject: Restrict setup.py to python 3.4 or later
..

Restrict setup.py to python 3.4 or later

The software is python3 only, though when installing with pip (python2)
there is nothing preventing the installation.  Installed that way,
docker-pkg fails to run.

Bails out early by checking the python version in setup.py

Change-Id: I4e29b1af7fbaa9cd96ede519401bc79c51a6fdb0
---
M setup.py
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/docker-images/docker-pkg 
refs/changes/48/397748/1

diff --git a/setup.py b/setup.py
index 6fd0d51..62e5f76 100755
--- a/setup.py
+++ b/setup.py
@@ -1,8 +1,11 @@
 #!/usr/bin/env python
 """Package configuration."""
 
+import sys
 from setuptools import find_packages, setup
 
+if sys.version_info < (3, 4):
+sys.exit('docker-pkg requires Python 3.4 or later')
 
 long_description = """
 docker-pkg-images builds docker images from templates.

-- 
To view, visit https://gerrit.wikimedia.org/r/397748
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e29b1af7fbaa9cd96ede519401bc79c51a6fdb0
Gerrit-PatchSet: 1
Gerrit-Project: operations/docker-images/docker-pkg
Gerrit-Branch: master
Gerrit-Owner: Hashar 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits