[MediaWiki-commits] [Gerrit] package.json: Pin dependencies at a fixed version - change (mediawiki...citoid)
Krinkle has uploaded a new change for review.
https://gerrit.wikimedia.org/r/177486
Change subject: package.json: Pin dependencies at a fixed version
..
package.json: Pin dependencies at a fixed version
Upgrade explicitly to avoid silently upgrading to newer versions.
When an in compatibility is found and using 'latest' (or '*') it'll
be hard to track which version worked using e.g. git-bisect as
it'd get the latest still.
It also ensures that the dependencies are the same for different
developers with and without npm-cache locally.
Using a service like https://david-dm.org/wikimedia/citoid one
can quickly check if there are newer versions available.
Change-Id: I98cced5d5eeedbb7554103f449bbc2afa073327c
---
M package.json
1 file changed, 12 insertions(+), 12 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/citoid
refs/changes/86/177486/1
diff --git a/package.json b/package.json
index a007ada..f427361 100644
--- a/package.json
+++ b/package.json
@@ -1,19 +1,19 @@
{
name : citoid,
- description : Converts search terms such as URL or title into
citations,
version : 0.0.0,
+ description : Converts search terms such as URL or title into
citations.,
dependencies : {
- async : latest,
- bluebird : latest,
- body-parser : latest,
- bunyan : latest,
- cheerio : latest,
- express : latest,
- path: latest,
- request : latest,
- xmldom : latest,
- xpath : latest,
- yargs: latest
+ async : 0.9.0,
+ bluebird : 2.3.11,
+ body-parser : 1.10.0,
+ bunyan : 1.2.3,
+ cheerio : 0.18.0,
+ express : 4.10.4,
+ path: 0.4.9,
+ request : 2.49.0,
+ xmldom : 0.1.19,
+ xpath : 0.0.7,
+ yargs: 1.3.3
},
repository: {
type: git,
--
To view, visit https://gerrit.wikimedia.org/r/177486
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I98cced5d5eeedbb7554103f449bbc2afa073327c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/citoid
Gerrit-Branch: master
Gerrit-Owner: Krinkle krinklem...@gmail.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] package.json: Pin dependencies at a fixed version - change (mediawiki...citoid)
Krinkle has submitted this change and it was merged.
Change subject: package.json: Pin dependencies at a fixed version
..
package.json: Pin dependencies at a fixed version
Upgrade explicitly to avoid silently upgrading to newer versions.
When an in compatibility is found and using 'latest' (or '*') it'll
be hard to track which version worked using e.g. git-bisect as
it'd get the latest still.
It also ensures that the dependencies are the same for different
developers with and without npm-cache locally.
Using a service like https://david-dm.org/wikimedia/citoid one
can quickly check if there are newer versions available.
Change-Id: I98cced5d5eeedbb7554103f449bbc2afa073327c
---
M package.json
1 file changed, 12 insertions(+), 12 deletions(-)
Approvals:
Krinkle: Verified; Looks good to me, approved
diff --git a/package.json b/package.json
index a007ada..f427361 100644
--- a/package.json
+++ b/package.json
@@ -1,19 +1,19 @@
{
name : citoid,
- description : Converts search terms such as URL or title into
citations,
version : 0.0.0,
+ description : Converts search terms such as URL or title into
citations.,
dependencies : {
- async : latest,
- bluebird : latest,
- body-parser : latest,
- bunyan : latest,
- cheerio : latest,
- express : latest,
- path: latest,
- request : latest,
- xmldom : latest,
- xpath : latest,
- yargs: latest
+ async : 0.9.0,
+ bluebird : 2.3.11,
+ body-parser : 1.10.0,
+ bunyan : 1.2.3,
+ cheerio : 0.18.0,
+ express : 4.10.4,
+ path: 0.4.9,
+ request : 2.49.0,
+ xmldom : 0.1.19,
+ xpath : 0.0.7,
+ yargs: 1.3.3
},
repository: {
type: git,
--
To view, visit https://gerrit.wikimedia.org/r/177486
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I98cced5d5eeedbb7554103f449bbc2afa073327c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/citoid
Gerrit-Branch: master
Gerrit-Owner: Krinkle krinklem...@gmail.com
Gerrit-Reviewer: Krinkle krinklem...@gmail.com
Gerrit-Reviewer: Mvolz mv...@wikimedia.org
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
