[MediaWiki-commits] [Gerrit] page.py: fix docstring of getFileVersionHistory() - change (pywikibot/core)

2014-10-26 Thread Mpaa (Code Review) 
Mpaa has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/168909

Change subject: page.py: fix docstring of getFileVersionHistory()
..

page.py: fix docstring of getFileVersionHistory()

getFileVersionHistory() returns a list of dicts, not tuples.

Change-Id: I783ed237d691aedb44464a6e292d60ea778183b7
---
M pywikibot/page.py
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/pywikibot/core 
refs/changes/09/168909/1

diff --git a/pywikibot/page.py b/pywikibot/page.py
index 5a4994c..2fcbb8d 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -1915,8 +1915,10 @@
 def getFileVersionHistory(self):
 Return the file's version history.
 
-@return: An iterator yielding tuples containing (timestamp,
-username, resolution, filesize, comment).
+@return: A list of dictionaries with the following keys:
+[u'comment', u'sha1', u'url', u'timestamp', u'metadata',
+ u'height', u'width', u'mime', u'user', u'descriptionurl',
+ u'size']
 
 
 return self.site.loadimageinfo(self, history=True)

-- 
To view, visit https://gerrit.wikimedia.org/r/168909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I783ed237d691aedb44464a6e292d60ea778183b7
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa mpaa.w...@gmail.com

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] page.py: fix docstring of getFileVersionHistory() - change (pywikibot/core)

2014-10-26 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: page.py: fix docstring of getFileVersionHistory()
..


page.py: fix docstring of getFileVersionHistory()

getFileVersionHistory() returns a list of dicts, not tuples.

Change-Id: I783ed237d691aedb44464a6e292d60ea778183b7
---
M pywikibot/page.py
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
  XZise: Looks good to me, approved
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/pywikibot/page.py b/pywikibot/page.py
index 5a4994c..54c3ff0 100644
--- a/pywikibot/page.py
+++ b/pywikibot/page.py
@@ -1915,8 +1915,9 @@
 def getFileVersionHistory(self):
 Return the file's version history.
 
-@return: An iterator yielding tuples containing (timestamp,
-username, resolution, filesize, comment).
+@return: A list of dictionaries with the following keys:
+[comment, sha1, url, timestamp, metadata,
+ height, width, mime, user, descriptionurl, size]
 
 
 return self.site.loadimageinfo(self, history=True)

-- 
To view, visit https://gerrit.wikimedia.org/r/168909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I783ed237d691aedb44464a6e292d60ea778183b7
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa mpaa.w...@gmail.com
Gerrit-Reviewer: John Vandenberg jay...@gmail.com
Gerrit-Reviewer: Ladsgroup ladsgr...@gmail.com
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: Merlijn van Deen valhall...@arctus.nl
Gerrit-Reviewer: Ricordisamoa ricordisa...@openmailbox.org
Gerrit-Reviewer: XZise commodorefabia...@gmx.de
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits