[MediaWiki-commits] [Gerrit] removes setProject from ProjectBoardTaskCard init Bug: T125892 - change (phabricator...Sprint)

2016-02-04 Thread Christopher Johnson (WMDE) (Code Review) 
Christopher Johnson (WMDE) has submitted this change and it was merged.

Change subject: removes setProject from ProjectBoardTaskCard init Bug: T125892
..


removes setProject from ProjectBoardTaskCard init
Bug: T125892

Change-Id: I77079aa4594a5b0c48ebcba8ebbc3b2a6063d2bf
---
M src/controller/board/SprintBoardMoveController.php
M src/controller/board/SprintBoardViewController.php
2 files changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Christopher Johnson (WMDE): Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/src/controller/board/SprintBoardMoveController.php 
b/src/controller/board/SprintBoardMoveController.php
index 49eb609..2f7403c 100644
--- a/src/controller/board/SprintBoardMoveController.php
+++ b/src/controller/board/SprintBoardMoveController.php
@@ -229,7 +229,6 @@
   ->setProjectHandles($project_handles)
   ->setOwner($owner)
   ->setCanEdit(true)
-  ->setProject($project)
   ->getItem();
 }
 $card->addClass('phui-workcard');
diff --git a/src/controller/board/SprintBoardViewController.php 
b/src/controller/board/SprintBoardViewController.php
index ed8dd23..694e73c 100755
--- a/src/controller/board/SprintBoardViewController.php
+++ b/src/controller/board/SprintBoardViewController.php
@@ -356,7 +356,6 @@
 } else {
   $cards->addItem(id(new ProjectBoardTaskCard())
   ->setViewer($viewer)
-  ->setProject($project)
   ->setProjectHandles($handles)
   ->setTask($task)
   ->setOwner($owner)

-- 
To view, visit https://gerrit.wikimedia.org/r/268565
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I77079aa4594a5b0c48ebcba8ebbc3b2a6063d2bf
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) 
Gerrit-Reviewer: Christopher Johnson (WMDE) 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] removes setProject from ProjectBoardTaskCard init Bug: T125892 - change (phabricator...Sprint)

2016-02-04 Thread Christopher Johnson (WMDE) (Code Review) 
Christopher Johnson (WMDE) has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/268565

Change subject: removes setProject from ProjectBoardTaskCard init Bug: T125892
..

removes setProject from ProjectBoardTaskCard init
Bug: T125892

Change-Id: I77079aa4594a5b0c48ebcba8ebbc3b2a6063d2bf
---
M src/controller/board/SprintBoardMoveController.php
M src/controller/board/SprintBoardViewController.php
2 files changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/phabricator/extensions/Sprint 
refs/changes/65/268565/1

diff --git a/src/controller/board/SprintBoardMoveController.php 
b/src/controller/board/SprintBoardMoveController.php
index 49eb609..2f7403c 100644
--- a/src/controller/board/SprintBoardMoveController.php
+++ b/src/controller/board/SprintBoardMoveController.php
@@ -229,7 +229,6 @@
   ->setProjectHandles($project_handles)
   ->setOwner($owner)
   ->setCanEdit(true)
-  ->setProject($project)
   ->getItem();
 }
 $card->addClass('phui-workcard');
diff --git a/src/controller/board/SprintBoardViewController.php 
b/src/controller/board/SprintBoardViewController.php
index ed8dd23..694e73c 100755
--- a/src/controller/board/SprintBoardViewController.php
+++ b/src/controller/board/SprintBoardViewController.php
@@ -356,7 +356,6 @@
 } else {
   $cards->addItem(id(new ProjectBoardTaskCard())
   ->setViewer($viewer)
-  ->setProject($project)
   ->setProjectHandles($handles)
   ->setTask($task)
   ->setOwner($owner)

-- 
To view, visit https://gerrit.wikimedia.org/r/268565
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I77079aa4594a5b0c48ebcba8ebbc3b2a6063d2bf
Gerrit-PatchSet: 1
Gerrit-Project: phabricator/extensions/Sprint
Gerrit-Branch: master
Gerrit-Owner: Christopher Johnson (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits