[MediaWiki-commits] [Gerrit] scale language row height w/ device - change (apps...wikipedia)

2015-06-24 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: scale language row height w/ device
..


scale language row height w/ device

Fixes text being cropped on iPad. [0]

0: https://phabricator.wikimedia.org/T97780#1393885

Bug: T97780
Change-Id: I56257700c474a02f3dbd64cfa48f08d98f70d524
---
M Wikipedia/Base.lproj/Main_iPhone.storyboard
M Wikipedia/View Controllers/Languages/LanguagesViewController.m
M Wikipedia/View Controllers/WebView/WebViewController.m
3 files changed, 9 insertions(+), 9 deletions(-)

Approvals:
  Fjalapeno: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Wikipedia/Base.lproj/Main_iPhone.storyboard 
b/Wikipedia/Base.lproj/Main_iPhone.storyboard
index 08c087c..8c34dfc 100644
--- a/Wikipedia/Base.lproj/Main_iPhone.storyboard
+++ b/Wikipedia/Base.lproj/Main_iPhone.storyboard
@@ -1,5 +1,5 @@
 
-
+
 
 
 
@@ -1878,7 +1878,7 @@
 
 
 
-
+
 
 
 
@@ -1891,7 +1891,7 @@
 
 
 
-
+
 
 
 
@@ -1904,7 +1904,7 @@
 
 
 
-
+
 
 
 
@@ -1918,7 +1918,7 @@
 
 
 
-
+
 
 
 
@@ -1931,7 +1931,7 @@
 
 
 
-
+
 
 
 
diff --git a/Wikipedia/View Controllers/Languages/LanguagesViewController.m 
b/Wikipedia/View Controllers/Languages/LanguagesViewController.m
index c0e5e3c..21f577e 100644
--- a/Wikipedia/View Controllers/Languages/LanguagesViewController.m
+++ b/Wikipedia/View Controllers/Languages/LanguagesViewController.m
@@ -236,9 +236,9 @@
 #endif
 - (CGFloat)tableView:(UITableView*)tableView 
heightForRowAtIndexPath:(NSIndexPath*)indexPath {
 if (PreferredLanguagesSection == indexPath.section) {
-return PreferredLanguageRowHeight;
+return PreferredLanguageRowHeight * MENUS_SCALE_MULTIPLIER;
 } else {
-return OtherLanguageRowHeight;
+return OtherLanguageRowHeight * MENUS_SCALE_MULTIPLIER;
 }
 }
 
diff --git a/Wikipedia/View Controllers/WebView/WebViewController.m 
b/Wikipedia/View Controllers/WebView/WebViewController.m
index b66e1aa..e03e9ef 100644
--- a/Wikipedia/View Controllers/WebView/WebViewController.m
+++ b/Wikipedia/View Controllers/WebView/WebViewController.m
@@ -63,7 +63,7 @@
 [self setupTrackingFooter];
 
 self.bottomNavHeightConstraint.constant = CHROME_MENUS_HEIGHT;
-
+
 self.webView.scrollView.decelerationRate = 
UIScrollViewDecelerationRateNormal;
 
 self.scrollingToTop = NO;

-- 
To view, visit https://gerrit.wikimedia.org/r/220609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I56257700c474a02f3dbd64cfa48f08d98f70d524
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Bgerstle 
Gerrit-Reviewer: Fjalapeno 
Gerrit-Reviewer: Mhurd 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] scale language row height w/ device - change (apps...wikipedia)

2015-06-24 Thread Bgerstle (Code Review) 
Bgerstle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/220609

Change subject: scale language row height w/ device
..

scale language row height w/ device

Fixes text being cropped on iPad. [0]

0: https://phabricator.wikimedia.org/T97780#1393885

Bug: T97780
Change-Id: I56257700c474a02f3dbd64cfa48f08d98f70d524
---
M Wikipedia/Base.lproj/Main_iPhone.storyboard
M Wikipedia/View Controllers/Languages/LanguagesViewController.m
M Wikipedia/View Controllers/WebView/WebViewController.m
3 files changed, 9 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/ios/wikipedia 
refs/changes/09/220609/1

diff --git a/Wikipedia/Base.lproj/Main_iPhone.storyboard 
b/Wikipedia/Base.lproj/Main_iPhone.storyboard
index 08c087c..8c34dfc 100644
--- a/Wikipedia/Base.lproj/Main_iPhone.storyboard
+++ b/Wikipedia/Base.lproj/Main_iPhone.storyboard
@@ -1,5 +1,5 @@
 
-
+
 
 
 
@@ -1878,7 +1878,7 @@
 
 
 
-
+
 
 
 
@@ -1891,7 +1891,7 @@
 
 
 
-
+
 
 
 
@@ -1904,7 +1904,7 @@
 
 
 
-
+
 
 
 
@@ -1918,7 +1918,7 @@
 
 
 
-
+
 
 
 
@@ -1931,7 +1931,7 @@
 
 
 
-
+
 
 
 
diff --git a/Wikipedia/View Controllers/Languages/LanguagesViewController.m 
b/Wikipedia/View Controllers/Languages/LanguagesViewController.m
index c0e5e3c..21f577e 100644
--- a/Wikipedia/View Controllers/Languages/LanguagesViewController.m
+++ b/Wikipedia/View Controllers/Languages/LanguagesViewController.m
@@ -236,9 +236,9 @@
 #endif
 - (CGFloat)tableView:(UITableView*)tableView 
heightForRowAtIndexPath:(NSIndexPath*)indexPath {
 if (PreferredLanguagesSection == indexPath.section) {
-return PreferredLanguageRowHeight;
+return PreferredLanguageRowHeight * MENUS_SCALE_MULTIPLIER;
 } else {
-return OtherLanguageRowHeight;
+return OtherLanguageRowHeight * MENUS_SCALE_MULTIPLIER;
 }
 }
 
diff --git a/Wikipedia/View Controllers/WebView/WebViewController.m 
b/Wikipedia/View Controllers/WebView/WebViewController.m
index b66e1aa..e03e9ef 100644
--- a/Wikipedia/View Controllers/WebView/WebViewController.m
+++ b/Wikipedia/View Controllers/WebView/WebViewController.m
@@ -63,7 +63,7 @@
 [self setupTrackingFooter];
 
 self.bottomNavHeightConstraint.constant = CHROME_MENUS_HEIGHT;
-
+
 self.webView.scrollView.decelerationRate = 
UIScrollViewDecelerationRateNormal;
 
 self.scrollingToTop = NO;

-- 
To view, visit https://gerrit.wikimedia.org/r/220609
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I56257700c474a02f3dbd64cfa48f08d98f70d524
Gerrit-PatchSet: 1
Gerrit-Project: apps/ios/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Bgerstle 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits