[MediaWiki-commits] [Gerrit] static method should be declared with static - change (mediawiki...Echo)

2014-07-31 Thread Bsitu (Code Review) 
Bsitu has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/150904

Change subject: static method should be declared with static
..

static method should be declared with static

Change-Id: I855c09d950a44ae70b7d982e8c3e23b36dde1475
---
M includes/DataOutputFormatter.php
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo 
refs/changes/04/150904/1

diff --git a/includes/DataOutputFormatter.php b/includes/DataOutputFormatter.php
index 5224737..e3161e4 100644
--- a/includes/DataOutputFormatter.php
+++ b/includes/DataOutputFormatter.php
@@ -12,7 +12,7 @@
 * @param User|null the target user viewing the notification
 * @return array
 */
-   public function formatOutput( EchoNotification $notification, $format = 
false, User $user = null ) {
+   public static function formatOutput( EchoNotification $notification, 
$format = false, User $user = null ) {
$event = $notification-getEvent();
// Default to notification user if user is not specified
if ( !$user ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/150904
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I855c09d950a44ae70b7d982e8c3e23b36dde1475
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu bs...@wikimedia.org

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] static method should be declared with static - change (mediawiki...Echo)

2014-07-31 Thread jenkins-bot (Code Review) 
jenkins-bot has submitted this change and it was merged.

Change subject: static method should be declared with static
..


static method should be declared with static

Change-Id: I855c09d950a44ae70b7d982e8c3e23b36dde1475
---
M includes/DataOutputFormatter.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/DataOutputFormatter.php b/includes/DataOutputFormatter.php
index 5224737..e3161e4 100644
--- a/includes/DataOutputFormatter.php
+++ b/includes/DataOutputFormatter.php
@@ -12,7 +12,7 @@
 * @param User|null the target user viewing the notification
 * @return array
 */
-   public function formatOutput( EchoNotification $notification, $format = 
false, User $user = null ) {
+   public static function formatOutput( EchoNotification $notification, 
$format = false, User $user = null ) {
$event = $notification-getEvent();
// Default to notification user if user is not specified
if ( !$user ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/150904
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I855c09d950a44ae70b7d982e8c3e23b36dde1475
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Bsitu bs...@wikimedia.org
Gerrit-Reviewer: Legoktm legoktm.wikipe...@gmail.com
Gerrit-Reviewer: jenkins-bot 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits