[MediaWiki-commits] [Gerrit] wmflib: fix failing test - change (operations/puppet)
Giuseppe Lavagetto has submitted this change and it was merged.
Change subject: wmflib: fix failing test
..
wmflib: fix failing test
Change-Id: Icc9fe24f5ae90e59ec26714473b9f6a2ecefe7df
---
M modules/wmflib/spec/functions/role_spec.rb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Giuseppe Lavagetto: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/wmflib/spec/functions/role_spec.rb
b/modules/wmflib/spec/functions/role_spec.rb
index 26dd021..fd9a3b5 100644
--- a/modules/wmflib/spec/functions/role_spec.rb
+++ b/modules/wmflib/spec/functions/role_spec.rb
@@ -21,7 +21,7 @@
should run.and_raise_error(ArgumentError)
end
it "throws error if called outside of the node scope" do
-should run.with_params(['cache::text']).and_raise_error(Puppet::ParseError)
+should run.with_params('cache::text').and_raise_error(Puppet::ParseError)
end
it "throws error if called on a non-existing role" do
--
To view, visit https://gerrit.wikimedia.org/r/272682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc9fe24f5ae90e59ec26714473b9f6a2ecefe7df
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto
Gerrit-Reviewer: Giuseppe Lavagetto
Gerrit-Reviewer: jenkins-bot <>
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] wmflib: fix failing test - change (operations/puppet)
Giuseppe Lavagetto has uploaded a new change for review.
https://gerrit.wikimedia.org/r/272682
Change subject: wmflib: fix failing test
..
wmflib: fix failing test
Change-Id: Icc9fe24f5ae90e59ec26714473b9f6a2ecefe7df
---
M modules/wmflib/spec/functions/role_spec.rb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/82/272682/1
diff --git a/modules/wmflib/spec/functions/role_spec.rb
b/modules/wmflib/spec/functions/role_spec.rb
index 26dd021..fd9a3b5 100644
--- a/modules/wmflib/spec/functions/role_spec.rb
+++ b/modules/wmflib/spec/functions/role_spec.rb
@@ -21,7 +21,7 @@
should run.and_raise_error(ArgumentError)
end
it "throws error if called outside of the node scope" do
-should run.with_params(['cache::text']).and_raise_error(Puppet::ParseError)
+should run.with_params('cache::text').and_raise_error(Puppet::ParseError)
end
it "throws error if called on a non-existing role" do
--
To view, visit https://gerrit.wikimedia.org/r/272682
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc9fe24f5ae90e59ec26714473b9f6a2ecefe7df
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added an ldap test. - change (operations/puppet)
Andrew Bogott has uploaded a new change for review.
https://gerrit.wikimedia.org/r/238216
Change subject: Added an ldap test.
..
Added an ldap test.
Bug: T107454
Change-Id: Ie2b29bd2d4e29d3a510e31623b78621b2cf60347
---
M modules/toollabs/files/toolschecker.py
1 file changed, 12 insertions(+), 9 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/16/238216/1
diff --git a/modules/toollabs/files/toolschecker.py
b/modules/toollabs/files/toolschecker.py
index 6633b66..2ea7098 100644
--- a/modules/toollabs/files/toolschecker.py
+++ b/modules/toollabs/files/toolschecker.py
@@ -1,4 +1,6 @@
import flask
+import ldap
+import ldapsupportlib
import os
import redis
import requests
@@ -45,15 +47,16 @@
return False
-@check('/labs-dns/private')
-def dns_private_check():
-# Verify that we can resolve our own address
-fqdn = socket.getfqdn()
-# This will throw an exception if it can't resolve:
-resolved = socket.gethostbyname_ex(fqdn)
-if len(resolved) == 3:
-if len(resolved[2]) > 0:
-return True
+@check('/ldap')
+def ldap_query_check():
+# Run a simple known query and verify that ldap returns something
+ldapConn = ldapsupportlib.LDAPSupportLib().connect()
+
+query = '(cn=testlabss)'
+base = 'ou=projects,dc=wikimedia,dc=org'
+result = ldapConn.search_s(base, ldap.SCOPE_SUBTREE, query)
+if len(result) >= 0:
+return True
return False
--
To view, visit https://gerrit.wikimedia.org/r/238216
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie2b29bd2d4e29d3a510e31623b78621b2cf60347
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Andrew Bogott
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] this is a test... - change (operations/puppet)
Jeremyb has uploaded a new change for review.
https://gerrit.wikimedia.org/r/63374
Change subject: this is a test...
..
this is a test...
Change-Id: I0bc0d399b06e56d8b5813e0462603bc48eb5d6f7
---
M manifests/misc/rt-server.pp
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/74/63374/1
diff --git a/manifests/misc/rt-server.pp b/manifests/misc/rt-server.pp
index b3eb033..0a18628 100644
--- a/manifests/misc/rt-server.pp
+++ b/manifests/misc/rt-server.pp
@@ -4,7 +4,7 @@
#
# It's used in production but should function in labs
# as well.
-class misc::rt::server ( $site = 'rt.wikimedia.org', $datadir =
'/var/lib/mysql' ) {
+class misc::rt::server ( $site = 'rt.wikmedia.org', $datadir =
'/var/lib/mysql' ) {
system_role { 'misc::rt::server': description = 'RT server' }
package { [ 'request-tracker3.8', 'rt3.8-db-mysql', 'rt3.8-clients',
'libcgi-fast-perl', 'lighttpd',
--
To view, visit https://gerrit.wikimedia.org/r/63374
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0bc0d399b06e56d8b5813e0462603bc48eb5d6f7
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jeremyb jer...@tuxmachine.com
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove unused backend test - change (operations/puppet[production])
Mark Bergsma has uploaded a new change for review. Change subject: Remove unused backend test .. Remove unused backend test Change-Id: Ib7f32b53bad939f8e7d11ccd2975fcdd87b0201e --- M templates/varnish/wikimedia.vcl.erb 1 file changed, 0 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/55/46755/1 -- To view, visit https://gerrit.wikimedia.org/r/46755 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib7f32b53bad939f8e7d11ccd2975fcdd87b0201e Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Mark Bergsma m...@wikimedia.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove unused backend test - change (operations/puppet[production])
Mark Bergsma has submitted this change and it was merged. Change subject: Remove unused backend test .. Remove unused backend test Change-Id: Ib7f32b53bad939f8e7d11ccd2975fcdd87b0201e --- M templates/varnish/wikimedia.vcl.erb 1 file changed, 0 insertions(+), 10 deletions(-) Approvals: Mark Bergsma: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/46755 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib7f32b53bad939f8e7d11ccd2975fcdd87b0201e Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Mark Bergsma m...@wikimedia.org Gerrit-Reviewer: Mark Bergsma m...@wikimedia.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
