[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Fix CodeMirror height

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/385998 )

Change subject: Fix CodeMirror height
..


Fix CodeMirror height

This removes a small gap between the bottom of the editor and the top of
the navbar below it in Chrome/Chromium.

Change-Id: Ib195dcf931911fd0b95937644fc2a65397fd4c2a
---
M style.less
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Smalyshev: Looks good to me, approved
  Lucas Werkmeister (WMDE): Looks good to me, but someone else must approve
  jenkins-bot: Verified



diff --git a/style.less b/style.less
index 7eb08f4..077d341 100644
--- a/style.less
+++ b/style.less
@@ -78,7 +78,7 @@
 
 .CodeMirror {
border: 1px solid #ccc;
-   height: auto !important;
+   height: 100%;
 }
 
 .CodeMirror-scroll {

-- 
To view, visit https://gerrit.wikimedia.org/r/385998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib195dcf931911fd0b95937644fc2a65397fd4c2a
Gerrit-PatchSet: 2
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 
Gerrit-Reviewer: Jonas Kress (WMDE) 
Gerrit-Reviewer: Lucas Werkmeister (WMDE) 
Gerrit-Reviewer: Smalyshev 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Fix CodeMirror height

[Jonas Kress (WMDE) (Code Review)]

Jonas Kress (WMDE) has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/385998 )

Change subject: Fix CodeMirror height
..

Fix CodeMirror height

Change-Id: Ib195dcf931911fd0b95937644fc2a65397fd4c2a
---
M style.less
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikidata/query/gui 
refs/changes/98/385998/1

diff --git a/style.less b/style.less
index 7eb08f4..077d341 100644
--- a/style.less
+++ b/style.less
@@ -78,7 +78,7 @@
 
 .CodeMirror {
border: 1px solid #ccc;
-   height: auto !important;
+   height: 100%;
 }
 
 .CodeMirror-scroll {

-- 
To view, visit https://gerrit.wikimedia.org/r/385998
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib195dcf931911fd0b95937644fc2a65397fd4c2a
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/gui
Gerrit-Branch: master
Gerrit-Owner: Jonas Kress (WMDE) 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits