[MediaWiki-commits] [Gerrit] wikimedia...polloi[master]: Update dataset path, downloaded prefixes, and documentation

2017-05-31 Thread Bearloga (Code Review) 
Bearloga has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/356470 )

Change subject: Update dataset path, downloaded prefixes, and documentation
..


Update dataset path, downloaded prefixes, and documentation

- Updates dataset of prefixes
- Changes path to download datasets from
- Uses latest roxygen with markdown support

Bug: T166724
Change-Id: I34172c3198624425f6dfe55358d79e964791137a
---
M DESCRIPTION
M NEWS.md
M R/check_notify.R
M R/data.R
M R/dygraphs.R
M R/manipulate.R
M R/maths.R
M R/reading.R
M R/shiny.R
M R/smoothing.R
M R/utils.R
M README.md
M inst/extdata/prefixes.csv
M man/automata_select.Rd
M man/cbind_fill.Rd
M man/check_notify.Rd
M man/compress.Rd
M man/cond_color.Rd
M man/cond_icon.Rd
M man/custom_axis_formatter.Rd
M man/data_select.Rd
M man/get_langproj.Rd
M man/get_prefixes.Rd
M man/get_projects.Rd
M man/half.Rd
M man/make_dygraph.Rd
M man/na_box.Rd
M man/parse_wikiid.Rd
M man/percent_change.Rd
M man/read_dataset.Rd
M man/safe_tail.Rd
M man/smart_palette.Rd
M man/smooth_select.Rd
M man/smooth_switch.Rd
M man/smoother.Rd
M man/subset_by_date_range.Rd
M man/time_frame_range.Rd
M man/timeframe_daterange.Rd
M man/timeframe_select.Rd
M man/update_prefixes.Rd
M man/update_projects.Rd
41 files changed, 276 insertions(+), 304 deletions(-)

Approvals:
  Bearloga: Verified; Looks good to me, approved



diff --git a/DESCRIPTION b/DESCRIPTION
index 86c6f83..5435797 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -1,17 +1,17 @@
 Package: polloi
 Type: Package
 Title: Common Functionality for Wikimedia Dashboards
-Version: 0.1.7
-Date: 2016-12-07
+Version: 0.1.8
+Date: 2017-05-31
 Authors@R: c(
-person("Oliver", "Keyes", role = "aut"),
-person("Mikhail", "Popov", email = "mpo...@wikimedia.org", role = c("aut", 
"cre")))
+person("Mikhail", "Popov", email = "mpo...@wikimedia.org", role = c("aut", 
"cre")),
+person("Oliver", "Keyes", role = "aut")
+)
 Description: This package contains common functionality for all of the
 Wikimedia Foundation's Shiny Dashboards.
 License: MIT + file LICENSE
 URL: https://phabricator.wikimedia.org/diffusion/WDPL/
-BugReports: https://phabricator.wikimedia.org/maniphest/task/create/?
-projects=Discovery-Analysis
+BugReports: 
https://phabricator.wikimedia.org/maniphest/task/create/?projects=Discovery-Analysis
 Depends:
 R (>= 3.1.0)
 Imports:
@@ -28,9 +28,10 @@
 dplyr (>= 0.4.3),
 tidyr (>= 0.4.1),
 mgcv
-LazyData: TRUE
-RoxygenNote: 5.0.1
 Suggests:
 rvest (>= 0.3.1),
 xml2 (>= 0.1.2),
 httr (>= 1.1.0)
+LazyData: TRUE
+Roxygen: list(markdown = TRUE)
+RoxygenNote: 6.0.1
diff --git a/NEWS.md b/NEWS.md
index b8cfd3a..28f0995 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,3 +1,9 @@
+polloi 0.1.8
+
+- Updates dataset of prefixes
+- Changes path to download datasets from
+- Uses latest roxygen with markdown support
+
 polloi 0.1.7
 
 - Fixes a bug wherein a "found duplicated data in" message was incorrectly 
displayed (specifically, when there was no duplicated data).
diff --git a/R/check_notify.R b/R/check_notify.R
index 5492e60..1e5c840 100644
--- a/R/check_notify.R
+++ b/R/check_notify.R
@@ -1,17 +1,17 @@
-#'@title Check 'n' Notify
-#'@description Check a dataset for missing data from the day before and the
-#'  past week, and create a \code{notificationItem} if missing data has been
+#' @title Check 'n' Notify
+#' @description Check a dataset for missing data from the day before and the
+#'  past week, and create a `notificationItem` if missing data has been
 #'  detected.
-#'@param dataset A data.frame with a 'date' column.
-#'@param label The label to use in the notification.
-#'@family Shiny Dashboarding
-#'@name check_notify
+#' @param dataset A data.frame with a 'date' column.
+#' @param label The label to use in the notification.
+#' @family Shiny Dashboarding
+#' @name check_notify
 NULL
 
-#'@rdname check_notify
-#'@importFrom shinydashboard notificationItem
-#'@importFrom shiny icon
-#'@export
+#' @rdname check_notify
+#' @importFrom shinydashboard notificationItem
+#' @importFrom shiny icon
+#' @export
 check_yesterday <- function(dataset, label) {
   # e.g. label = "desktop events"
   yesterday_date <- Sys.Date() - 1
@@ -22,10 +22,10 @@
   return(NULL)
 }
 
-#'@rdname check_notify
-#'@importFrom shinydashboard notificationItem
-#'@importFrom shiny icon
-#'@export
+#' @rdname check_notify
+#' @importFrom shinydashboard notificationItem
+#' @importFrom shiny icon
+#' @export
 check_past_week <- function(dataset, label) {
   past_week <- Sys.Date() - c(2:7) # Sys.Date()-1 is already handled by 
check_yesterday()
   if (any(!(past_week %in% dataset$date))) {
diff --git a/R/data.R b/R/data.R
index 2dfc8d4..288de6e 100644
--- a/R/data.R
+++ b/R/data.R
@@ -17,7 +17,7 @@
 #'
 #' @source 
\url{https://meta.wikimedia.org/wiki/Template:Table_of_Wikimedia_projects#Projects_per_language_codes}
 #'

[MediaWiki-commits] [Gerrit] wikimedia...polloi[master]: Update dataset path, downloaded prefixes, and documentation

2017-05-31 Thread Bearloga (Code Review) 
Bearloga has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/356470 )

Change subject: Update dataset path, downloaded prefixes, and documentation
..

Update dataset path, downloaded prefixes, and documentation

- Updates dataset of prefixes
- Changes path to download datasets from
- Uses latest roxygen with markdown support

Bug: T166724
Change-Id: I34172c3198624425f6dfe55358d79e964791137a
---
M DESCRIPTION
M NEWS.md
M R/check_notify.R
M R/data.R
M R/dygraphs.R
M R/manipulate.R
M R/maths.R
M R/reading.R
M R/shiny.R
M R/smoothing.R
M R/utils.R
M README.md
M inst/extdata/prefixes.csv
M man/automata_select.Rd
M man/cbind_fill.Rd
M man/check_notify.Rd
M man/compress.Rd
M man/cond_color.Rd
M man/cond_icon.Rd
M man/custom_axis_formatter.Rd
M man/data_select.Rd
M man/get_langproj.Rd
M man/get_prefixes.Rd
M man/get_projects.Rd
M man/half.Rd
M man/make_dygraph.Rd
M man/na_box.Rd
M man/parse_wikiid.Rd
M man/percent_change.Rd
M man/read_dataset.Rd
M man/safe_tail.Rd
M man/smart_palette.Rd
M man/smooth_select.Rd
M man/smooth_switch.Rd
M man/smoother.Rd
M man/subset_by_date_range.Rd
M man/time_frame_range.Rd
M man/timeframe_daterange.Rd
M man/timeframe_select.Rd
M man/update_prefixes.Rd
M man/update_projects.Rd
41 files changed, 276 insertions(+), 304 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/polloi 
refs/changes/70/356470/1

diff --git a/DESCRIPTION b/DESCRIPTION
index 86c6f83..5435797 100644
--- a/DESCRIPTION
+++ b/DESCRIPTION
@@ -1,17 +1,17 @@
 Package: polloi
 Type: Package
 Title: Common Functionality for Wikimedia Dashboards
-Version: 0.1.7
-Date: 2016-12-07
+Version: 0.1.8
+Date: 2017-05-31
 Authors@R: c(
-person("Oliver", "Keyes", role = "aut"),
-person("Mikhail", "Popov", email = "mpo...@wikimedia.org", role = c("aut", 
"cre")))
+person("Mikhail", "Popov", email = "mpo...@wikimedia.org", role = c("aut", 
"cre")),
+person("Oliver", "Keyes", role = "aut")
+)
 Description: This package contains common functionality for all of the
 Wikimedia Foundation's Shiny Dashboards.
 License: MIT + file LICENSE
 URL: https://phabricator.wikimedia.org/diffusion/WDPL/
-BugReports: https://phabricator.wikimedia.org/maniphest/task/create/?
-projects=Discovery-Analysis
+BugReports: 
https://phabricator.wikimedia.org/maniphest/task/create/?projects=Discovery-Analysis
 Depends:
 R (>= 3.1.0)
 Imports:
@@ -28,9 +28,10 @@
 dplyr (>= 0.4.3),
 tidyr (>= 0.4.1),
 mgcv
-LazyData: TRUE
-RoxygenNote: 5.0.1
 Suggests:
 rvest (>= 0.3.1),
 xml2 (>= 0.1.2),
 httr (>= 1.1.0)
+LazyData: TRUE
+Roxygen: list(markdown = TRUE)
+RoxygenNote: 6.0.1
diff --git a/NEWS.md b/NEWS.md
index b8cfd3a..28f0995 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -1,3 +1,9 @@
+polloi 0.1.8
+
+- Updates dataset of prefixes
+- Changes path to download datasets from
+- Uses latest roxygen with markdown support
+
 polloi 0.1.7
 
 - Fixes a bug wherein a "found duplicated data in" message was incorrectly 
displayed (specifically, when there was no duplicated data).
diff --git a/R/check_notify.R b/R/check_notify.R
index 5492e60..1e5c840 100644
--- a/R/check_notify.R
+++ b/R/check_notify.R
@@ -1,17 +1,17 @@
-#'@title Check 'n' Notify
-#'@description Check a dataset for missing data from the day before and the
-#'  past week, and create a \code{notificationItem} if missing data has been
+#' @title Check 'n' Notify
+#' @description Check a dataset for missing data from the day before and the
+#'  past week, and create a `notificationItem` if missing data has been
 #'  detected.
-#'@param dataset A data.frame with a 'date' column.
-#'@param label The label to use in the notification.
-#'@family Shiny Dashboarding
-#'@name check_notify
+#' @param dataset A data.frame with a 'date' column.
+#' @param label The label to use in the notification.
+#' @family Shiny Dashboarding
+#' @name check_notify
 NULL
 
-#'@rdname check_notify
-#'@importFrom shinydashboard notificationItem
-#'@importFrom shiny icon
-#'@export
+#' @rdname check_notify
+#' @importFrom shinydashboard notificationItem
+#' @importFrom shiny icon
+#' @export
 check_yesterday <- function(dataset, label) {
   # e.g. label = "desktop events"
   yesterday_date <- Sys.Date() - 1
@@ -22,10 +22,10 @@
   return(NULL)
 }
 
-#'@rdname check_notify
-#'@importFrom shinydashboard notificationItem
-#'@importFrom shiny icon
-#'@export
+#' @rdname check_notify
+#' @importFrom shinydashboard notificationItem
+#' @importFrom shiny icon
+#' @export
 check_past_week <- function(dataset, label) {
   past_week <- Sys.Date() - c(2:7) # Sys.Date()-1 is already handled by 
check_yesterday()
   if (any(!(past_week %in% dataset$date))) {
diff --git a/R/data.R b/R/data.R
index 2dfc8d4..288de6e 100644
--- a/R/data.R
+++ b/R/data.R
@@ -17,7 +17,7 @@
 #'
 #' @source