[MediaWiki-commits] [Gerrit] wikipedia...ProveIt[master]: Many improvements
Sophivorus has submitted this change and it was merged.
Change subject: Many improvements
..
Many improvements
- Improved comments
- Improved CSS class naming
- Code pretification
- Merged RawReference class with TemplateReference class
- Allow to switch between templates without losing data
- Allow to drag and resize widget
- Bugfixes
- All config options are now optional
- Add button to delete references and all their citations
- Add button to add a citation to a reference
Change-Id: Id7ce3cf5776e30f7336e25c92a19746d3a363568
---
M proveit.css
M proveit.js
2 files changed, 417 insertions(+), 336 deletions(-)
Approvals:
Sophivorus: Verified; Looks good to me, approved
diff --git a/proveit.css b/proveit.css
index 54b47e6..dc4762e 100755
--- a/proveit.css
+++ b/proveit.css
@@ -74,11 +74,11 @@
cursor: pointer;
}
-#proveit-reference-list .proveit-reference-item .proveit-template {
+#proveit-reference-list .proveit-reference-item .proveit-reference-template {
font-weight: bold;
}
-#proveit-reference-list .proveit-reference-item .proveit-required-value {
+#proveit-reference-list .proveit-reference-item .proveit-required-param-value {
margin-left: 10px;
}
@@ -134,7 +134,7 @@
}
#proveit-reference-form textarea {
- height: 100px;
+ height: 60px;
resize: vertical;
}
@@ -158,6 +158,13 @@
border-radius: 3px;
cursor: pointer;
font: inherit;
+ margin-left: 10px;
padding: 5px;
pointer-events: all;
+}
+
+#proveit-buttons #proveit-cite-button,
+#proveit-buttons #proveit-remove-button,
+#proveit-buttons #proveit-params-button {
+ background: none;
}
\ No newline at end of file
diff --git a/proveit.js b/proveit.js
index d8273f5..83e7a78 100755
--- a/proveit.js
+++ b/proveit.js
@@ -16,6 +16,11 @@
var proveit = {
/**
+* URL of the ProveIt icon hosted at Commons
+*/
+ ICON:
'//upload.wikimedia.org/wikipedia/commons/thumb/1/19/ProveIt_logo_for_user_boxes.svg/22px-ProveIt_logo_for_user_boxes.svg.png',
+
+ /**
* Interface messages
*/
messages: {
@@ -23,20 +28,32 @@
'proveit-edit-tab': 'Edit',
'proveit-add-tab': 'Add',
'proveit-reference-name-label': 'Reference name',
- 'proveit-reference-text-label': 'Reference text',
- 'proveit-template-label': 'Template',
+ 'proveit-reference-content-label': 'Reference content',
+ 'proveit-reference-template-label': 'Main template',
+ 'proveit-params-button': 'Show all parameters',
+ 'proveit-cite-button': 'Cite',
+ 'proveit-remove-button': 'Remove',
'proveit-insert-button': 'Insert',
'proveit-update-button': 'Update',
+ 'proveit-prompt-name': 'The reference needs a name in
order to be cited:',
+ 'proveit-confirm-remove': 'This will remove the
reference and all of its citations. Are you sure?',
+ 'proveit-no-template': 'No template',
'proveit-no-references': 'No references found'
},
'es': {
'proveit-edit-tab': 'Editar',
'proveit-add-tab': 'Agregar',
'proveit-reference-name-label': 'Nombre de la
referencia',
- 'proveit-reference-text-label': 'Texto de la
referencia',
- 'proveit-template-label': 'Plantilla',
+ 'proveit-reference-content-label': 'Contenido de la
referencia',
+ 'proveit-reference-template-label': 'Plantilla
principal',
+ 'proveit-params-button': 'Ver todos los parámetros',
+ 'proveit-cite-button': 'Citar',
+ 'proveit-remove-button': 'Borrar',
'proveit-insert-button': 'Insertar',
'proveit-update-button': 'Actualizar',
+ 'proveit-prompt-name': 'La referencia necesita un
nombre para ser citada:',
+ 'proveit-confirm-remove': 'Esto borrará la referencia y
todas sus citas. ¿Estás seguro?',
+ 'proveit-no-template': 'Sin plantilla',
'proveit-no-references': 'No se han encontrado
referencias'
}
},
@@ -49,10 +66,9 @@
templates: {},
/**
-* Interface language
-* The default or fallback language is English
+* Interface language (may be different from the content language)
*
-* @type {string}
+* @type {string} defaults to English
*/
userLanguage: 'en',
@@ -79,7 +95,7 @@
[MediaWiki-commits] [Gerrit] wikipedia...ProveIt[master]: Many improvements
Sophivorus has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314828
Change subject: Many improvements
..
Many improvements
- Improved comments
- Improved CSS class naming
- Code pretification
- Merged RawReference class with TemplateReference class
- Allow to switch between templates without losing data
- Allow to drag and resize widget
- Bugfixes
- All config options are now optional
- Add button to delete references and all their citations
- Add button to add a citation to a reference
Change-Id: Id7ce3cf5776e30f7336e25c92a19746d3a363568
---
M proveit.css
M proveit.js
2 files changed, 417 insertions(+), 336 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikipedia/gadgets/ProveIt
refs/changes/28/314828/1
diff --git a/proveit.css b/proveit.css
index 54b47e6..dc4762e 100755
--- a/proveit.css
+++ b/proveit.css
@@ -74,11 +74,11 @@
cursor: pointer;
}
-#proveit-reference-list .proveit-reference-item .proveit-template {
+#proveit-reference-list .proveit-reference-item .proveit-reference-template {
font-weight: bold;
}
-#proveit-reference-list .proveit-reference-item .proveit-required-value {
+#proveit-reference-list .proveit-reference-item .proveit-required-param-value {
margin-left: 10px;
}
@@ -134,7 +134,7 @@
}
#proveit-reference-form textarea {
- height: 100px;
+ height: 60px;
resize: vertical;
}
@@ -158,6 +158,13 @@
border-radius: 3px;
cursor: pointer;
font: inherit;
+ margin-left: 10px;
padding: 5px;
pointer-events: all;
+}
+
+#proveit-buttons #proveit-cite-button,
+#proveit-buttons #proveit-remove-button,
+#proveit-buttons #proveit-params-button {
+ background: none;
}
\ No newline at end of file
diff --git a/proveit.js b/proveit.js
index d8273f5..83e7a78 100755
--- a/proveit.js
+++ b/proveit.js
@@ -16,6 +16,11 @@
var proveit = {
/**
+* URL of the ProveIt icon hosted at Commons
+*/
+ ICON:
'//upload.wikimedia.org/wikipedia/commons/thumb/1/19/ProveIt_logo_for_user_boxes.svg/22px-ProveIt_logo_for_user_boxes.svg.png',
+
+ /**
* Interface messages
*/
messages: {
@@ -23,20 +28,32 @@
'proveit-edit-tab': 'Edit',
'proveit-add-tab': 'Add',
'proveit-reference-name-label': 'Reference name',
- 'proveit-reference-text-label': 'Reference text',
- 'proveit-template-label': 'Template',
+ 'proveit-reference-content-label': 'Reference content',
+ 'proveit-reference-template-label': 'Main template',
+ 'proveit-params-button': 'Show all parameters',
+ 'proveit-cite-button': 'Cite',
+ 'proveit-remove-button': 'Remove',
'proveit-insert-button': 'Insert',
'proveit-update-button': 'Update',
+ 'proveit-prompt-name': 'The reference needs a name in
order to be cited:',
+ 'proveit-confirm-remove': 'This will remove the
reference and all of its citations. Are you sure?',
+ 'proveit-no-template': 'No template',
'proveit-no-references': 'No references found'
},
'es': {
'proveit-edit-tab': 'Editar',
'proveit-add-tab': 'Agregar',
'proveit-reference-name-label': 'Nombre de la
referencia',
- 'proveit-reference-text-label': 'Texto de la
referencia',
- 'proveit-template-label': 'Plantilla',
+ 'proveit-reference-content-label': 'Contenido de la
referencia',
+ 'proveit-reference-template-label': 'Plantilla
principal',
+ 'proveit-params-button': 'Ver todos los parámetros',
+ 'proveit-cite-button': 'Citar',
+ 'proveit-remove-button': 'Borrar',
'proveit-insert-button': 'Insertar',
'proveit-update-button': 'Actualizar',
+ 'proveit-prompt-name': 'La referencia necesita un
nombre para ser citada:',
+ 'proveit-confirm-remove': 'Esto borrará la referencia y
todas sus citas. ¿Estás seguro?',
+ 'proveit-no-template': 'Sin plantilla',
'proveit-no-references': 'No se han encontrado
referencias'
}
},
@@ -49,10 +66,9 @@
templates: {},
/**
-* Interface language
-* The default or fallback language is English
+* Interface language (may be different from the content language)
*
-* @type {string}
+* @type {string} defaults to English
