[MediaWiki-commits] [Gerrit] wmfelastic.py: Fix PEP8 violations - change (operations/puppet)

[Ori.livneh (Code Review)]

Ori.livneh has submitted this change and it was merged.

Change subject: wmfelastic.py: Fix PEP8 violations
..


wmfelastic.py: Fix PEP8 violations

* F841 local variable 'e' is assigned to but never used

Change-Id: Ic6b77bd26d7fc63db159c6cfe710ae8d89d7fec7
---
M modules/elasticsearch/files/monitor/wmfelastic.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Gehel: Looks good to me, but someone else must approve
  Ori.livneh: Verified; Looks good to me, approved



diff --git a/modules/elasticsearch/files/monitor/wmfelastic.py 
b/modules/elasticsearch/files/monitor/wmfelastic.py
index 25ccef2..0cdf4c9 100644
--- a/modules/elasticsearch/files/monitor/wmfelastic.py
+++ b/modules/elasticsearch/files/monitor/wmfelastic.py
@@ -230,7 +230,7 @@
 for metric in self.health_metrics:
 try:
 gmetrics[metric] = chealth[metric]
-except KeyError, e:
+except KeyError:
 self.errors += 1
 pass
 return gmetrics
@@ -243,7 +243,7 @@
 try:
 value = self.dict_digger(depth, cstats)
 gmetrics[m] = value
-except KeyError, e:
+except KeyError:
 self.errors += 1
 pass
 return gmetrics
@@ -258,7 +258,7 @@
 try:
 value = self.dict_digger(depth, nodestats)
 gmetrics[m] = value
-except KeyError, e:
+except KeyError:
 self.errors += 1
 pass
 return gmetrics

-- 
To view, visit https://gerrit.wikimedia.org/r/291178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6b77bd26d7fc63db159c6cfe710ae8d89d7fec7
Gerrit-PatchSet: 4
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BryanDavis 
Gerrit-Reviewer: Gehel 
Gerrit-Reviewer: Ori.livneh 
Gerrit-Reviewer: jenkins-bot <>

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

[MediaWiki-commits] [Gerrit] wmfelastic.py: Fix PEP8 violations - change (operations/puppet)

[BryanDavis (Code Review)]

BryanDavis has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/291178

Change subject: wmfelastic.py: Fix PEP8 violations
..

wmfelastic.py: Fix PEP8 violations

* F841 local variable 'e' is assigned to but never used

Change-Id: Ic6b77bd26d7fc63db159c6cfe710ae8d89d7fec7
---
M modules/elasticsearch/files/monitor/wmfelastic.py
1 file changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/78/291178/1

diff --git a/modules/elasticsearch/files/monitor/wmfelastic.py 
b/modules/elasticsearch/files/monitor/wmfelastic.py
index 25ccef2..0cdf4c9 100644
--- a/modules/elasticsearch/files/monitor/wmfelastic.py
+++ b/modules/elasticsearch/files/monitor/wmfelastic.py
@@ -230,7 +230,7 @@
 for metric in self.health_metrics:
 try:
 gmetrics[metric] = chealth[metric]
-except KeyError, e:
+except KeyError:
 self.errors += 1
 pass
 return gmetrics
@@ -243,7 +243,7 @@
 try:
 value = self.dict_digger(depth, cstats)
 gmetrics[m] = value
-except KeyError, e:
+except KeyError:
 self.errors += 1
 pass
 return gmetrics
@@ -258,7 +258,7 @@
 try:
 value = self.dict_digger(depth, nodestats)
 gmetrics[m] = value
-except KeyError, e:
+except KeyError:
 self.errors += 1
 pass
 return gmetrics

-- 
To view, visit https://gerrit.wikimedia.org/r/291178
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6b77bd26d7fc63db159c6cfe710ae8d89d7fec7
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: BryanDavis 

___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits