Re: [MeeGo-dev] Reducing rebuilds by patching away __DATE__ and __TIME__ usage in sources?

2010-12-16 Thread David Woodhouse
On Wed, 2010-12-08 at 13:07 +, Gary Birkett wrote:
> If the scanning is being done on binaries AFTER they have been rebuilt
> isn't that a bit fruitless ie, build this package to compare it with
> the last one to see if it needs rebuilding?
> 
> surely If the source is the same it should not be built in the first place? 

Indeed. There is a way to turn off this pointless rebuilding, in the OBS
config for the repository.

-- 
dwmw2

___
MeeGo-dev mailing list
MeeGo-dev@meego.com
http://lists.meego.com/listinfo/meego-dev


Re: [MeeGo-dev] Reducing rebuilds by patching away __DATE__ and __TIME__ usage in sources?

2010-12-08 Thread Gary Birkett
On Wed, Dec 8, 2010 at 12:28 PM, Carsten Munk  wrote:

> Hi,
>
> I've spent a little too much time watching rebuilds of the basesystem
> lately due to the ARM hardfp work.
>
> So, a bit of background:
>
> * OBS uses the build-compare tool in order to tell if there is a
> difference between the newly built package and the build results in
> previous run
>
> * If the package is 'new', all packages that depend on it, will
> rebuild as well.
>
> * If not, don't signal a rebuild
>
> One common thing is that many programs/libs gratuitously include the C
> macros __DATE__ and/or __TIME__ in their source codes, causing every
> rebuild of theirs to be different, but only in those areas. This
> causes unneeded rebuilds. And we already have an indication of the
> build time of a package due to the RPM database on a system.
>


If the scanning is being done on binaries AFTER they have been rebuilt isn't
that a bit fruitless
ie, build this package to compare it with the last one to see if it needs
rebuilding?

surely If the source is the same it should not be built in the first place?



>
> My proposal:
>
> * Identify packages using OBS build logs that include __DATE__ or
> __TIME__ (should be possible to grep for the usual patterns of
> __DATE__ and __TIME__)
> * Patch those usages away in spec file.
>
> or
>
> * Make build-compare able to notice a build change is 'just' because
> of __DATE__ and __TIME__ and otherwise similar.
>
> What do you think?
>
> BR
> Carsten Munk
> ___
> MeeGo-dev mailing list
> MeeGo-dev@meego.com
> http://lists.meego.com/listinfo/meego-dev
>
___
MeeGo-dev mailing list
MeeGo-dev@meego.com
http://lists.meego.com/listinfo/meego-dev


[MeeGo-dev] Reducing rebuilds by patching away __DATE__ and __TIME__ usage in sources?

2010-12-08 Thread Carsten Munk
Hi,

I've spent a little too much time watching rebuilds of the basesystem
lately due to the ARM hardfp work.

So, a bit of background:

* OBS uses the build-compare tool in order to tell if there is a
difference between the newly built package and the build results in
previous run

* If the package is 'new', all packages that depend on it, will
rebuild as well.

* If not, don't signal a rebuild

One common thing is that many programs/libs gratuitously include the C
macros __DATE__ and/or __TIME__ in their source codes, causing every
rebuild of theirs to be different, but only in those areas. This
causes unneeded rebuilds. And we already have an indication of the
build time of a package due to the RPM database on a system.

My proposal:

* Identify packages using OBS build logs that include __DATE__ or
__TIME__ (should be possible to grep for the usual patterns of
__DATE__ and __TIME__)
* Patch those usages away in spec file.

or

* Make build-compare able to notice a build change is 'just' because
of __DATE__ and __TIME__ and otherwise similar.

What do you think?

BR
Carsten Munk
___
MeeGo-dev mailing list
MeeGo-dev@meego.com
http://lists.meego.com/listinfo/meego-dev