Re: [PATCH 4 of 4 stable] hg-core: upgrade `zstd` dependency to 0.12
On 13/03/2023 15:44, Raphaël Gomès wrote: The idea is to have everything run through the CI. Contributions going through the repo and thus Heptapod makes it much easier for reviewers. Email remains as the lowest bar of entry (since you don't need an account and two out-of-core extensions) and for people truly allergic to the new workflow. I get so few email patches I forget how to queue patches that need amending, heh. Maybe the mbox extension would help, but it's pretty low priority for me ATM. I agree that email patches are the simplest way to contribute - especially when you already have it setup and working. Also, I consider it important that Mercurial is fully self hosted when using email patches, and it support all client side workflows. It seems like contributing through heptapod depends on using the evolve extension and changing the development workflow. Thanks, but no thanks. https://www.mercurial-scm.org/wiki/ContributingChanges still mentions email as a valid option. I will rely on that. And figure out what to do if it is removed without a good alternative. I hope you the patches can land for 6.4 . There will still be many test failures for Python 3.12 , but it will be possible to get far enough to see and fix them individually. /Mads ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: [PATCH 4 of 4 stable] hg-core: upgrade `zstd` dependency to 0.12
Scratch that sorry, I didn't look hard enough, I could just take the first three patches. How do you prefer to do it? I see you have an account on Heptapod already. On 3/13/23 15:44, Raphaël Gomès wrote: The idea is to have everything run through the CI. Contributions going through the repo and thus Heptapod makes it much easier for reviewers. Email remains as the lowest bar of entry (since you don't need an account and two out-of-core extensions) and for people truly allergic to the new workflow. I get so few email patches I forget how to queue patches that need amending, heh. Maybe the mbox extension would help, but it's pretty low priority for me ATM. In any case you'd need to send a V2, either via Heptapod or by email, since our ZSTD patches overlap. On 3/10/23 16:08, Mads Kiilerich wrote: Thanks. I still maintain my local copy of https://www.mercurial-scm.org/wiki/MboxExtension . Something like that could be perhaps be patched into heptapod if the goal is to have everything running through the web interface. /Mads On 09/03/2023 18:33, Augie Fackler wrote: Series LGTM for stable, but last time I queued something from the ML I think I angered the heptapod gods, so I’ll tag a couple of people that can hopefully push this on our behalf. AF On Mar 7, 2023, at 13:23, Mads Kiilerich wrote: # HG changeset patch # User Mads Kiilerich # Date 1678212582 -3600 # Tue Mar 07 19:09:42 2023 +0100 # Branch stable # Node ID 98085f80f5b0c786dad342ad1eb9335dda653496 # Parent 6ab12a75c936e0f1bf4305b9fdf9960219d1a39c hg-core: upgrade `zstd` dependency to 0.12 zstd was recently upgraded from 0.5 to 0.11 . Now, take it one step further to 0.12 . There is no need to stay in the past. And 0.12 is available in Fedora - 0.11 isn't. diff --git a/rust/Cargo.lock b/rust/Cargo.lock --- a/rust/Cargo.lock +++ b/rust/Cargo.lock @@ -1425,18 +1425,18 @@ checksum = "09041cd90cf85f7f8b2df60c646f [[package]] name = "zstd" -version = "0.11.2+zstd.1.5.2" +version = "0.12.3+zstd.1.5.2" source = "registry+https://github.com/rust-lang/crates.io-index; -checksum = "20cc960326ece64f010d2d2107537f26dc589a6573a316bd5b1dba685fa5fde4" +checksum = "76eea132fb024e0e13fd9c2f5d5d595d8a967aa72382ac2f9d39fcc95afd0806" dependencies = [ "zstd-safe", ] [[package]] name = "zstd-safe" -version = "5.0.2+zstd.1.5.2" +version = "6.0.4+zstd.1.5.4" source = "registry+https://github.com/rust-lang/crates.io-index; -checksum = "1d2a5585e04f9eea4b2a3d1eca508c4dee9592a89ef6f450c11719da0726f4db" +checksum = "7afb4b54b8910cf5447638cb54bf4e8a65cbedd783af98b98c62ffe91f185543" dependencies = [ "libc", "zstd-sys", @@ -1444,10 +1444,11 @@ dependencies = [ [[package]] name = "zstd-sys" -version = "2.0.1+zstd.1.5.2" +version = "2.0.7+zstd.1.5.4" source = "registry+https://github.com/rust-lang/crates.io-index; -checksum = "9fd07cbbc53846d9145dbffdf6dd09a7a0aa52be46741825f5c97bdd4f73f12b" +checksum = "94509c3ba2fe55294d752b79842c530ccfab760192521df74a081a78d2b3c7f5" dependencies = [ "cc", "libc", + "pkg-config", ] diff --git a/rust/hg-core/Cargo.toml b/rust/hg-core/Cargo.toml --- a/rust/hg-core/Cargo.toml +++ b/rust/hg-core/Cargo.toml @@ -34,7 +34,7 @@ thread_local = "1.1.4" crossbeam-channel = "0.5.6" log = "0.4.17" memmap2 = { version = "0.5.8", features = ["stable_deref_trait"] } -zstd = "0.11.2" +zstd = "0.12" format-bytes = "0.3.0" # once_cell 1.15 uses edition 2021, while the heptapod CI # uses an old version of Cargo that doesn't support it. ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: [PATCH 4 of 4 stable] hg-core: upgrade `zstd` dependency to 0.12
The idea is to have everything run through the CI. Contributions going through the repo and thus Heptapod makes it much easier for reviewers. Email remains as the lowest bar of entry (since you don't need an account and two out-of-core extensions) and for people truly allergic to the new workflow. I get so few email patches I forget how to queue patches that need amending, heh. Maybe the mbox extension would help, but it's pretty low priority for me ATM. In any case you'd need to send a V2, either via Heptapod or by email, since our ZSTD patches overlap. On 3/10/23 16:08, Mads Kiilerich wrote: Thanks. I still maintain my local copy of https://www.mercurial-scm.org/wiki/MboxExtension . Something like that could be perhaps be patched into heptapod if the goal is to have everything running through the web interface. /Mads On 09/03/2023 18:33, Augie Fackler wrote: Series LGTM for stable, but last time I queued something from the ML I think I angered the heptapod gods, so I’ll tag a couple of people that can hopefully push this on our behalf. AF On Mar 7, 2023, at 13:23, Mads Kiilerich wrote: # HG changeset patch # User Mads Kiilerich # Date 1678212582 -3600 # Tue Mar 07 19:09:42 2023 +0100 # Branch stable # Node ID 98085f80f5b0c786dad342ad1eb9335dda653496 # Parent 6ab12a75c936e0f1bf4305b9fdf9960219d1a39c hg-core: upgrade `zstd` dependency to 0.12 zstd was recently upgraded from 0.5 to 0.11 . Now, take it one step further to 0.12 . There is no need to stay in the past. And 0.12 is available in Fedora - 0.11 isn't. diff --git a/rust/Cargo.lock b/rust/Cargo.lock --- a/rust/Cargo.lock +++ b/rust/Cargo.lock @@ -1425,18 +1425,18 @@ checksum = "09041cd90cf85f7f8b2df60c646f [[package]] name = "zstd" -version = "0.11.2+zstd.1.5.2" +version = "0.12.3+zstd.1.5.2" source = "registry+https://github.com/rust-lang/crates.io-index; -checksum = "20cc960326ece64f010d2d2107537f26dc589a6573a316bd5b1dba685fa5fde4" +checksum = "76eea132fb024e0e13fd9c2f5d5d595d8a967aa72382ac2f9d39fcc95afd0806" dependencies = [ "zstd-safe", ] [[package]] name = "zstd-safe" -version = "5.0.2+zstd.1.5.2" +version = "6.0.4+zstd.1.5.4" source = "registry+https://github.com/rust-lang/crates.io-index; -checksum = "1d2a5585e04f9eea4b2a3d1eca508c4dee9592a89ef6f450c11719da0726f4db" +checksum = "7afb4b54b8910cf5447638cb54bf4e8a65cbedd783af98b98c62ffe91f185543" dependencies = [ "libc", "zstd-sys", @@ -1444,10 +1444,11 @@ dependencies = [ [[package]] name = "zstd-sys" -version = "2.0.1+zstd.1.5.2" +version = "2.0.7+zstd.1.5.4" source = "registry+https://github.com/rust-lang/crates.io-index; -checksum = "9fd07cbbc53846d9145dbffdf6dd09a7a0aa52be46741825f5c97bdd4f73f12b" +checksum = "94509c3ba2fe55294d752b79842c530ccfab760192521df74a081a78d2b3c7f5" dependencies = [ "cc", "libc", + "pkg-config", ] diff --git a/rust/hg-core/Cargo.toml b/rust/hg-core/Cargo.toml --- a/rust/hg-core/Cargo.toml +++ b/rust/hg-core/Cargo.toml @@ -34,7 +34,7 @@ thread_local = "1.1.4" crossbeam-channel = "0.5.6" log = "0.4.17" memmap2 = { version = "0.5.8", features = ["stable_deref_trait"] } -zstd = "0.11.2" +zstd = "0.12" format-bytes = "0.3.0" # once_cell 1.15 uses edition 2021, while the heptapod CI # uses an old version of Cargo that doesn't support it. ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: [PATCH 4 of 4 stable] hg-core: upgrade `zstd` dependency to 0.12
Thanks. I still maintain my local copy of https://www.mercurial-scm.org/wiki/MboxExtension . Something like that could be perhaps be patched into heptapod if the goal is to have everything running through the web interface. /Mads On 09/03/2023 18:33, Augie Fackler wrote: Series LGTM for stable, but last time I queued something from the ML I think I angered the heptapod gods, so I’ll tag a couple of people that can hopefully push this on our behalf. AF On Mar 7, 2023, at 13:23, Mads Kiilerich wrote: # HG changeset patch # User Mads Kiilerich # Date 1678212582 -3600 # Tue Mar 07 19:09:42 2023 +0100 # Branch stable # Node ID 98085f80f5b0c786dad342ad1eb9335dda653496 # Parent 6ab12a75c936e0f1bf4305b9fdf9960219d1a39c hg-core: upgrade `zstd` dependency to 0.12 zstd was recently upgraded from 0.5 to 0.11 . Now, take it one step further to 0.12 . There is no need to stay in the past. And 0.12 is available in Fedora - 0.11 isn't. diff --git a/rust/Cargo.lock b/rust/Cargo.lock --- a/rust/Cargo.lock +++ b/rust/Cargo.lock @@ -1425,18 +1425,18 @@ checksum = "09041cd90cf85f7f8b2df60c646f [[package]] name = "zstd" -version = "0.11.2+zstd.1.5.2" +version = "0.12.3+zstd.1.5.2" source = "registry+https://github.com/rust-lang/crates.io-index; -checksum = "20cc960326ece64f010d2d2107537f26dc589a6573a316bd5b1dba685fa5fde4" +checksum = "76eea132fb024e0e13fd9c2f5d5d595d8a967aa72382ac2f9d39fcc95afd0806" dependencies = [ "zstd-safe", ] [[package]] name = "zstd-safe" -version = "5.0.2+zstd.1.5.2" +version = "6.0.4+zstd.1.5.4" source = "registry+https://github.com/rust-lang/crates.io-index; -checksum = "1d2a5585e04f9eea4b2a3d1eca508c4dee9592a89ef6f450c11719da0726f4db" +checksum = "7afb4b54b8910cf5447638cb54bf4e8a65cbedd783af98b98c62ffe91f185543" dependencies = [ "libc", "zstd-sys", @@ -1444,10 +1444,11 @@ dependencies = [ [[package]] name = "zstd-sys" -version = "2.0.1+zstd.1.5.2" +version = "2.0.7+zstd.1.5.4" source = "registry+https://github.com/rust-lang/crates.io-index; -checksum = "9fd07cbbc53846d9145dbffdf6dd09a7a0aa52be46741825f5c97bdd4f73f12b" +checksum = "94509c3ba2fe55294d752b79842c530ccfab760192521df74a081a78d2b3c7f5" dependencies = [ "cc", "libc", + "pkg-config", ] diff --git a/rust/hg-core/Cargo.toml b/rust/hg-core/Cargo.toml --- a/rust/hg-core/Cargo.toml +++ b/rust/hg-core/Cargo.toml @@ -34,7 +34,7 @@ thread_local = "1.1.4" crossbeam-channel = "0.5.6" log = "0.4.17" memmap2 = { version = "0.5.8", features = ["stable_deref_trait"] } -zstd = "0.11.2" +zstd = "0.12" format-bytes = "0.3.0" # once_cell 1.15 uses edition 2021, while the heptapod CI # uses an old version of Cargo that doesn't support it. ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel
Re: [PATCH 4 of 4 stable] hg-core: upgrade `zstd` dependency to 0.12
Series LGTM for stable, but last time I queued something from the ML I think I angered the heptapod gods, so I’ll tag a couple of people that can hopefully push this on our behalf. AF > On Mar 7, 2023, at 13:23, Mads Kiilerich wrote: > > # HG changeset patch > # User Mads Kiilerich > # Date 1678212582 -3600 > # Tue Mar 07 19:09:42 2023 +0100 > # Branch stable > # Node ID 98085f80f5b0c786dad342ad1eb9335dda653496 > # Parent 6ab12a75c936e0f1bf4305b9fdf9960219d1a39c > hg-core: upgrade `zstd` dependency to 0.12 > > zstd was recently upgraded from 0.5 to 0.11 . Now, take it one step further to > 0.12 . > > There is no need to stay in the past. And 0.12 is available in Fedora - 0.11 > isn't. > > diff --git a/rust/Cargo.lock b/rust/Cargo.lock > --- a/rust/Cargo.lock > +++ b/rust/Cargo.lock > @@ -1425,18 +1425,18 @@ checksum = "09041cd90cf85f7f8b2df60c646f > > [[package]] > name = "zstd" > -version = "0.11.2+zstd.1.5.2" > +version = "0.12.3+zstd.1.5.2" > source = "registry+https://github.com/rust-lang/crates.io-index; > -checksum = "20cc960326ece64f010d2d2107537f26dc589a6573a316bd5b1dba685fa5fde4" > +checksum = "76eea132fb024e0e13fd9c2f5d5d595d8a967aa72382ac2f9d39fcc95afd0806" > dependencies = [ > "zstd-safe", > ] > > [[package]] > name = "zstd-safe" > -version = "5.0.2+zstd.1.5.2" > +version = "6.0.4+zstd.1.5.4" > source = "registry+https://github.com/rust-lang/crates.io-index; > -checksum = "1d2a5585e04f9eea4b2a3d1eca508c4dee9592a89ef6f450c11719da0726f4db" > +checksum = "7afb4b54b8910cf5447638cb54bf4e8a65cbedd783af98b98c62ffe91f185543" > dependencies = [ > "libc", > "zstd-sys", > @@ -1444,10 +1444,11 @@ dependencies = [ > > [[package]] > name = "zstd-sys" > -version = "2.0.1+zstd.1.5.2" > +version = "2.0.7+zstd.1.5.4" > source = "registry+https://github.com/rust-lang/crates.io-index; > -checksum = "9fd07cbbc53846d9145dbffdf6dd09a7a0aa52be46741825f5c97bdd4f73f12b" > +checksum = "94509c3ba2fe55294d752b79842c530ccfab760192521df74a081a78d2b3c7f5" > dependencies = [ > "cc", > "libc", > + "pkg-config", > ] > diff --git a/rust/hg-core/Cargo.toml b/rust/hg-core/Cargo.toml > --- a/rust/hg-core/Cargo.toml > +++ b/rust/hg-core/Cargo.toml > @@ -34,7 +34,7 @@ thread_local = "1.1.4" > crossbeam-channel = "0.5.6" > log = "0.4.17" > memmap2 = { version = "0.5.8", features = ["stable_deref_trait"] } > -zstd = "0.11.2" > +zstd = "0.12" > format-bytes = "0.3.0" > # once_cell 1.15 uses edition 2021, while the heptapod CI > # uses an old version of Cargo that doesn't support it. > > ___ > Mercurial-devel mailing list > Mercurial-devel@lists.mercurial-scm.org > https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel
[PATCH 4 of 4 stable] hg-core: upgrade `zstd` dependency to 0.12
# HG changeset patch # User Mads Kiilerich # Date 1678212582 -3600 # Tue Mar 07 19:09:42 2023 +0100 # Branch stable # Node ID 98085f80f5b0c786dad342ad1eb9335dda653496 # Parent 6ab12a75c936e0f1bf4305b9fdf9960219d1a39c hg-core: upgrade `zstd` dependency to 0.12 zstd was recently upgraded from 0.5 to 0.11 . Now, take it one step further to 0.12 . There is no need to stay in the past. And 0.12 is available in Fedora - 0.11 isn't. diff --git a/rust/Cargo.lock b/rust/Cargo.lock --- a/rust/Cargo.lock +++ b/rust/Cargo.lock @@ -1425,18 +1425,18 @@ checksum = "09041cd90cf85f7f8b2df60c646f [[package]] name = "zstd" -version = "0.11.2+zstd.1.5.2" +version = "0.12.3+zstd.1.5.2" source = "registry+https://github.com/rust-lang/crates.io-index; -checksum = "20cc960326ece64f010d2d2107537f26dc589a6573a316bd5b1dba685fa5fde4" +checksum = "76eea132fb024e0e13fd9c2f5d5d595d8a967aa72382ac2f9d39fcc95afd0806" dependencies = [ "zstd-safe", ] [[package]] name = "zstd-safe" -version = "5.0.2+zstd.1.5.2" +version = "6.0.4+zstd.1.5.4" source = "registry+https://github.com/rust-lang/crates.io-index; -checksum = "1d2a5585e04f9eea4b2a3d1eca508c4dee9592a89ef6f450c11719da0726f4db" +checksum = "7afb4b54b8910cf5447638cb54bf4e8a65cbedd783af98b98c62ffe91f185543" dependencies = [ "libc", "zstd-sys", @@ -1444,10 +1444,11 @@ dependencies = [ [[package]] name = "zstd-sys" -version = "2.0.1+zstd.1.5.2" +version = "2.0.7+zstd.1.5.4" source = "registry+https://github.com/rust-lang/crates.io-index; -checksum = "9fd07cbbc53846d9145dbffdf6dd09a7a0aa52be46741825f5c97bdd4f73f12b" +checksum = "94509c3ba2fe55294d752b79842c530ccfab760192521df74a081a78d2b3c7f5" dependencies = [ "cc", "libc", + "pkg-config", ] diff --git a/rust/hg-core/Cargo.toml b/rust/hg-core/Cargo.toml --- a/rust/hg-core/Cargo.toml +++ b/rust/hg-core/Cargo.toml @@ -34,7 +34,7 @@ thread_local = "1.1.4" crossbeam-channel = "0.5.6" log = "0.4.17" memmap2 = { version = "0.5.8", features = ["stable_deref_trait"] } -zstd = "0.11.2" +zstd = "0.12" format-bytes = "0.3.0" # once_cell 1.15 uses edition 2021, while the heptapod CI # uses an old version of Cargo that doesn't support it. ___ Mercurial-devel mailing list Mercurial-devel@lists.mercurial-scm.org https://lists.mercurial-scm.org/mailman/listinfo/mercurial-devel