D6188: test/test-revset2.t: Unset environment variable P

2019-04-05 Thread jerry.montfort (Jerry Montfort)
jerry.montfort abandoned this revision.
jerry.montfort added a comment.


  Thanks @pulkit! Abandoning revision as you suggested.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6188

To: jerry.montfort, #hg-reviewers
Cc: pulkit, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


D6195: test/test-revset2.t: Unset environment variable P (issue6109)

2019-04-04 Thread jerry.montfort (Jerry Montfort)
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGf3365065ef1d: tests: unset environment variable P in 
test-revset2.t (issue6109) (authored by jerry.montfort, committed by ).

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST UPDATE
  https://phab.mercurial-scm.org/D6195?vs=14651&id=14655

REVISION DETAIL
  https://phab.mercurial-scm.org/D6195

AFFECTED FILES
  tests/test-revset2.t

CHANGE DETAILS

diff --git a/tests/test-revset2.t b/tests/test-revset2.t
--- a/tests/test-revset2.t
+++ b/tests/test-revset2.t
@@ -1627,6 +1627,7 @@
   > printprevset = $TESTTMP/printprevset.py
   > EOF
 
+  $ unset P
   $ hg --config revsetalias.P=1 printprevset
   P=[1]
   $ P=3 hg --config revsetalias.P=2 printprevset



To: jerry.montfort, #hg-reviewers, pulkit
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


D6195: test/test-revset2.t: Unset environment variable P (issue6109)

2019-04-04 Thread jerry.montfort (Jerry Montfort)
jerry.montfort added a comment.


  Note: I had a typo in the issue number: I used the line number which happens 
to have the exact same digits as the issue number (must be destiny). To fix the 
typo I used the "Edit Revision" button on this web page. If that's the wrong 
way, I'll resend the patch if required.
  For the record: The issue number is issue6109 (and the line number 1609).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6195

To: jerry.montfort, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


D6188: test/test-revset2.t: Unset environment variable P

2019-04-04 Thread jerry.montfort (Jerry Montfort)
jerry.montfort added a comment.


  Hi, Used hg phasbsend which created https://phab.mercurial-scm.org/D6195. 
I've no clue how to merge/handle these two, so feel free to intervene.
  Also added issueNNN to the commit description as suggested.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6188

To: jerry.montfort, #hg-reviewers
Cc: pulkit, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


D6195: test/test-revset2.t: Unset environment variable P (issue1609)

2019-04-04 Thread jerry.montfort (Jerry Montfort)
jerry.montfort created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  The test tests/test-revset2.t fails the test case
  
  "Test repo.anyrevs with customized revset overrides" (line 1609)
  
  if the environment variable P is set. The test implicitly expects that the
  environment, in which it is started, does not export the variable 'P'.
  
  To solve this issue, unset 'P' right before the test commands are run.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6195

AFFECTED FILES
  tests/test-revset2.t

CHANGE DETAILS

diff --git a/tests/test-revset2.t b/tests/test-revset2.t
--- a/tests/test-revset2.t
+++ b/tests/test-revset2.t
@@ -1627,6 +1627,7 @@
   > printprevset = $TESTTMP/printprevset.py
   > EOF
 
+  $ unset P
   $ hg --config revsetalias.P=1 printprevset
   P=[1]
   $ P=3 hg --config revsetalias.P=2 printprevset



To: jerry.montfort, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


D6188: test/test-revset2.t: Unset environment variable P

2019-04-03 Thread jerry.montfort (Jerry Montfort)
jerry.montfort created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.

REVISION SUMMARY
  tests/test-revset2.t fails the test
  
  "Test repo.anyrevs with customized revset overrides" (line 1609)
  
  when the environment variable P is set. The test implicitly expects that the 
environment, in which it is started, does not export the variable 'P'.
  
  This patch unsets 'P' right before the test commands are run.
  
  Fixes bug #6109

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D6188

AFFECTED FILES
  tests/test-revset2.t

CHANGE DETAILS

diff --git a/tests/test-revset2.t b/tests/test-revset2.t
--- a/tests/test-revset2.t
+++ b/tests/test-revset2.t
@@ -1627,6 +1627,7 @@
   > printprevset = $TESTTMP/printprevset.py
   > EOF

+  $ unset P
   $ hg --config revsetalias.P=1 printprevset
   P=[1]
   $ P=3 hg --config revsetalias.P=2 printprevset



To: jerry.montfort, #hg-reviewers
Cc: mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel