Re: [PATCH] template: rename successorssets template into successorgroup

[Sean Farley]

Yuya Nishihara  writes:

> On Mon, 10 Jul 2017 12:45:12 -0700, Sean Farley wrote:
>> Yuya Nishihara  writes:
>> > On Fri, 07 Jul 2017 21:07:18 +0200, Boris Feld wrote:
>> >> # HG changeset patch
>> >> # User Boris Feld 
>> >> # Date 1499454363 -7200
>> >> #  Fri Jul 07 21:06:03 2017 +0200
>> >> # Node ID 508801f7cd1304488b0d9ebf02a76be030608b21
>> >> # Parent  e714159860fd0872ae0555bb07546aa7e9f700e0
>> >> # EXP-Topic renamesuccessosrssetstemplate
>> >> template: rename successorssets template into successorgroup
>> >> 
>> >> The new name seems better and easier to remember for users.
>> >> 
>> >> diff -r e714159860fd -r 508801f7cd13 mercurial/templatekw.py
>> >> --- a/mercurial/templatekw.py Fri Jul 07 08:33:10 2017 +0200
>> >> +++ b/mercurial/templatekw.py Fri Jul 07 21:06:03 2017 +0200
>> >> @@ -602,8 +602,8 @@
>> >> lambda x: {'ctx': repo[x], 'revcache': {}},
>> >> lambda d: _formatrevnode(d['ctx']))
>> >>  
>> >> -@templatekeyword("successorssets")
>> >> -def showsuccessorssets(repo, ctx, **args):
>> >> +@templatekeyword("successorgroup")
>> >> +def showsuccessorgroup(repo, ctx, **args):
>> >>  """Returns a string of sets of successors for a changectx
>> >
>> > Can we rename it to "successorgroups" (plural) as it's the convention of
>> > templatekw? The inner list should be renamed to "successorgroup" or "group"
>> > as well.
>> 
>> Should I do this before pushing (forgot to push!)?
>
> I prefer waiting V2 since this is just a single-line patch renaming the
> function.

Ok, I've dropped these from my queue.


signature.asc
Description: PGP signature
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] template: rename successorssets template into successorgroup

[Yuya Nishihara]

On Mon, 10 Jul 2017 12:45:12 -0700, Sean Farley wrote:
> Yuya Nishihara  writes:
> > On Fri, 07 Jul 2017 21:07:18 +0200, Boris Feld wrote:
> >> # HG changeset patch
> >> # User Boris Feld 
> >> # Date 1499454363 -7200
> >> #  Fri Jul 07 21:06:03 2017 +0200
> >> # Node ID 508801f7cd1304488b0d9ebf02a76be030608b21
> >> # Parent  e714159860fd0872ae0555bb07546aa7e9f700e0
> >> # EXP-Topic renamesuccessosrssetstemplate
> >> template: rename successorssets template into successorgroup
> >> 
> >> The new name seems better and easier to remember for users.
> >> 
> >> diff -r e714159860fd -r 508801f7cd13 mercurial/templatekw.py
> >> --- a/mercurial/templatekw.py  Fri Jul 07 08:33:10 2017 +0200
> >> +++ b/mercurial/templatekw.py  Fri Jul 07 21:06:03 2017 +0200
> >> @@ -602,8 +602,8 @@
> >> lambda x: {'ctx': repo[x], 'revcache': {}},
> >> lambda d: _formatrevnode(d['ctx']))
> >>  
> >> -@templatekeyword("successorssets")
> >> -def showsuccessorssets(repo, ctx, **args):
> >> +@templatekeyword("successorgroup")
> >> +def showsuccessorgroup(repo, ctx, **args):
> >>  """Returns a string of sets of successors for a changectx
> >
> > Can we rename it to "successorgroups" (plural) as it's the convention of
> > templatekw? The inner list should be renamed to "successorgroup" or "group"
> > as well.
> 
> Should I do this before pushing (forgot to push!)?

I prefer waiting V2 since this is just a single-line patch renaming the
function.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] template: rename successorssets template into successorgroup

[Sean Farley]

Yuya Nishihara  writes:

> On Fri, 07 Jul 2017 21:07:18 +0200, Boris Feld wrote:
>> # HG changeset patch
>> # User Boris Feld 
>> # Date 1499454363 -7200
>> #  Fri Jul 07 21:06:03 2017 +0200
>> # Node ID 508801f7cd1304488b0d9ebf02a76be030608b21
>> # Parent  e714159860fd0872ae0555bb07546aa7e9f700e0
>> # EXP-Topic renamesuccessosrssetstemplate
>> template: rename successorssets template into successorgroup
>> 
>> The new name seems better and easier to remember for users.
>> 
>> diff -r e714159860fd -r 508801f7cd13 mercurial/templatekw.py
>> --- a/mercurial/templatekw.pyFri Jul 07 08:33:10 2017 +0200
>> +++ b/mercurial/templatekw.pyFri Jul 07 21:06:03 2017 +0200
>> @@ -602,8 +602,8 @@
>> lambda x: {'ctx': repo[x], 'revcache': {}},
>> lambda d: _formatrevnode(d['ctx']))
>>  
>> -@templatekeyword("successorssets")
>> -def showsuccessorssets(repo, ctx, **args):
>> +@templatekeyword("successorgroup")
>> +def showsuccessorgroup(repo, ctx, **args):
>>  """Returns a string of sets of successors for a changectx
>
> Can we rename it to "successorgroups" (plural) as it's the convention of
> templatekw? The inner list should be renamed to "successorgroup" or "group"
> as well.

Should I do this before pushing (forgot to push!)?


signature.asc
Description: PGP signature
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] template: rename successorssets template into successorgroup

[Yuya Nishihara]

On Fri, 07 Jul 2017 21:07:18 +0200, Boris Feld wrote:
> # HG changeset patch
> # User Boris Feld 
> # Date 1499454363 -7200
> #  Fri Jul 07 21:06:03 2017 +0200
> # Node ID 508801f7cd1304488b0d9ebf02a76be030608b21
> # Parent  e714159860fd0872ae0555bb07546aa7e9f700e0
> # EXP-Topic renamesuccessosrssetstemplate
> template: rename successorssets template into successorgroup
> 
> The new name seems better and easier to remember for users.
> 
> diff -r e714159860fd -r 508801f7cd13 mercurial/templatekw.py
> --- a/mercurial/templatekw.py Fri Jul 07 08:33:10 2017 +0200
> +++ b/mercurial/templatekw.py Fri Jul 07 21:06:03 2017 +0200
> @@ -602,8 +602,8 @@
> lambda x: {'ctx': repo[x], 'revcache': {}},
> lambda d: _formatrevnode(d['ctx']))
>  
> -@templatekeyword("successorssets")
> -def showsuccessorssets(repo, ctx, **args):
> +@templatekeyword("successorgroup")
> +def showsuccessorgroup(repo, ctx, **args):
>  """Returns a string of sets of successors for a changectx

Can we rename it to "successorgroups" (plural) as it's the convention of
templatekw? The inner list should be renamed to "successorgroup" or "group"
as well.
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH] template: rename successorssets template into successorgroup

[Sean Farley]

Boris Feld  writes:

> # HG changeset patch
> # User Boris Feld 
> # Date 1499454363 -7200
> #  Fri Jul 07 21:06:03 2017 +0200
> # Node ID 508801f7cd1304488b0d9ebf02a76be030608b21
> # Parent  e714159860fd0872ae0555bb07546aa7e9f700e0
> # EXP-Topic renamesuccessosrssetstemplate
> template: rename successorssets template into successorgroup
>
> The new name seems better and easier to remember for users.

Looks good, queued!


signature.asc
Description: PGP signature
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

[PATCH] template: rename successorssets template into successorgroup

[Boris Feld]

# HG changeset patch
# User Boris Feld 
# Date 1499454363 -7200
#  Fri Jul 07 21:06:03 2017 +0200
# Node ID 508801f7cd1304488b0d9ebf02a76be030608b21
# Parent  e714159860fd0872ae0555bb07546aa7e9f700e0
# EXP-Topic renamesuccessosrssetstemplate
template: rename successorssets template into successorgroup

The new name seems better and easier to remember for users.

diff -r e714159860fd -r 508801f7cd13 mercurial/templatekw.py
--- a/mercurial/templatekw.py   Fri Jul 07 08:33:10 2017 +0200
+++ b/mercurial/templatekw.py   Fri Jul 07 21:06:03 2017 +0200
@@ -602,8 +602,8 @@
lambda x: {'ctx': repo[x], 'revcache': {}},
lambda d: _formatrevnode(d['ctx']))
 
-@templatekeyword("successorssets")
-def showsuccessorssets(repo, ctx, **args):
+@templatekeyword("successorgroup")
+def showsuccessorgroup(repo, ctx, **args):
 """Returns a string of sets of successors for a changectx
 
 Format used is: [ctx1, ctx2], [ctx3] if ctx has been splitted into ctx1 and
diff -r e714159860fd -r 508801f7cd13 tests/test-obsmarker-template.t
--- a/tests/test-obsmarker-template.t   Fri Jul 07 08:33:10 2017 +0200
+++ b/tests/test-obsmarker-template.t   Fri Jul 07 21:06:03 2017 +0200
@@ -17,9 +17,9 @@
   > {if(predecessors, "\n  semi-colon: {join(predecessors, "; ")}")}\
   > {if(predecessors, "\n  json: {predecessors|json}")}\
   > {if(predecessors, "\n  map: {join(predecessors % "{rev}:{node}", " 
")}")}\
-  > {if(successorssets, "\n  Successors: {successorssets}")}\
-  > {if(successorssets, "\n  multi-line: {join(successorssets, "\n  
multi-line: ")}")}\
-  > {if(successorssets, "\n  json: {successorssets|json}")}\n'
+  > {if(successorgroup, "\n  Successors: {successorgroup}")}\
+  > {if(successorgroup, "\n  multi-line: {join(successorgroup, "\n  
multi-line: ")}")}\
+  > {if(successorgroup, "\n  json: {successorgroup|json}")}\n'
   > EOF
 
 Test templates on amended commit
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel