Re: [PATCH 8 of 8 V2] protocol: send application/mercurial-0.2 responses to capable clients

2016-12-02 Thread Durham Goode 
Cc Jeremy

On 12/2/16, 1:41 PM, "Augie Fackler"  wrote:

On Mon, Nov 28, 2016 at 10:58:25PM -0800, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc 
> # Date 1480399779 28800
> #  Mon Nov 28 22:09:39 2016 -0800
> # Node ID b39ac39041fb47bee2ff9aa49212b84ad83138ae
> # Parent  64c2f7a3f0f2ea73552d6134035335699e450833
> protocol: send application/mercurial-0.2 responses to capable clients

I'm overall happy with this, maybe wait a few days for other comments
on your negotiation protocol (Kyle, maybe you want to take a look?
perhaps someone from Facebook too? Durham, I didn't have an email for
jsgf but it seems like he might be a good one to have a glance at this
stuff) design and then send the patches I didn't take as a v3 (with at
least the one test cleanup I pointed out), and we'll land this?

Thanks!

>
> With this commit, the HTTP transport now parses the X-HgProto header
> to determine what media type and compression engine to use for
> responses. So far, we only compress responses that are already being
> compressed with zlib today (stream response types to specific
> commands). We can expand things to cover additional response types
> later.
>

[...]


___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Re: [PATCH 8 of 8 V2] protocol: send application/mercurial-0.2 responses to capable clients

2016-12-02 Thread Augie Fackler 
On Mon, Nov 28, 2016 at 10:58:25PM -0800, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc 
> # Date 1480399779 28800
> #  Mon Nov 28 22:09:39 2016 -0800
> # Node ID b39ac39041fb47bee2ff9aa49212b84ad83138ae
> # Parent  64c2f7a3f0f2ea73552d6134035335699e450833
> protocol: send application/mercurial-0.2 responses to capable clients

I'm overall happy with this, maybe wait a few days for other comments
on your negotiation protocol (Kyle, maybe you want to take a look?
perhaps someone from Facebook too? Durham, I didn't have an email for
jsgf but it seems like he might be a good one to have a glance at this
stuff) design and then send the patches I didn't take as a v3 (with at
least the one test cleanup I pointed out), and we'll land this?

Thanks!

>
> With this commit, the HTTP transport now parses the X-HgProto header
> to determine what media type and compression engine to use for
> responses. So far, we only compress responses that are already being
> compressed with zlib today (stream response types to specific
> commands). We can expand things to cover additional response types
> later.
>

[...]
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel